| Message ID | 20190625084828.540-3-palmer@sifive.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v2,1/2] net: macb: Kconfig: Make MACB depend on COMMON_CLK | expand |
On 25/06/2019 at 10:48, Palmer Dabbelt wrote: > The help text makes it look like NET_VENDOR_CADENCE enables support for > Atmel devices, when in reality it's a driver written by Atmel that > supports Cadence devices. This may confuse users that have this device > on a non-Atmel SoC. > > The fix is just s/Atmel/Cadence/, but I did go and re-wrap the Kconfig > help text as that change caused it to go over 80 characters. > > Signed-off-by: Palmer Dabbelt <palmer@sifive.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > drivers/net/ethernet/cadence/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig > index 64d8d6ee7739..f4b3bd85dfe3 100644 > --- a/drivers/net/ethernet/cadence/Kconfig > +++ b/drivers/net/ethernet/cadence/Kconfig > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > # > -# Atmel device configuration > +# Cadence device configuration > # > > config NET_VENDOR_CADENCE > @@ -13,8 +13,8 @@ config NET_VENDOR_CADENCE > If unsure, say Y. > > Note that the answer to this question doesn't directly affect the > - kernel: saying N will just cause the configurator to skip all > - the remaining Atmel network card questions. If you say Y, you will be > + kernel: saying N will just cause the configurator to skip all the > + remaining Cadence network card questions. If you say Y, you will be > asked for your specific card in the following questions. > > if NET_VENDOR_CADENCE >
diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig index 64d8d6ee7739..f4b3bd85dfe3 100644 --- a/drivers/net/ethernet/cadence/Kconfig +++ b/drivers/net/ethernet/cadence/Kconfig @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only # -# Atmel device configuration +# Cadence device configuration # config NET_VENDOR_CADENCE @@ -13,8 +13,8 @@ config NET_VENDOR_CADENCE If unsure, say Y. Note that the answer to this question doesn't directly affect the - kernel: saying N will just cause the configurator to skip all - the remaining Atmel network card questions. If you say Y, you will be + kernel: saying N will just cause the configurator to skip all the + remaining Cadence network card questions. If you say Y, you will be asked for your specific card in the following questions. if NET_VENDOR_CADENCE
The help text makes it look like NET_VENDOR_CADENCE enables support for Atmel devices, when in reality it's a driver written by Atmel that supports Cadence devices. This may confuse users that have this device on a non-Atmel SoC. The fix is just s/Atmel/Cadence/, but I did go and re-wrap the Kconfig help text as that change caused it to go over 80 characters. Signed-off-by: Palmer Dabbelt <palmer@sifive.com> --- drivers/net/ethernet/cadence/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)