| Message ID | 20190612151838.7455-1-maxime.chevallier@bootlin.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net,v2] net: ethtool: Allow matching on vlan DEI bit | expand |
From: Maxime Chevallier <maxime.chevallier@bootlin.com> Date: Wed, 12 Jun 2019 17:18:38 +0200 > Using ethtool, users can specify a classification action matching on the > full vlan tag, which includes the DEI bit (also previously called CFI). > > However, when converting the ethool_flow_spec to a flow_rule, we use > dissector keys to represent the matching patterns. > > Since the vlan dissector key doesn't include the DEI bit, this > information was silently discarded when translating the ethtool > flow spec in to a flow_rule. > > This commit adds the DEI bit into the vlan dissector key, and allows > propagating the information to the driver when parsing the ethtool flow > spec. > > Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator") > Reported-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> > --- > V1 -> V2: Use "DEI" instead of the old name "CFI", as suggested by Toshiaki. > Perform endianness swap on the constant, sothat it's done at > build-time, as suggested by Jakub. Applied and queued up for -stable, thanks.
On Wed, 12 Jun 2019 17:18:38 +0200, Maxime Chevallier wrote: > Using ethtool, users can specify a classification action matching on the > full vlan tag, which includes the DEI bit (also previously called CFI). > > However, when converting the ethool_flow_spec to a flow_rule, we use > dissector keys to represent the matching patterns. > > Since the vlan dissector key doesn't include the DEI bit, this > information was silently discarded when translating the ethtool > flow spec in to a flow_rule. > > This commit adds the DEI bit into the vlan dissector key, and allows > propagating the information to the driver when parsing the ethtool flow > spec. > > Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator") > Reported-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> LGTM, thanks!
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h index 7c5a8d9a8d2a..dfabc0503446 100644 --- a/include/net/flow_dissector.h +++ b/include/net/flow_dissector.h @@ -46,6 +46,7 @@ struct flow_dissector_key_tags { struct flow_dissector_key_vlan { u16 vlan_id:12, + vlan_dei:1, vlan_priority:3; __be16 vlan_tpid; }; diff --git a/net/core/ethtool.c b/net/core/ethtool.c index d08b1e19ce9c..4d1011b2e24f 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -3020,6 +3020,11 @@ ethtool_rx_flow_rule_create(const struct ethtool_rx_flow_spec_input *input) match->mask.vlan.vlan_id = ntohs(ext_m_spec->vlan_tci) & 0x0fff; + match->key.vlan.vlan_dei = + !!(ext_h_spec->vlan_tci & htons(0x1000)); + match->mask.vlan.vlan_dei = + !!(ext_m_spec->vlan_tci & htons(0x1000)); + match->key.vlan.vlan_priority = (ntohs(ext_h_spec->vlan_tci) & 0xe000) >> 13; match->mask.vlan.vlan_priority =
Using ethtool, users can specify a classification action matching on the full vlan tag, which includes the DEI bit (also previously called CFI). However, when converting the ethool_flow_spec to a flow_rule, we use dissector keys to represent the matching patterns. Since the vlan dissector key doesn't include the DEI bit, this information was silently discarded when translating the ethtool flow spec in to a flow_rule. This commit adds the DEI bit into the vlan dissector key, and allows propagating the information to the driver when parsing the ethtool flow spec. Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator") Reported-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- V1 -> V2: Use "DEI" instead of the old name "CFI", as suggested by Toshiaki. Perform endianness swap on the constant, sothat it's done at build-time, as suggested by Jakub. include/net/flow_dissector.h | 1 + net/core/ethtool.c | 5 +++++ 2 files changed, 6 insertions(+)