diff mbox series

[v3,net-next] net: fec_ptp: Use dev_err() instead of pr_err()

Message ID 20190605131035.9267-1-festevam@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series [v3,net-next] net: fec_ptp: Use dev_err() instead of pr_err() | expand

Commit Message

Fabio Estevam June 5, 2019, 1:10 p.m. UTC 
dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
---
Changes since v2:
- Made it a standalone patch
- Collected Andy's Ack

 drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller June 5, 2019, 7:13 p.m. UTC | #1 
From: Fabio Estevam <festevam@gmail.com>
Date: Wed,  5 Jun 2019 10:10:35 -0300

> dev_err() is more appropriate for printing error messages inside
> drivers, so switch to dev_err().
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> Changes since v2:
> - Made it a standalone patch
> - Collected Andy's Ack

Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index 7e892b1cbd3d..19e2365be7d8 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -617,7 +617,7 @@  void fec_ptp_init(struct platform_device *pdev, int irq_idx)
 	fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev);
 	if (IS_ERR(fep->ptp_clock)) {
 		fep->ptp_clock = NULL;
-		pr_err("ptp_clock_register failed\n");
+		dev_err(&pdev->dev, "ptp_clock_register failed\n");
 	}
 
 	schedule_delayed_work(&fep->time_keep, HZ);