| Message ID | 20190604030445.21994-2-festevam@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next,v2,1/2] net: fec_main: Use netdev_err() instead of pr_err() | expand |
From: Fabio Estevam <festevam@gmail.com> Sent: Tuesday, June 4, 2019 11:05 AM > dev_err() is more appropriate for printing error messages inside drivers, so > switch to dev_err(). > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Acked-by: Fugang Duan <fugang.duan@nxp.com> > --- > Changes since v1: > - Use dev_err() instead of netdev_err() - Andy > > drivers/net/ethernet/freescale/fec_ptp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fec_ptp.c > b/drivers/net/ethernet/freescale/fec_ptp.c > index 7e892b1cbd3d..19e2365be7d8 100644 > --- a/drivers/net/ethernet/freescale/fec_ptp.c > +++ b/drivers/net/ethernet/freescale/fec_ptp.c > @@ -617,7 +617,7 @@ void fec_ptp_init(struct platform_device *pdev, int > irq_idx) > fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev); > if (IS_ERR(fep->ptp_clock)) { > fep->ptp_clock = NULL; > - pr_err("ptp_clock_register failed\n"); > + dev_err(&pdev->dev, "ptp_clock_register failed\n"); > } > > schedule_delayed_work(&fep->time_keep, HZ); > -- > 2.17.1
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 7e892b1cbd3d..19e2365be7d8 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -617,7 +617,7 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx) fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev); if (IS_ERR(fep->ptp_clock)) { fep->ptp_clock = NULL; - pr_err("ptp_clock_register failed\n"); + dev_err(&pdev->dev, "ptp_clock_register failed\n"); } schedule_delayed_work(&fep->time_keep, HZ);
dev_err() is more appropriate for printing error messages inside drivers, so switch to dev_err(). Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Changes since v1: - Use dev_err() instead of netdev_err() - Andy drivers/net/ethernet/freescale/fec_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)