| Message ID | 20190529143432.19268-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: dsa: sja1105: Make static_config_check_memory_size static | expand |
On Wed, 29 May 2019 at 17:35, YueHaibing <yuehaibing@huawei.com> wrote: > > Fix sparse warning: > > drivers/net/dsa/sja1105/sja1105_static_config.c:446:1: warning: > symbol 'static_config_check_memory_size' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/net/dsa/sja1105/sja1105_static_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.c b/drivers/net/dsa/sja1105/sja1105_static_config.c > index b3c992b0abb0..7e90e62da389 100644 > --- a/drivers/net/dsa/sja1105/sja1105_static_config.c > +++ b/drivers/net/dsa/sja1105/sja1105_static_config.c > @@ -442,7 +442,7 @@ const char *sja1105_static_config_error_msg[] = { > "vl-forwarding-parameters-table.partspc.", > }; > > -sja1105_config_valid_t > +static sja1105_config_valid_t > static_config_check_memory_size(const struct sja1105_table *tables) > { > const struct sja1105_l2_forwarding_params_entry *l2_fwd_params; > -- > 2.17.1 > > Acked-by: Vladimir Oltean <olteanv@gmail.com>
From: YueHaibing <yuehaibing@huawei.com> Date: Wed, 29 May 2019 22:34:32 +0800 > Fix sparse warning: > > drivers/net/dsa/sja1105/sja1105_static_config.c:446:1: warning: > symbol 'static_config_check_memory_size' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied.
diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.c b/drivers/net/dsa/sja1105/sja1105_static_config.c index b3c992b0abb0..7e90e62da389 100644 --- a/drivers/net/dsa/sja1105/sja1105_static_config.c +++ b/drivers/net/dsa/sja1105/sja1105_static_config.c @@ -442,7 +442,7 @@ const char *sja1105_static_config_error_msg[] = { "vl-forwarding-parameters-table.partspc.", }; -sja1105_config_valid_t +static sja1105_config_valid_t static_config_check_memory_size(const struct sja1105_table *tables) { const struct sja1105_l2_forwarding_params_entry *l2_fwd_params;
Fix sparse warning: drivers/net/dsa/sja1105/sja1105_static_config.c:446:1: warning: symbol 'static_config_check_memory_size' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/dsa/sja1105/sja1105_static_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)