| Message ID | 20190529025906.17452-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v2,net-next] net: mvpp2: cls: Remove unnessesary check in mvpp2_ethtool_cls_rule_ins | expand |
From: YueHaibing <yuehaibing@huawei.com> Date: Wed, 29 May 2019 10:59:06 +0800 > Fix smatch warning: > > drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c:1236 > mvpp2_ethtool_cls_rule_ins() warn: unsigned 'info->fs.location' is never less than zero. > > 'info->fs.location' is u32 type, never less than zero. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: rework patch based net-next Applied.
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c index bd19a910dc90..e1c90adb2982 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c @@ -1300,8 +1300,7 @@ int mvpp2_ethtool_cls_rule_ins(struct mvpp2_port *port, struct mvpp2_ethtool_fs *efs, *old_efs; int ret = 0; - if (info->fs.location >= MVPP2_N_RFS_ENTRIES_PER_FLOW || - info->fs.location < 0) + if (info->fs.location >= MVPP2_N_RFS_ENTRIES_PER_FLOW) return -EINVAL; efs = kzalloc(sizeof(*efs), GFP_KERNEL);
Fix smatch warning: drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c:1236 mvpp2_ethtool_cls_rule_ins() warn: unsigned 'info->fs.location' is never less than zero. 'info->fs.location' is u32 type, never less than zero. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v2: rework patch based net-next --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)