Message ID | 20190529011426.1328736-5-andriin@fb.com |
---|---|
State | Changes Requested |
Delegated to: | BPF Maintainers |
Headers | show |
Series | [bpf-next,1/9] libbpf: fix detection of corrupted BPF instructions section | expand |
On Tue, May 28, 2019 at 6:15 PM Andrii Nakryiko <andriin@fb.com> wrote: > > Validate there was no error retrieving symbol name corresponding to > a BPF map. > > Signed-off-by: Andrii Nakryiko <andriin@fb.com> Acked-by: Song Liu <songliubraving@fb.com> > --- > tools/lib/bpf/libbpf.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index c98f9942fba4..7abe71ee507a 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -920,6 +920,11 @@ bpf_object__init_maps(struct bpf_object *obj, int flags) > map_name = elf_strptr(obj->efile.elf, > obj->efile.strtabidx, > sym.st_name); > + if (!map_name) { > + pr_warning("failed to get map #%d name sym string for obj %s\n", > + map_idx, obj->path); > + return -LIBBPF_ERRNO__FORMAT; > + } > > obj->maps[map_idx].libbpf_type = LIBBPF_MAP_UNSPEC; > obj->maps[map_idx].offset = sym.st_value; > -- > 2.17.1 >
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index c98f9942fba4..7abe71ee507a 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -920,6 +920,11 @@ bpf_object__init_maps(struct bpf_object *obj, int flags) map_name = elf_strptr(obj->efile.elf, obj->efile.strtabidx, sym.st_name); + if (!map_name) { + pr_warning("failed to get map #%d name sym string for obj %s\n", + map_idx, obj->path); + return -LIBBPF_ERRNO__FORMAT; + } obj->maps[map_idx].libbpf_type = LIBBPF_MAP_UNSPEC; obj->maps[map_idx].offset = sym.st_value;
Validate there was no error retrieving symbol name corresponding to a BPF map. Signed-off-by: Andrii Nakryiko <andriin@fb.com> --- tools/lib/bpf/libbpf.c | 5 +++++ 1 file changed, 5 insertions(+)