| Message ID | 20190430113408.30572-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | appletalk: Set error code if register_snap_client failed | expand |
From: YueHaibing <yuehaibing@huawei.com> Date: Tue, 30 Apr 2019 19:34:08 +0800 > If register_snap_client fails in atalk_init, > error code should be set, otherwise it will > triggers NULL pointer dereference while unloading > module. > > Fixes: 9804501fa122 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied, thanks.
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 709d254..dbe8b19 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1920,6 +1920,7 @@ static int __init atalk_init(void) ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv); if (!ddp_dl) { pr_crit("Unable to register DDP with SNAP.\n"); + rc = -ENOMEM; goto out_sock; }
If register_snap_client fails in atalk_init, error code should be set, otherwise it will triggers NULL pointer dereference while unloading module. Fixes: 9804501fa122 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/appletalk/ddp.c | 1 + 1 file changed, 1 insertion(+)