From patchwork Sat Mar 30 00:46:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Kleen X-Patchwork-Id: 1070374 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=firstfloor.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44WKfy24VPz9sPM for ; Sat, 30 Mar 2019 11:46:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730299AbfC3AqH (ORCPT ); Fri, 29 Mar 2019 20:46:07 -0400 Received: from mga14.intel.com ([192.55.52.115]:56981 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730180AbfC3AqG (ORCPT ); Fri, 29 Mar 2019 20:46:06 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2019 17:46:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,286,1549958400"; d="scan'208";a="218911610" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.137]) by orsmga001.jf.intel.com with ESMTP; 29 Mar 2019 17:46:06 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 340CC301BE3; Fri, 29 Mar 2019 17:46:06 -0700 (PDT) From: Andi Kleen To: netdev@vger.kernel.org Cc: Andi Kleen Subject: [PATCH] ipv4 ping: Fix __init* attributes Date: Fri, 29 Mar 2019 17:46:00 -0700 Message-Id: <20190330004600.29277-1-andi@firstfloor.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andi Kleen ping_v4_net_ops references init functions, so needs to be __initdata. ping_proc_exit is then referenced from __initdata, so also needs to be __init. Signed-off-by: Andi Kleen --- net/ipv4/ping.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index 7ccb5f87f70b..070e078612a0 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -1160,7 +1160,7 @@ static void __net_exit ping_v4_proc_exit_net(struct net *net) remove_proc_entry("icmp", net->proc_net); } -static struct pernet_operations ping_v4_net_ops = { +static __initdata struct pernet_operations ping_v4_net_ops = { .init = ping_v4_proc_init_net, .exit = ping_v4_proc_exit_net, }; @@ -1170,7 +1170,7 @@ int __init ping_proc_init(void) return register_pernet_subsys(&ping_v4_net_ops); } -void ping_proc_exit(void) +void __init ping_proc_exit(void) { unregister_pernet_subsys(&ping_v4_net_ops); }