From patchwork Wed Mar 27 15:36:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1067142 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="r+hh8rJD"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44TsYD0pbNz9sPx for ; Thu, 28 Mar 2019 02:36:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727371AbfC0Pga (ORCPT ); Wed, 27 Mar 2019 11:36:30 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:39121 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726159AbfC0Pga (ORCPT ); Wed, 27 Mar 2019 11:36:30 -0400 Received: by mail-pl1-f196.google.com with SMTP id b65so3491020plb.6 for ; Wed, 27 Mar 2019 08:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=S1h9OpzYt8eV1J1C2FbuiALev4yMvHzO0Lua1vH7Ebg=; b=r+hh8rJDtDrUa1EySClRTYSUnTj1S8LMjAzVwbvzTkMdwoHmUd+Uzo6RhMCTLjfOar UWWU+HFd6NhhtjivzrrI9um9Xc3Lfvjw4lE7q1ClQf7qgUdrQJm8UCZStKPX2zbIjt7e Ot9qbPbt0G0Ty3lYn1rEFkpieZ8/Oi1L1qSg6/2S+KM3cXNku1SSgBCrP7DIFR3kZte4 I0696Z8ci9cfIi41voLIOl6XWCv3WdwbLQNcaqp8zPj+g1XjTYMtWV0+3zB1G6Yy6fac sQy9+4ep1N9rKuYoM+X8ZecFniHaVY9B7T5a+m/LW3jTR4BMhFgF92a/VxR2D1H5awHQ GFpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=S1h9OpzYt8eV1J1C2FbuiALev4yMvHzO0Lua1vH7Ebg=; b=hUTZQfzZwr7oCS0ZJm1xrpyWOYgPlBd6FS9jA28DruMJrsss5O6QuFZbl7fuZs/v0r IWV/KZfZU16+u9CuvWzwET/tf2rvs4shlmWXHDLgvGzDzee+/o6ede1++lkKoMawxC4v khVieaDZCxeeblRIP7j6Y+R5GPx5GoYV+gP4MZ+YoxKazu8lvtkwEnI4w9QyDIzyh+8i n6cmpKU/lrF6Qan3Z4zgKk1XRi1w8Egb3JFqvTTwuCV7uxPsZjL1ntvVdbnpB/aESKnB T62wIvJ6Th3jwwGiOw5g4hDSA9ICNU/kfa/3WftxOHMHilY1iYyKdo1/SD2Yq+zEbxjN ZMDw== X-Gm-Message-State: APjAAAWGD3Tzb9DkzGTqfIvBp9o2TaUBEzGqSyPc+CLlgGcoDh3378Cn KwRTxCBqTWNNCWAkuwduo0E= X-Google-Smtp-Source: APXvYqwQ3HrL269AaEur12lkfNeobvWzj95EXzzFi2ZI6xtlewq6UrZGSwmXvuzaANVdyi2aXjoo5A== X-Received: by 2002:a17:902:3a5:: with SMTP id d34mr36039601pld.174.1553700990034; Wed, 27 Mar 2019 08:36:30 -0700 (PDT) Received: from localhost.localdomain ([2401:4900:369b:7f6a:5d4e:357e:5f86:c164]) by smtp.gmail.com with ESMTPSA id b15sm33841341pgg.90.2019.03.27.08.36.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 08:36:29 -0700 (PDT) From: Leslie Monis To: stephen@networkplumber.org Cc: netdev@vger.kernel.org, Leslie Monis Subject: [PATCH iproute2 v2 1/2] tc: pie: change maximum integer value of tc_pie_xstats->prob Date: Wed, 27 Mar 2019 21:06:05 +0530 Message-Id: <20190327153606.5524-2-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190327153606.5524-1-lesliemonis@gmail.com> References: <20190327153606.5524-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org tc_pie_xstats->prob has a maximum value of (2^64 - 1). Signed-off-by: Leslie Monis --- tc/q_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/q_pie.c b/tc/q_pie.c index f7924ef5..236ea31b 100644 --- a/tc/q_pie.c +++ b/tc/q_pie.c @@ -198,7 +198,7 @@ static int pie_print_xstats(struct qdisc_util *qu, FILE *f, st = RTA_DATA(xstats); /*prob is returned as a fracion of maximum integer value */ fprintf(f, "prob %f delay %uus avg_dq_rate %u\n", - (double)st->prob / (double)0xffffffff, st->delay, + (double)st->prob / UINT64_MAX, st->delay, st->avg_dq_rate); fprintf(f, "pkts_in %u overlimit %u dropped %u maxq %u ecn_mark %u\n", st->packets_in, st->overlimit, st->dropped, st->maxq,