From patchwork Mon Mar 25 16:17:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 1064503 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=acm.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44SfYY2n1Vz9sRj for ; Tue, 26 Mar 2019 03:17:37 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729606AbfCYQRg (ORCPT ); Mon, 25 Mar 2019 12:17:36 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:32775 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729582AbfCYQRf (ORCPT ); Mon, 25 Mar 2019 12:17:35 -0400 Received: by mail-pf1-f193.google.com with SMTP id i19so6687505pfd.0 for ; Mon, 25 Mar 2019 09:17:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OVR1nATDVdlt69boRyZg3P5dE1CjPHDE/D1UvNmGOJI=; b=Miuu4Xz7EzK0nSw6p7HzsmIR8UZ0X4jj3DpozRATqq1c97oTgnr9et89tV1x6neP/6 D8mZTtKdUwmYj6BURzzY/0j0/5Q2gB2bV9O1oFLgY4qPO3mt4HvvIAAFxfhKInKMcv4v lKPi5VOiS/IDLiKy55RQ1W8WhN+OtrunvYRZR2M0ncO4Cb6Ay7sWnH1wkOVqNMqj7gzd cPNefiIayxSj/8nMc+W26W1c3Zzqjhe84y+l5Rb0f5FSO5mXmoSSitjR2N6fs37/388F gMF9/WeDGNZ7m736PkFDgeuA0oR9ErJ3GmKiXgEb2JKRVcCGOonicvKaMfzqBAOe3f9Q XBwA== X-Gm-Message-State: APjAAAWVdGjURThJRtxyKotpyu/vjRDg9XBcvrBedyfJVSZfHpGS1FL3 M2Wpuek8xMPvXJcxPp+E9v4= X-Google-Smtp-Source: APXvYqz7fOBmdXv9ZmCDZVr1SkrAIPUfEjQDpETJge3NxXHbsZsMCOeVHzsM8y7pEpKvP/dOgpNEDw== X-Received: by 2002:a63:1410:: with SMTP id u16mr22680219pgl.420.1553530654353; Mon, 25 Mar 2019 09:17:34 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id 4sm8931854pgx.68.2019.03.25.09.17.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 09:17:33 -0700 (PDT) From: Bart Van Assche To: David Miller Cc: netdev@vger.kernel.org, Bart Van Assche , Tom Herbert Subject: [PATCH v2 3/5] net/core: Document __skb_flow_dissect() flags argument Date: Mon, 25 Mar 2019 09:17:21 -0700 Message-Id: <20190325161723.144556-4-bvanassche@acm.org> X-Mailer: git-send-email 2.20.GIT In-Reply-To: <20190325161723.144556-1-bvanassche@acm.org> References: <20190325161723.144556-1-bvanassche@acm.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch avoids that the following warning is reported when building with W=1: warning: Function parameter or member 'flags' not described in '__skb_flow_dissect' Cc: Tom Herbert Fixes: cd79a2382aa5 ("flow_dissector: Add flags argument to skb_flow_dissector functions") # v4.3. Signed-off-by: Bart Van Assche --- net/core/flow_dissector.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index bb1a54747d64..b4d581134ef2 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -732,6 +732,8 @@ bool __skb_flow_bpf_dissect(struct bpf_prog *prog, * @proto: protocol for which to get the flow, if @data is NULL use skb->protocol * @nhoff: network header offset, if @data is NULL use skb_network_offset(skb) * @hlen: packet header length, if @data is NULL use skb_headlen(skb) + * @flags: flags that control the dissection process, e.g. + * FLOW_DISSECTOR_F_STOP_AT_L3. * * The function will try to retrieve individual keys into target specified * by flow_dissector from either the skbuff or a raw buffer specified by the