Message ID | 20190324032346.32394-5-olteanv@gmail.com |
---|---|
State | RFC |
Delegated to: | David Miller |
Headers | show |
Series | NXP SJA1105 DSA driver | expand |
On 3/23/19 8:23 PM, Vladimir Oltean wrote: > This allows the driver to perform some manipulations of its own during > setup, using generic code. > One current usage scenario is for the driver to request DSA to set up > 802.1Q based switch tagging for its ports. > > Signed-off-by: Vladimir Oltean <olteanv@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index c00ee464afc7..5beceb18b7e2 100644 --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c @@ -360,14 +360,14 @@ static int dsa_switch_setup(struct dsa_switch *ds) if (err) return err; - err = ds->ops->setup(ds); - if (err < 0) - return err; - err = dsa_switch_register_notifier(ds); if (err) return err; + err = ds->ops->setup(ds); + if (err < 0) + return err; + if (!ds->slave_mii_bus && ds->ops->phy_read) { ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev); if (!ds->slave_mii_bus)
This allows the driver to perform some manipulations of its own during setup, using generic code. One current usage scenario is for the driver to request DSA to set up 802.1Q based switch tagging for its ports. Signed-off-by: Vladimir Oltean <olteanv@gmail.com> --- net/dsa/dsa2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)