From patchwork Thu Mar 21 22:19:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 1060523 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=acm.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44QLnn1NxXz9sQm for ; Fri, 22 Mar 2019 09:20:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727386AbfCUWUB (ORCPT ); Thu, 21 Mar 2019 18:20:01 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40697 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727252AbfCUWT5 (ORCPT ); Thu, 21 Mar 2019 18:19:57 -0400 Received: by mail-pf1-f196.google.com with SMTP id c207so56568pfc.7 for ; Thu, 21 Mar 2019 15:19:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mhR59C0bZkFAZVgYiFLX1iW2ufR5rsO3ckbomej8kCA=; b=N+zCEDwHJ2hlsXKT0/mM1qLTlfjJdQOZYdJ+qj0N8613vn+O74xaIhoLyTWehaCV2/ nD9vgGFk+/mWaK2Xce0MBjemS20ckKOpFVPBBmdZP487ecT9QqvIj9g6xKdfj5PB8Zrk GFRhq+ejOdelvkBB5y2IWJ+erguY9q7y5slqrPHZv/0R6QO7ZnXRfqaKRs5Nlu4KblEr xsqrdSMqk19H6fMlmFsYo5Vad4n5Gchz6x5kMPGIL0FJi2UQE2FBqBYEx8y7vb1TCXVC V8aKqnPeiIt45LEcldTl/JdyJFLrMge9UHzkFzt4L7HtPbndC2l4vomdWpx9ekWpLQQg ZTmQ== X-Gm-Message-State: APjAAAWGDBVEPVesVoZuFiA9NIBxSeHleWLb3RNJiOmrpH0MYNZvRw2a rZ6leUPBZDHD0XC0FbtJlOU= X-Google-Smtp-Source: APXvYqz8uHp5RnoacEkt6El/rFSTiEA0ZNTdTwagDs9IgPTWOxwD/mQILzRvvLXg1+jnd6N4F1dELQ== X-Received: by 2002:a63:cd10:: with SMTP id i16mr5420023pgg.90.1553206796696; Thu, 21 Mar 2019 15:19:56 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id l7sm16862892pfj.162.2019.03.21.15.19.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 15:19:55 -0700 (PDT) From: Bart Van Assche To: David Miller Cc: netdev@vger.kernel.org, Bart Van Assche , Al Viro Subject: [PATCH 2/7] net/core: Document all dev_ioctl() arguments Date: Thu, 21 Mar 2019 15:19:41 -0700 Message-Id: <20190321221946.163803-3-bvanassche@acm.org> X-Mailer: git-send-email 2.20.GIT In-Reply-To: <20190321221946.163803-1-bvanassche@acm.org> References: <20190321221946.163803-1-bvanassche@acm.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch avoids that the following warnings are reported when building with W=1: net/core/dev_ioctl.c:378: warning: Function parameter or member 'ifr' not described in 'dev_ioctl' net/core/dev_ioctl.c:378: warning: Function parameter or member 'need_copyout' not described in 'dev_ioctl' net/core/dev_ioctl.c:378: warning: Excess function parameter 'arg' description in 'dev_ioctl' Cc: Al Viro Fixes: 44c02a2c3dc5 ("dev_ioctl(): move copyin/copyout to callers") # v4.16. Signed-off-by: Bart Van Assche --- net/core/dev_ioctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c index 31380fd5a4e2..5163d900bb4f 100644 --- a/net/core/dev_ioctl.c +++ b/net/core/dev_ioctl.c @@ -366,7 +366,8 @@ EXPORT_SYMBOL(dev_load); * dev_ioctl - network device ioctl * @net: the applicable net namespace * @cmd: command to issue - * @arg: pointer to a struct ifreq in user space + * @ifr: pointer to a struct ifreq in user space + * @need_copyout: whether or not copy_to_user() should be called * * Issue ioctl functions to devices. This is normally called by the * user space syscall interfaces but can sometimes be useful for