diff mbox series

rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static

Message ID 20190319151927.19392-1-yuehaibing@huawei.com
State Awaiting Upstream
Delegated to: David Miller
Headers show
Series rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static | expand

Commit Message

Yue Haibing March 19, 2019, 3:19 p.m. UTC
From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c:666:6:
 warning: symbol 'rtl8723e_dm_refresh_rate_adaptive_mask' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ping-Ke Shih March 20, 2019, 2:32 a.m. UTC | #1
On Tue, 2019-03-19 at 23:19 +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c:666:6:
>  warning: symbol 'rtl8723e_dm_refresh_rate_adaptive_mask' was not declared.
> Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

The mail subject should be 'rtlwifi: rtl8723ae: ....'.


> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> index 514891e..d8260c7 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> @@ -663,7 +663,7 @@ void rtl8723e_dm_init_rate_adaptive_mask(struct
> ieee80211_hw *hw)
>  
>  }
>  
> -void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
> +static void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
>  {
>  	struct rtl_priv *rtlpriv = rtl_priv(hw);
>  	struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
Kalle Valo April 13, 2019, 11:18 a.m. UTC | #2
Yue Haibing <yuehaibing@huawei.com> wrote:

> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c:666:6:
>  warning: symbol 'rtl8723e_dm_refresh_rate_adaptive_mask' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

bdfc4027de15 rtlwifi: rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
index 514891e..d8260c7 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
@@ -663,7 +663,7 @@  void rtl8723e_dm_init_rate_adaptive_mask(struct ieee80211_hw *hw)
 
 }
 
-void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
+static void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
 {
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));