From patchwork Thu Feb 21 05:49:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 1045764 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="uye2tYOO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 444k8L6ZQgz9s2R for ; Thu, 21 Feb 2019 16:50:10 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbfBUFuI (ORCPT ); Thu, 21 Feb 2019 00:50:08 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:41428 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726723AbfBUFuH (ORCPT ); Thu, 21 Feb 2019 00:50:07 -0500 Received: by mail-qt1-f195.google.com with SMTP id v10so30227588qtp.8 for ; Wed, 20 Feb 2019 21:50:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ugol0rgDCJ10tdYejpAP4lSNDuzdaHwVbfjsfuyPKr4=; b=uye2tYOOC0bZ39eWdPJnH1bptH+S4Cs9o0M6xgMzLkhahm4hMVUOBbQkW51Ti19KMR oerpGE8JpjWjD4HGM4SeomN1VM20+2cy3mnkc8I/+NV3bEp6ey8gbknhjyzULWebul0a 6udN8DWGUjVYkGNzqLEre31/UHMSHjLYlYWYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ugol0rgDCJ10tdYejpAP4lSNDuzdaHwVbfjsfuyPKr4=; b=IdeqpZ3EskxdYRHP0SUtQa45LJF99EFfdDdt9mXWqA3r6ERzv0dv+rqGfE8OceQhWM u28btB0EzvD5B0bMpX4d8xSSpk8UBMkHByduKyBB9uYNvbmLKSaW4IVyR/+XSWLQKx00 r+at9j3Ohedx/H4uOpWEfvFmUFgmw0Dw6NFwzE7fdwUyw3o2woIe2YpaPvpJBH44/Ivx AE8YOSzW9qE2NI+B8ee8pc7fH4VqlwHWaKeaAe6sMNiZqrE+JyShINPASa+mPE5KXXZp K+cQy6H8iBVWjti8jVmnOb8EUOAedF9FJjQsUGNcKffW8V0JEcuacC+wo+ylLBI8NtR2 d/2g== X-Gm-Message-State: AHQUAubeh+M25/LCkUwZ5lEpF45st6MqHcYCOsqmphtku83nwcSwhdP9 tgx+fvoHs/1v05GbGz9XVBRbDg== X-Google-Smtp-Source: AHgI3IY1x2CsKnOyckwybfdh/IC8vE4HGJ48wjA9vpW4LbhlPy2SxC91fb7T2aBEZJUZvnNh7C0Y8A== X-Received: by 2002:a0c:b60d:: with SMTP id f13mr4809691qve.209.1550728205769; Wed, 20 Feb 2019 21:50:05 -0800 (PST) Received: from joelaf.cam.corp.google.com ([2620:0:1004:1100:cca9:fccc:8667:9bdc]) by smtp.gmail.com with ESMTPSA id k185sm11561219qkd.62.2019.02.20.21.50.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 21:50:04 -0800 (PST) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Alexei Starovoitov , Christian Brauner , Daniel Borkmann , David Ahern , "David S. Miller" , Ido Schimmel , Ingo Molnar , intel-wired-lan@lists.osuosl.org (moderated list:INTEL ETHERNET DRIVERS), Jakub Kicinski , Jeff Kirsher , Jesper Dangaard Brouer , John Fastabend , Josh Triplett , keescook@chromium.org, Lai Jiangshan , Martin KaFai Lau , Mathieu Desnoyers , netdev@vger.kernel.org, "Paul E. McKenney" , Peter Zijlstra , rcu@vger.kernel.org, Song Liu , Steven Rostedt , xdp-newbies@vger.kernel.org, Yonghong Song Subject: [PATCH RFC 5/5] rcuwait: Replace rcu_assign_pointer() with WRITE_ONCE Date: Thu, 21 Feb 2019 00:49:42 -0500 Message-Id: <20190221054942.132388-6-joel@joelfernandes.org> X-Mailer: git-send-email 2.21.0.rc0.258.g878e2cd30e-goog In-Reply-To: <20190221054942.132388-1-joel@joelfernandes.org> References: <20190221054942.132388-1-joel@joelfernandes.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This suppresses a sparse error generated due to the recently added rcu_assign_pointer sparse check below. It seems WRITE_ONCE should be sufficient here. >> kernel//locking/percpu-rwsem.c:162:9: sparse: error: incompatible types in comparison expression (different address spaces) Signed-off-by: Joel Fernandes (Google) --- include/linux/rcuwait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/rcuwait.h b/include/linux/rcuwait.h index 90bfa3279a01..9e5b4760e6c2 100644 --- a/include/linux/rcuwait.h +++ b/include/linux/rcuwait.h @@ -44,7 +44,7 @@ extern void rcuwait_wake_up(struct rcuwait *w); */ \ WARN_ON(current->exit_state); \ \ - rcu_assign_pointer((w)->task, current); \ + WRITE_ONCE((w)->task, current); \ for (;;) { \ /* \ * Implicit barrier (A) pairs with (B) in \