| Message ID | 20190219061800.31025-2-vkoul@kernel.org |
|---|---|
| State | Superseded |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: phy: at803x: Update delays for RGMII modes | expand |
On 19/02/2019 07:17, Vinod Koul wrote: > Some helpers were inlined, but makes more sense to allow compiler > to do the right optimizations instead, so remove inline for > at803x_disable_rx_delay() and at803x_disable_tx_delay() I would word it slightly differently: Some helpers were declared with the "inline" function specifier. It is preferable to let the compiler pick the right optimizations, so drop the specifier. [ This is just a random suggestion, feel free to ignore ] > Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > drivers/net/phy/at803x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > index 8ff12938ab47..c6e7d800fd7a 100644 > --- a/drivers/net/phy/at803x.c > +++ b/drivers/net/phy/at803x.c > @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, > return phy_write(phydev, AT803X_DEBUG_DATA, val); > } > > -static inline int at803x_disable_rx_delay(struct phy_device *phydev) > +static int at803x_disable_rx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, > AT803X_DEBUG_RX_CLK_DLY_EN, 0); > } > > -static inline int at803x_disable_tx_delay(struct phy_device *phydev) > +static int at803x_disable_tx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, > AT803X_DEBUG_TX_CLK_DLY_EN, 0); Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 8ff12938ab47..c6e7d800fd7a 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, return phy_write(phydev, AT803X_DEBUG_DATA, val); } -static inline int at803x_disable_rx_delay(struct phy_device *phydev) +static int at803x_disable_rx_delay(struct phy_device *phydev) { return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, AT803X_DEBUG_RX_CLK_DLY_EN, 0); } -static inline int at803x_disable_tx_delay(struct phy_device *phydev) +static int at803x_disable_tx_delay(struct phy_device *phydev) { return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, AT803X_DEBUG_TX_CLK_DLY_EN, 0);