| Message ID | 20190209003248.31088-10-f.fainelli@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: Remove switchdev_ops | expand |
Sat, Feb 09, 2019 at 01:32:41AM CET, f.fainelli@gmail.com wrote: >In preparation for allowing switchdev enabled drivers to veto specific >attribute settings from within the context of the caller, introduce a >new switchdev notifier type for port attributes. > >Suggested-by: Ido Schimmel <idosch@mellanox.com> >Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >--- > include/net/switchdev.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > >diff --git a/include/net/switchdev.h b/include/net/switchdev.h >index 96cd3e795f7f..4c5f7e5430cf 100644 >--- a/include/net/switchdev.h >+++ b/include/net/switchdev.h >@@ -141,6 +141,8 @@ enum switchdev_notifier_type { > SWITCHDEV_VXLAN_FDB_ADD_TO_DEVICE, > SWITCHDEV_VXLAN_FDB_DEL_TO_DEVICE, > SWITCHDEV_VXLAN_FDB_OFFLOADED, >+ >+ SWITCHDEV_PORT_ATTR_SET, /* Blocking. */ This is not UAPI. You can put it next to SWITCHDEV_PORT_OBJ_ADD and SWITCHDEV_PORT_OBJ_DEL. Up to you. With or without that: Acked-by: Jiri Pirko <jiri@mellanox.com>
diff --git a/include/net/switchdev.h b/include/net/switchdev.h index 96cd3e795f7f..4c5f7e5430cf 100644 --- a/include/net/switchdev.h +++ b/include/net/switchdev.h @@ -141,6 +141,8 @@ enum switchdev_notifier_type { SWITCHDEV_VXLAN_FDB_ADD_TO_DEVICE, SWITCHDEV_VXLAN_FDB_DEL_TO_DEVICE, SWITCHDEV_VXLAN_FDB_OFFLOADED, + + SWITCHDEV_PORT_ATTR_SET, /* Blocking. */ }; struct switchdev_notifier_info { @@ -163,6 +165,13 @@ struct switchdev_notifier_port_obj_info { bool handled; }; +struct switchdev_notifier_port_attr_info { + struct switchdev_notifier_info info; /* must be first */ + const struct switchdev_attr *attr; + struct switchdev_trans *trans; + bool handled; +}; + static inline struct net_device * switchdev_notifier_info_to_dev(const struct switchdev_notifier_info *info) {
In preparation for allowing switchdev enabled drivers to veto specific attribute settings from within the context of the caller, introduce a new switchdev notifier type for port attributes. Suggested-by: Ido Schimmel <idosch@mellanox.com> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- include/net/switchdev.h | 9 +++++++++ 1 file changed, 9 insertions(+)