From patchwork Fri Feb 1 00:19:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maciej Fijalkowski X-Patchwork-Id: 1034534 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gsdgmN6C"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43rHn24kbNz9sMl for ; Fri, 1 Feb 2019 11:20:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728830AbfBAAUV (ORCPT ); Thu, 31 Jan 2019 19:20:21 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:38928 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728020AbfBAAUS (ORCPT ); Thu, 31 Jan 2019 19:20:18 -0500 Received: by mail-lj1-f196.google.com with SMTP id t9-v6so4290709ljh.6 for ; Thu, 31 Jan 2019 16:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jB/wWARF7FufCp469kCSSGF/1E9axUfEeUTkh8e2NDc=; b=gsdgmN6CQkv2o1cLUOchNKojgPy2DENqVcS4CLfWeUHdz0j3mkrVBVFsg4L0Yb7WUg 8cV9Ybe4UF+nBBDDrAe16AIkh7BSSSg4DHS9/HJ3QOjEkl4npAif25HV0tfuoW0FzX+e wUsXVuGLT3xSHweozVDMizLaSQgbLvIYYy89MD8weTcAGp1MTuUMv6Y8WpkxjqxSquik yKURIao+GGYEdyxe8gjDtKpVklMuA7t3IziP/P1PvCyaZ42q/n8Cm9TCxAKv0pnctSzj d/IH7rkJ9b8yM8vJoBCesKC5/DvAxo+8sMX2oSwBNBtQJGk5KNYF3Y7u6oKfL7G0bUNB i7zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jB/wWARF7FufCp469kCSSGF/1E9axUfEeUTkh8e2NDc=; b=YhDQsJc6EKmud2o372vLribHhPRTJ4CGRm0SLuVSPYrM4P2MKc46VdHsrJigjoMB7F rUYPgqyAlt16bWJ7dGkFGr4a72s90k1RW0hQjG7m5z7b7IZqUe7q4cfkRiPVmVDJ4WMJ yNvAU+2gaJwlsx1E6Bw1UnS1zzkkBBdul0FI/pGHPKw1vmjR4hjhB8vfh2kBBQGDVL6n XOS+G7Y/ho7i/aI3qpuBMjiS20XKNLMdjAeRQga7D0lxV69aEDTbus9hkrkw+2UMiPe2 tqHmUqLevsI2Hmb5UQdqXyMjiknOtok6tN4+xPLZ5AZOeA/iYgypjogEFzLL8XJUL495 gSIA== X-Gm-Message-State: AJcUukfky0DPQzKQd5Vgtz7pGTjGntxF6auAExipgq3qj903p9qnzL34 lJPZEVxFJEAzHETnzTj0ERw= X-Google-Smtp-Source: ALg8bN40cXkBTyqwp53UbmZw1QmFnepA3K+DUIuar21G1X9bNkJ3P0ZqUM+LzjpchmbYHy54PwRP4Q== X-Received: by 2002:a2e:93d7:: with SMTP id p23-v6mr29808079ljh.22.1548980416751; Thu, 31 Jan 2019 16:20:16 -0800 (PST) Received: from localhost.localdomain (host-185-93-94-63.ip-point.pl. [185.93.94.63]) by smtp.gmail.com with ESMTPSA id j18-v6sm1005495ljc.52.2019.01.31.16.20.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 31 Jan 2019 16:20:16 -0800 (PST) From: Maciej Fijalkowski X-Google-Original-From: Maciej Fijalkowski To: daniel@iogearbox.net, ast@kernel.org Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com, john.fastabend@gmail.com Subject: [PATCH bpf-next v5 2/8] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe Date: Fri, 1 Feb 2019 01:19:48 +0100 Message-Id: <20190201001954.4130-3-maciej.fijalkowski@intel.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20190201001954.4130-1-maciej.fijalkowski@intel.com> References: <20190201001954.4130-1-maciej.fijalkowski@intel.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jesper Dangaard Brouer The sample xdp_redirect_cpu is not using helper bpf_trace_printk. Thus it makes no sense that the --debug option us reading from /sys/kernel/debug/tracing/trace_pipe via read_trace_pipe. Simply remove it. Signed-off-by: Jesper Dangaard Brouer Acked-by: John Fastabend --- samples/bpf/xdp_redirect_cpu_user.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/samples/bpf/xdp_redirect_cpu_user.c b/samples/bpf/xdp_redirect_cpu_user.c index 2d23054aaccf..f141e752ca0a 100644 --- a/samples/bpf/xdp_redirect_cpu_user.c +++ b/samples/bpf/xdp_redirect_cpu_user.c @@ -51,7 +51,6 @@ static const struct option long_options[] = { {"help", no_argument, NULL, 'h' }, {"dev", required_argument, NULL, 'd' }, {"skb-mode", no_argument, NULL, 'S' }, - {"debug", no_argument, NULL, 'D' }, {"sec", required_argument, NULL, 's' }, {"prognum", required_argument, NULL, 'p' }, {"qsize", required_argument, NULL, 'q' }, @@ -563,7 +562,6 @@ int main(int argc, char **argv) bool use_separators = true; bool stress_mode = false; char filename[256]; - bool debug = false; int added_cpus = 0; int longindex = 0; int interval = 2; @@ -624,9 +622,6 @@ int main(int argc, char **argv) case 'S': xdp_flags |= XDP_FLAGS_SKB_MODE; break; - case 'D': - debug = true; - break; case 'x': stress_mode = true; break; @@ -688,11 +683,6 @@ int main(int argc, char **argv) return EXIT_FAIL_XDP; } - if (debug) { - printf("Debug-mode reading trace pipe (fix #define DEBUG)\n"); - read_trace_pipe(); - } - stats_poll(interval, use_separators, prog_num, stress_mode); return EXIT_OK; }