From patchwork Thu Jan 31 16:27:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jian-Hong Pan X-Patchwork-Id: 1034371 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=g.ncu.edu.tw Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=g.ncu.edu.tw header.i=@g.ncu.edu.tw header.b="BJ7A7eZd"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43r5Hc41Fbz9sBb for ; Fri, 1 Feb 2019 03:27:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388482AbfAaQ1j (ORCPT ); Thu, 31 Jan 2019 11:27:39 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:38288 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731284AbfAaQ1j (ORCPT ); Thu, 31 Jan 2019 11:27:39 -0500 Received: by mail-pf1-f195.google.com with SMTP id q1so1698659pfi.5 for ; Thu, 31 Jan 2019 08:27:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=g.ncu.edu.tw; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tlGiMXUWy+a+3XJRM2hLCTrUQH3VtC/Wa6UMc+SZeW4=; b=BJ7A7eZdjP+av4OuMqsjlMxg7uOq04CuznGtUH9fT74jGx9MY4UgFxh56izIPVuu0+ DUEBxjN1qwBfobTsyPvCOOYU7kQEFsYvtnpoi1BbJLmcDXlxJzsZ24eYorB0JIMjfzvL OSyEQDrmn31ZddGYPc3QSozVDLrBTo0Xqhn3M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tlGiMXUWy+a+3XJRM2hLCTrUQH3VtC/Wa6UMc+SZeW4=; b=B16E2oz3LNt1oqL9QOKZRjVZTU6rZGjWAGZYCFHy9SNW0cItIRWGh3T0DEzMutv84x g6BmcHpHN/gYMn2uAWckuY6mccoq9+ygPlShEQFiFanou/4Z0VBtasESobk3D66EQpRe ZpDb+gqR3DD9v+Cb51zisFgzJy2V5UeVc56nSczeaY7k0hjzZ9SccNyVCOijgM76gHjk 9cNRrHlCJiSfU+LrFuMUZZcxXkClcZ/LZ9aKXoLTcFw9L0u6b48OhqbifhGk/cOE4wiD 1r2+8x2qMkkavnxqTmHM4zQ5Y6d0/tyKZrHtNm334AJlsIe4wL8MRU72BivHnREthhdC y2ig== X-Gm-Message-State: AHQUAuaA4n8TdIsjMVkP6kUbcPoOjazIiCuh8BHz+scvNsaR4GbM3OKk wGm6zgPklccytafvvgh9JBxQWA== X-Google-Smtp-Source: AHgI3IbuvuiUZgfTWu/fRJx3A8qno9ThShVRhaX95wVHfqIfPp2tLdhAQHoN0m15cbf5zFSR69sGbw== X-Received: by 2002:a62:2018:: with SMTP id g24mr2658899pfg.100.1548952058415; Thu, 31 Jan 2019 08:27:38 -0800 (PST) Received: from starnight.local ([150.116.255.181]) by smtp.gmail.com with ESMTPSA id a15sm6390655pgb.1.2019.01.31.08.27.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 08:27:37 -0800 (PST) From: Jian-Hong Pan To: =?utf-8?q?Andreas_F=C3=A4rber?= Cc: netdev@vger.kernel.org, linux-lpwan@lists.infradead.org, Ben Whitten , Jian-Hong Pan Subject: [RFC PATCH v2 2/5] net: lorawan: Remove unused lrw_dev_hard_header function Date: Fri, 1 Feb 2019 00:27:52 +0800 Message-Id: <20190131162752.18534-1-starnight@g.ncu.edu.tw> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190131162101.18386-1-starnight@g.ncu.edu.tw> References: <20190131162101.18386-1-starnight@g.ncu.edu.tw> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The lorawan module is an abastraction layer over the LoRaWAN soft and hard MAC. It passes the original buffer to the real MAC layer. So, this patch removes the lrw_dev_hard_header function. Fixes: 48e5bb6cec79 ("net: Prepare LoRaWAN socket module") Signed-off-by: Jian-Hong Pan --- v2: - Modify the commit message net/lorawan/socket.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/net/lorawan/socket.c b/net/lorawan/socket.c index 31a77c3e5ee9..38cee1ff02af 100644 --- a/net/lorawan/socket.c +++ b/net/lorawan/socket.c @@ -115,14 +115,6 @@ dgram_bind(struct sock *sk, struct sockaddr *uaddr, int len) return ret; } -static int -lrw_dev_hard_header(struct sk_buff *skb, struct net_device *ndev, - const u32 src_devaddr, size_t len) -{ - /* TODO: Prepare the LoRaWAN sending header here */ - return 0; -} - static int dgram_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) { @@ -176,10 +168,6 @@ dgram_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) skb_reserve(skb, hlen); skb_reset_network_header(skb); - ret = lrw_dev_hard_header(skb, ndev, 0, size); - if (ret < 0) - goto dgram_sendmsg_no_skb; - ret = memcpy_from_msg(skb_put(skb, size), msg, size); if (ret > 0) goto dgram_sendmsg_err_skb;