From patchwork Mon Jan 28 19:16:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maciej Fijalkowski X-Patchwork-Id: 1032195 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nzRm93hP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43pK9z035Qz9sDK for ; Tue, 29 Jan 2019 06:16:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727714AbfA1TQh (ORCPT ); Mon, 28 Jan 2019 14:16:37 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:44897 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726914AbfA1TQg (ORCPT ); Mon, 28 Jan 2019 14:16:36 -0500 Received: by mail-lf1-f65.google.com with SMTP id z13so12712410lfe.11 for ; Mon, 28 Jan 2019 11:16:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tOSXZu5yZxn2uEqSYtv9bSchsaXMOBUmMRnB0hfrgZ4=; b=nzRm93hPlKfflXTRKhfOjJVhDD7EQ3OJLlorTQhh1mhAVns13B5MMXgrVZ/2Yjd7Wc CsuxZXEiKZrjuLb38A/oMI1SH3DQFtxYq9a6J3bgqYt4rPBS/LqQHQ4NJgmlC+nk1B2w FtgJ2HJaORRxs0asRpH+2mxGCltkpqacpIOHu3Sv+Fns7e6lXNQgS7YZmaQIY9jzu1+R E3zIo3lDyp3EX2+A7A3jsalV6c7+fMC60owEAM0HwaNYk5xJHHvcY8mQqkzXBpGpKavO GiGr4b4hqI4g5t+EdhKb/IJrUNBi7qcPUax/9YR1XbWhoccDCWUz4Kr28CnXj72DFNp/ Vvjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tOSXZu5yZxn2uEqSYtv9bSchsaXMOBUmMRnB0hfrgZ4=; b=l7B+p+Usn9DqeFt0gN72IQR3Q0IhhvEyv8r5obAahcQD1r216LtMfFJtN0mst9lguF kT2sT30/kuPAsc8u9sLdYfOSpgc61bTyS3djEDLg+SV8HDG2DroLU2ItZ5DwqR0eqFJw nYMcJVSqmisj+YPUCk1VgslRDw5DaxwndSxrVImETK9km6H9pG+7Bvl1mzhv7laChGiE 4Nx3AkxQi/khJbr8fdb+hsnVh9gsceESsIyU2hqSpUJbwM7snPSsdGoj0nS+wor1WNBu MzfmMBwycjp+PNolA2GLmQNjcG2jEq7wJg8d89SIIVN8Vq5XAAqq611hPuYS37hr4LuG v8eg== X-Gm-Message-State: AJcUukexHK2QezBbVP033Joij+SbGSSIQXy1DhoqA4yUCm6iyjGiOiEJ vPgQf7n8BxkWBtZjDAIoyIU= X-Google-Smtp-Source: ALg8bN5BbOGITww/RpYmOUIAaftavh6yJUY7k0cRkFLRML02mr4pQL8+LRxZNjIKyT63OPBDR+L4MA== X-Received: by 2002:a19:d5:: with SMTP id 204mr18754159lfa.116.1548702993965; Mon, 28 Jan 2019 11:16:33 -0800 (PST) Received: from localhost.localdomain (host-185-93-94-63.ip-point.pl. [185.93.94.63]) by smtp.gmail.com with ESMTPSA id q3sm3003462lff.42.2019.01.28.11.16.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 28 Jan 2019 11:16:33 -0800 (PST) From: Maciej Fijalkowski To: daniel@iogearbox.net, ast@kernel.org Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com Subject: [PATCH bpf-next v4 2/7] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe Date: Mon, 28 Jan 2019 20:16:08 +0100 Message-Id: <20190128191613.11705-3-maciejromanfijalkowski@gmail.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20190128191613.11705-1-maciejromanfijalkowski@gmail.com> References: <20190128191613.11705-1-maciejromanfijalkowski@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jesper Dangaard Brouer The sample xdp_redirect_cpu is not using helper bpf_trace_printk. Thus it makes no sense that the --debug option us reading from /sys/kernel/debug/tracing/trace_pipe via read_trace_pipe. Simply remove it. Signed-off-by: Jesper Dangaard Brouer Acked-by: John Fastabend --- samples/bpf/xdp_redirect_cpu_user.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/samples/bpf/xdp_redirect_cpu_user.c b/samples/bpf/xdp_redirect_cpu_user.c index 2d23054aaccf..f141e752ca0a 100644 --- a/samples/bpf/xdp_redirect_cpu_user.c +++ b/samples/bpf/xdp_redirect_cpu_user.c @@ -51,7 +51,6 @@ static const struct option long_options[] = { {"help", no_argument, NULL, 'h' }, {"dev", required_argument, NULL, 'd' }, {"skb-mode", no_argument, NULL, 'S' }, - {"debug", no_argument, NULL, 'D' }, {"sec", required_argument, NULL, 's' }, {"prognum", required_argument, NULL, 'p' }, {"qsize", required_argument, NULL, 'q' }, @@ -563,7 +562,6 @@ int main(int argc, char **argv) bool use_separators = true; bool stress_mode = false; char filename[256]; - bool debug = false; int added_cpus = 0; int longindex = 0; int interval = 2; @@ -624,9 +622,6 @@ int main(int argc, char **argv) case 'S': xdp_flags |= XDP_FLAGS_SKB_MODE; break; - case 'D': - debug = true; - break; case 'x': stress_mode = true; break; @@ -688,11 +683,6 @@ int main(int argc, char **argv) return EXIT_FAIL_XDP; } - if (debug) { - printf("Debug-mode reading trace pipe (fix #define DEBUG)\n"); - read_trace_pipe(); - } - stats_poll(interval, use_separators, prog_num, stress_mode); return EXIT_OK; }