From patchwork Mon Jan 28 18:05:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Chopra X-Patchwork-Id: 1032111 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=marvell.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43pHfD21j0z9s3q for ; Tue, 29 Jan 2019 05:07:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbfA1SHb (ORCPT ); Mon, 28 Jan 2019 13:07:31 -0500 Received: from mail-eopbgr740042.outbound.protection.outlook.com ([40.107.74.42]:52417 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726738AbfA1SHa (ORCPT ); Mon, 28 Jan 2019 13:07:30 -0500 Received: from SN4PR0701CA0006.namprd07.prod.outlook.com (2603:10b6:803:28::16) by DM5PR07MB2907.namprd07.prod.outlook.com (2603:10b6:3:9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.17; Mon, 28 Jan 2019 18:07:26 +0000 Received: from BY2NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::201) by SN4PR0701CA0006.outlook.office365.com (2603:10b6:803:28::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1537.26 via Frontend Transport; Mon, 28 Jan 2019 18:07:25 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT021.mail.protection.outlook.com (10.152.100.158) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1580.2 via Frontend Transport; Mon, 28 Jan 2019 18:07:24 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Mon, 28 Jan 2019 10:05:14 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x0SI5DN4009943; Mon, 28 Jan 2019 10:05:13 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x0SI5Dei009942; Mon, 28 Jan 2019 10:05:13 -0800 From: Manish Chopra To: CC: , , Subject: [PATCH net 1/5] qed: Fix bug in tx promiscuous mode settings Date: Mon, 28 Jan 2019 10:05:04 -0800 Message-ID: <20190128180508.9902-2-manishc@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190128180508.9902-1-manishc@marvell.com> References: <20190128180508.9902-1-manishc@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131931724453098630; (abac79dc-c90b-41ba-8033-08d666125e47); (abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(396003)(136003)(346002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(199004)(189003)(50466002)(316002)(48376002)(2906002)(68736007)(11346002)(126002)(2616005)(476003)(486006)(16586007)(446003)(8676002)(81166006)(50226002)(336012)(81156014)(26005)(85426001)(47776003)(42186006)(8936002)(14444005)(54906003)(6666004)(86362001)(26826003)(105606002)(87636003)(69596002)(51416003)(97736004)(4326008)(6862004)(356004)(2351001)(107886003)(36756003)(80596001)(498600001)(1076003)(53936002)(305945005)(76176011)(106466001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB2907; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT021; 1:8bi9cCJ2i0FMqWRkb/3kiQWzIwI+xY0VSgcSV2NA6XpH+BlS1/lFtbpgON5HCWj9XoFnvfdFepAKyI0G2EHwRIu/7pIiv+UClKtqWesRGmug+xloEGwWxO77qHUapDW16k69/4Zjl7iBVgvIbp2wfXmHrXU1ahKXmzOz8IPpGMM= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73e94098-cfb9-4725-15b9-08d6854b750f X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(5600110)(711020)(4605077)(2017052603328); SRVR:DM5PR07MB2907; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2907; 3:ijmlRiFFiQAAMzI9LSiWizfNvd53dKrXeAOMyJtTM+InrraPpoyIfJBJuqdPmtmUC19s4kyukvdA1W90bloyD8BmhTNh/pOx2KGkHtXV1ZxYkDRlnV9wPNzx10EqB7Ie6eJiG2g7fd8sjYIeBbku4XSskwwYeN7jBqtn9X3j0NbVSLg1MHyyYuArP7AUZgxVyLTQ5VmivhdIVDqAGughJI6qXXmI2TNnQgtLddY1EEaEc3IlH+3JYhBreB/Tt1zZ0h7BZrEz+5eDXVjB4zTKrVIkxh/46WBrRpljkIqbD7Hr/MgjB2DTPQ7KV6QhtnIZfhf75bOoxwaHWut6t9jTdXLqqqHHgFKTXp6l1bdyhDnJxWvr/T9g3UZxXd8a4HuF; 25:AMrLlO6cwRXjJtE9/jJm6bJm4tpn44A7FemVqa1zy3TC1sOGka/EPREAhyixEcS1DMInDwUJNpfo18g1cBpBsd7O3ry3Hs+wT4/sv4hocVYYGNgupnZxgxRSWNYH/Fncfq83lHICQBxZb2eetOuisF8Ivb9mQXV7J015pKyz1gI6l/tNWjeNLkiNCU54UksMgOcGWoqSh46TAVUZ7mF0UbU9tGIXC9FK9IJXhiHs7KRK9EMx/PxbRh9Eau2Bp5lSzmr9McNFAdoMRz/fiY2lVAPPD+00M2Of60vfPW9e/PTT2RJTy4FrSJsH7ir9oPN0aCwsjFb1QYpODyNvY9+JLA== X-MS-TrafficTypeDiagnostic: DM5PR07MB2907: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2907; 31:CNF4roGJMmD6arXJ5lIDlR+3zrLeMskX0jgcc5COxYCiOfl34KFDyjbcT6s2YMy2tm62HddOG1A1IQTnQnqBXb1gVLfOqsf2M6ChnfLCn7+FwQLLF/ZOUP/KwLnWFQ2dzS4j82ww6pFPeFW7XZx0g6fXKIadiDeELuH5REtY6gbrHgbZhOEhfDgVrpIDH1a043GU8awG7JiF9IICVwz7M7eoL72pLFvzggD0fR4AGQ4=; 4:WOelo+pGv9CJ0l2Nz0g7oZZ3JfBSpx1MrAIXMaK56zsvKkk8RBxfjiPUyp17xV8fC02l3UAwLhEv1HaSlT3DHFAOJ9NXgPH+4gBXkXjacFgC5Ek5nlFme1itKQqhqHl6YUpVuOsKmfcPBtooOkEOxsKn4kjUYHkGphyiiYSatKuiXaxTu2sfU65YwYBItUEqcWiDLRLsvRNby4Gm/ghob0Uzm6ujtk+rPzi40eU0r9UjvlrbpTQj6aCIs+8blEowdp9RKmrb/GydOjpd7J9KQ1FnTAl54AuL0EjJ2zsHaXDcgm91GLh7cPPena40NfVw X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0931CB1479 X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2907; 23:NmiD9CgTdomQGhrnooQPZnljnWnFCLlvCcECVrKAhtz/BBTc80/Ub2Sk5PpwDxesfdEOabnOQGKGUJGhTmkITuEw5D10ahSWnSviQUQ4udAwpULAO1+Dum1exbGB01JWUd854v8FY6+pvyL6PHgvmXbne8CKf5tN/w/QbabdLgc7JGV3XNVlHMUpqu0ZXkMZOzcVu9t0Im7XnrqSzLxge/lQh5ShiXd8C5TVuaH+dFvvGVxDZ/CEPBKS+Xv/MWV2eN7bIuH+PBJS3OMUkzaEojB70bmuHX9m1WHwVFobvu0kZt8h0gfvr/WFThDHZPY5IklomRydutCGvNJmcpTBmQET+T1wllsZmBDztPGBdOlPVl19iqTh8LOKNj6Blr91xaJ5VjwuKMY/3hsp7hYrgxlxN5zPwqMydlBha3r3pz4/UEbVO1NLfEddkoSZJqrWNu01In7U2OIlursbzDEW8hCOKs+Lop3QbxMMgITV97Qcw3H38/ULns0vtIRI+sqUH0EtmPvyaTPgbAutpeIvmV5VX/Wg06ToAsRJ24524ynS9snHZtwUsL11m5GsGBnC8F/K30ZMuQZjZzt6kPJ3Fh8qilWF2kEVUoxwkJj7RMsmikboRSIhpWesououy2WJc2yPSc6bmGIsHfgPri2+Eouu8MYRoCVttmOV6Cn+OOcegmMDmNMh+E7HMLiiUxL5kfCfp+kdCTDw/TZNxWDyg96X9yfZBX0lptL0wSUPTklxOxtNvNjPK4lCyLBhg/nkZlMp3pWoV7K1pktCTYODrbAYoqBN/2iKE9lKevCpJm6kD3MMUHBe+xipUEmRYmBzZuRJvZrbYLCQ81hIZEzil+WGTiVL4rx0ug22oHytKIPxlH+ih78CPEiCFoWfuCTAbj7uSycnzSMXbkJz6aNCHaqetdfKDc4NYoUv/zddgfMlXboiBk8Tq1uc9ymyOteMkyo2vL/3bCiJ9jmP+5sMu1ZpuWcA7rJvmetxz6goglw3eoP3kiKBsvpJl6P2+2RiUXgFJfETRD8DXjlefnxQRKdPwYBHPn/3yCKEP80vs012qufVC6G578pLUnta6g9Old796EgYBAsUi+kJojKyrx2dJ2LsnnhIKdPZjMBojxMpDwASizWqkRfRSOW5/ZHvCtOHcgktCuKzEaxBvgYdbEDh8tJ85sGHoj9FdXIgFY326LLM0IFPwDSCUBzXnNTN+LOOU67GghaXIWrntcZDsew+JS1nlgTrLrD1W7VbI5Q= X-Microsoft-Antispam-Message-Info: GVLLTCqNu5OPCLueZkuuHKkYmRyS8ZF3Hcr8xfz8Fi8MYmakpSA94LYZKgTwTdkdpCvheOzHw6Ge7tkfhY/BvQsY1KAznU7avkIQeTCP0jBgUCvdLscixaRFozyDonAiU1U3/sH3BCRDI0q4UQY0sXibg3PUu4adF4pTvR0bs5dUqwLJWhYsZDro+gMbcxFpQVYpbTsR7uSbJQdAPgnkagoZPYBadBni3YlvT9aV9z08B0kNrhzFyfVQP/qpP5jSCn3d46BR88rRtxf1keZVwAkke/uDJ614hsRz7PYtAuh2epi1UsMMSq8JaML1cRl2Ipf0fiPrjrOUY/6GqBxbpF595+YeF5Je4RZtbZMkHorhpsB0zGKojwXbozslzEgZPsUcJLhnJ2n3WZLr+LhlPjDSUj3QigrFBgs5R2wwIm8= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2907; 6:0ne8ShUpVwwVRKD/sh8rkdsJwmxMcsB9oF1cq64LrAoq0+3xakOr3iL6oLAaLq4IEmRJT9FneU4FkyGZjPCxUfirNnmWwxvLuNENGyOYncqVzLXWh1NUT05536ZtAAcEZGNMMvPXF7bku7F3UwNliLLWYSe0YukDcw9qFk9R6WXCbi73Dgx8lWLiAtx+XzUTslGey2iKd+g7T48w5+8n3QuHp8WuI/W7gCu0lHMEMWvBso6G02wfPX+nuqi6MktQvxFYSlXYHoQ9fulx4aAbapL6W7vOgo8/J2CdGm/eXDqrkdjHrdWPIl5mfT8zQW0XM7luABtrK1nEzwPD9el6RhdlntNxf7H9VqU2n5aO79T7WZZS9MLZ7J4Pn8mXeveaZUc6DxMM0EGc8jxija5u6rofzJsOIVeA4NKIU89jcqNXNgSXI1sG9Ds7AIb435RSl97MpGVIhTdquTefl4riNw==; 5:UBN+amifu/mh1rettEc5CruY3ixpb2Lur9VNj7rEJc9BbMN7TXxroHQ2Uo4BLo0yXyo7irP4gtUpGPJzknsDsn4l5Ec4xIQWYILM8Y1PhpL17jCjtd7jqqq0FEHLH04CyLOsxuSN/CAjci74gQEWr9GR9jKtwr4ufVP4vLXHKOyda6xzWjbHN38710nzoanhVlkg7xIhhsR4+xeDH62uTg==; 7:Y+IIx0RQy1z68hYD+68aQW7/rIKcO8Gz4AkFypc7aVvs1mnuCa13oobfgo42DOTUP5aJENDN5me+SOLFQNucLxzgPfgKWHJCPe0VXM+VwVOCFLMNr+CPma6SdHeuQ5WRkS+gZv4ipKpaKg7ZmPhPoA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2019 18:07:24.7864 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73e94098-cfb9-4725-15b9-08d6854b750f X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[199.233.58.38]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB2907 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When running tx switched traffic between VNICs created via a bridge(to which VFs are added), adapter drops the unicast packets in tx flow due to VNIC's ucast mac being unknown to it. But VF interfaces being in promiscuous mode should have caused adapter to accept all the unknown ucast packets. Later, it was found that driver doesn't really configure tx promiscuous mode settings to accept all unknown unicast macs. This patch fixes tx promiscuous mode settings to accept all unknown/unmatched unicast macs and works out the scenario. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c b/drivers/net/ethernet/qlogic/qed/qed_l2.c index 67c02ea93..b8baa6fc 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_l2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c @@ -609,6 +609,10 @@ static int qed_sp_vport_start(struct qed_hwfn *p_hwfn, (!!(accept_filter & QED_ACCEPT_MCAST_MATCHED) && !!(accept_filter & QED_ACCEPT_MCAST_UNMATCHED))); + SET_FIELD(state, ETH_VPORT_TX_MODE_UCAST_ACCEPT_ALL, + (!!(accept_filter & QED_ACCEPT_UCAST_MATCHED) && + !!(accept_filter & QED_ACCEPT_UCAST_UNMATCHED))); + SET_FIELD(state, ETH_VPORT_TX_MODE_BCAST_ACCEPT_ALL, !!(accept_filter & QED_ACCEPT_BCAST)); @@ -2688,7 +2692,8 @@ static int qed_configure_filter_rx_mode(struct qed_dev *cdev, if (type == QED_FILTER_RX_MODE_TYPE_PROMISC) { accept_flags.rx_accept_filter |= QED_ACCEPT_UCAST_UNMATCHED | QED_ACCEPT_MCAST_UNMATCHED; - accept_flags.tx_accept_filter |= QED_ACCEPT_MCAST_UNMATCHED; + accept_flags.tx_accept_filter |= QED_ACCEPT_UCAST_UNMATCHED | + QED_ACCEPT_MCAST_UNMATCHED; } else if (type == QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC) { accept_flags.rx_accept_filter |= QED_ACCEPT_MCAST_UNMATCHED; accept_flags.tx_accept_filter |= QED_ACCEPT_MCAST_UNMATCHED;