From patchwork Mon Jan 28 16:13:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Whitten X-Patchwork-Id: 1032045 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YveQTyQR"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43pGDh0G0Tz9sCh for ; Tue, 29 Jan 2019 04:03:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387525AbfA1QN5 (ORCPT ); Mon, 28 Jan 2019 11:13:57 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:56076 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387518AbfA1QNy (ORCPT ); Mon, 28 Jan 2019 11:13:54 -0500 Received: by mail-wm1-f68.google.com with SMTP id y139so14488751wmc.5; Mon, 28 Jan 2019 08:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=YBHXHHgSpmktvhhZLNppFJSU9VEAE5bW3T4VPQodZvQ=; b=YveQTyQRrB6K1EdAFcTo7hcmsTKE+mNtyQySaqqf0tJ9GkYtFOOTANvAIjTIqevZHK Aw1SgHL/2xB/67/8VzlaxFq4DSbeFr2BbDENuqXCsXttwbP7HxvSZKj97FL5gcWPi7jX NGj48ZNdNK9NoCx1Hx6MSiF0VKdWk1YZvZp+oDQxn6Op4/lkwDAtyyyvQgkU3ggfhLBS Py1hzhyC/+dcXHB6TvdPcu0QTvu2JX3c3+7+DpivoNyuIs91ToOu4YoerBXiKuxx3Jdn MBsw/gY8SaIikUSssyt0d5ciTrZ9iXQ+qAQxaaHaXu1TEMyXnfkjJPepA4ggenoY7nA0 TBTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=YBHXHHgSpmktvhhZLNppFJSU9VEAE5bW3T4VPQodZvQ=; b=H4+V5Oy9Sh5wYjMKhCBHVzVhGmMDm0V6POVnPdmi8UzdUZkT+Po3qr/HdzHAotMsxr OnjJy74fXc/dbtiRJrVvK8s4EphN0OUMNjNGdjxKJrskn3xhF6H+HV2iYJzxXuVfLuY3 cEj8CGcIpk5fpE0PJIQnReDd/xyCQ3cRdufl7vlRD38BxSBGNTSlWhyqMK9Gt0wJV6tH bYSZo3qAFWoM15nQDwSNA2YUi8F8z5i7zemdKSGsnThgBo4c6ic87zsUj5e/+c+UShK7 r9M5BNJz6MG5x9JaSyEBIu0jsGGxn0qYDL7RGLQl0oF4MCGhUZec3HPRTDxjGJx1AthQ loFA== X-Gm-Message-State: AJcUuke/ldM5bNJDmItWbtJ5nWBIRDXCxLkBUkd+CaDKGPM23u4E1woo kx088YQLsWEE37a9tPQsImdt+4y17M5BnA== X-Google-Smtp-Source: ALg8bN4B+p+JRWrLKToi2goBVgWc2IS6Ox7QMF9Exp5CTbDTbpaLFCxPSlz9n7rCDQe3yANiaodgpg== X-Received: by 2002:a1c:2d4b:: with SMTP id t72mr16497235wmt.99.1548692032494; Mon, 28 Jan 2019 08:13:52 -0800 (PST) Received: from Sarah.corp.lairdtech.com ([109.174.151.67]) by smtp.gmail.com with ESMTPSA id l20sm246445944wrb.93.2019.01.28.08.13.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 08:13:51 -0800 (PST) From: Ben Whitten X-Google-Original-From: Ben Whitten To: afaerber@suse.de Cc: linux-lpwan@lists.infradead.org, Ben Whitten , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH lora-next 06/11] net: lora: sx130x: add detail to TODO in setup Date: Mon, 28 Jan 2019 16:13:00 +0000 Message-Id: <20190128161306.27805-7-ben.whitten@lairdtech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190128161306.27805-1-ben.whitten@lairdtech.com> References: <20190128161306.27805-1-ben.whitten@lairdtech.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ben Whitten Setup requires a more steps to be complete, call these out specifically so they are not missed. Signed-off-by: Ben Whitten --- drivers/net/lora/sx130x.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora/sx130x.c index 18acfc8e934d..88932fbbb598 100644 --- a/drivers/net/lora/sx130x.c +++ b/drivers/net/lora/sx130x.c @@ -688,7 +688,17 @@ static int sx130x_loradev_open(struct net_device *netdev) if (ret) goto err_calibrate; - /* TODO */ + /* TODO Load constant adjustments, patches */ + + /* TODO Frequency time drift */ + + /* TODO Configure lora multi demods, bitfield of active */ + + /* TODO Load concentrator multi channel frequencies */ + + /* TODO enable the correlator on enabled frequencies */ + + /* TODO PPM, and modem enable */ ret = sx130x_load_all_firmware(priv); if (ret)