From patchwork Thu Jan 24 21:47:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maciej Fijalkowski X-Patchwork-Id: 1030697 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VvMF55TB"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43lwkT3gJmz9s7T for ; Fri, 25 Jan 2019 08:48:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728131AbfAXVsA (ORCPT ); Thu, 24 Jan 2019 16:48:00 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:43997 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbfAXVr7 (ORCPT ); Thu, 24 Jan 2019 16:47:59 -0500 Received: by mail-lj1-f194.google.com with SMTP id q2-v6so6608764lji.10 for ; Thu, 24 Jan 2019 13:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tOSXZu5yZxn2uEqSYtv9bSchsaXMOBUmMRnB0hfrgZ4=; b=VvMF55TB2gXH22EXSWnYnAhsV537NMHsaaJUhBMzpQk8AwpRuioHxFMJR187sdFTt2 GoZ70IUgVBtysnfnPn2w4V0zee5f6J53RxcXqVdl15dKSKE6xjrE4lVYIWU5rY2y2bod dY7PLZXMNGDKw6W64qbjqH2xMgmQpybN8s8aEK+GVPVhWNMmLL9M9tJvxliGrZttRWYz rphIK60cjZ7dbN3pItp/zXlUKGddQwdiljqbKClgFIGwwHp0bPcX/YkdkqTOktzlPh5c x+JCxgm+2aRLWkDJgFD5MHa3zkRvu1HSjhjuLX7PIGIeCzY7AZUuEtHWIbee4xv43ryN yYxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tOSXZu5yZxn2uEqSYtv9bSchsaXMOBUmMRnB0hfrgZ4=; b=TYtaVTO5m5jWwtptNF7o8fHd6iULcBOFQu7MH58FXG3t8mF2zVZpEX/VNaBxsUHQd5 5hBqZwPlNwOR6/F39C0bxgAMcLnaEckcMpEFCxMgwpl+BHgUSg509RsI/h/Nl9Oe0u+s YKw90afo/+cdAjoiZqCrzKeXVYYf8n46sCnmsZLq+ukarefdDYcre+vJh5x/Lrlo8gwN UduGL4Of5728KizDAio325CVs/oBw2r40bXI6C0KhuwuCMlwInKDZaAV5Da3VibMoPYL yzjxtNX/BxozHbep4cLElyJQW7cfwhmL6oFKNNe7t++eIRX+H3VktoO5Ueg/ZiLkuZGF xiEg== X-Gm-Message-State: AJcUukf5Jcx7TZ6aFH00CT+x/Btpcvk1PzP+t59xJ6vQDuAM3RFfFaKP i8Dh3NMcw4GaA1xhvBWXLJJiKsha X-Google-Smtp-Source: ALg8bN70fyMEJoxsGBlost52ylICUwsq8ZFbyr/6pPX3KcNU9nfWD1tY45XAQ7tpBLDvxPu0McZo1Q== X-Received: by 2002:a2e:8858:: with SMTP id z24-v6mr6584905ljj.197.1548366476801; Thu, 24 Jan 2019 13:47:56 -0800 (PST) Received: from localhost.localdomain (host-185-93-94-63.ip-point.pl. [185.93.94.63]) by smtp.gmail.com with ESMTPSA id w4sm1136285lfk.83.2019.01.24.13.47.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 Jan 2019 13:47:56 -0800 (PST) From: Maciej Fijalkowski To: daniel@iogearbox.net, ast@kernel.org Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com Subject: [PATCH bpf-next v3 2/7] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe Date: Thu, 24 Jan 2019 22:47:42 +0100 Message-Id: <20190124214747.6986-3-maciejromanfijalkowski@gmail.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20190124214747.6986-1-maciejromanfijalkowski@gmail.com> References: <20190124214747.6986-1-maciejromanfijalkowski@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jesper Dangaard Brouer The sample xdp_redirect_cpu is not using helper bpf_trace_printk. Thus it makes no sense that the --debug option us reading from /sys/kernel/debug/tracing/trace_pipe via read_trace_pipe. Simply remove it. Signed-off-by: Jesper Dangaard Brouer --- samples/bpf/xdp_redirect_cpu_user.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/samples/bpf/xdp_redirect_cpu_user.c b/samples/bpf/xdp_redirect_cpu_user.c index 2d23054aaccf..f141e752ca0a 100644 --- a/samples/bpf/xdp_redirect_cpu_user.c +++ b/samples/bpf/xdp_redirect_cpu_user.c @@ -51,7 +51,6 @@ static const struct option long_options[] = { {"help", no_argument, NULL, 'h' }, {"dev", required_argument, NULL, 'd' }, {"skb-mode", no_argument, NULL, 'S' }, - {"debug", no_argument, NULL, 'D' }, {"sec", required_argument, NULL, 's' }, {"prognum", required_argument, NULL, 'p' }, {"qsize", required_argument, NULL, 'q' }, @@ -563,7 +562,6 @@ int main(int argc, char **argv) bool use_separators = true; bool stress_mode = false; char filename[256]; - bool debug = false; int added_cpus = 0; int longindex = 0; int interval = 2; @@ -624,9 +622,6 @@ int main(int argc, char **argv) case 'S': xdp_flags |= XDP_FLAGS_SKB_MODE; break; - case 'D': - debug = true; - break; case 'x': stress_mode = true; break; @@ -688,11 +683,6 @@ int main(int argc, char **argv) return EXIT_FAIL_XDP; } - if (debug) { - printf("Debug-mode reading trace pipe (fix #define DEBUG)\n"); - read_trace_pipe(); - } - stats_poll(interval, use_separators, prog_num, stress_mode); return EXIT_OK; }