From patchwork Fri Jan 18 15:58:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 1027518 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="MJnUClCY"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43h5FV3wm0z9sBQ for ; Sat, 19 Jan 2019 02:58:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727976AbfARP6F (ORCPT ); Fri, 18 Jan 2019 10:58:05 -0500 Received: from mail-eopbgr150073.outbound.protection.outlook.com ([40.107.15.73]:21666 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727491AbfARP6F (ORCPT ); Fri, 18 Jan 2019 10:58:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PlpRXaOWEXwcAymcf+Y5YrE93is1Hpea2xnnnNyhB2E=; b=MJnUClCYu7SeNBzz1CkgHr84/OxFadZAMlBrR/FnfFfDYqZUacWnmgV7hpHmpZZaLI3dd0JVHmQ9b5+HsmoC079Oybv12Au6EIXKmLEYoCanEY53INZjM+6DM5AdTEaYEegeiEyebmnhH2iLzUVmms2SRaFBvBADhG6/HRJDEW4= Received: from AM6PR05MB6056.eurprd05.prod.outlook.com (20.179.2.148) by AM6PR05MB5702.eurprd05.prod.outlook.com (20.178.86.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.26; Fri, 18 Jan 2019 15:58:00 +0000 Received: from AM6PR05MB6056.eurprd05.prod.outlook.com ([fe80::5490:e4ea:7798:e65f]) by AM6PR05MB6056.eurprd05.prod.outlook.com ([fe80::5490:e4ea:7798:e65f%3]) with mapi id 15.20.1516.019; Fri, 18 Jan 2019 15:58:00 +0000 From: Ido Schimmel To: "netdev@vger.kernel.org" CC: "davem@davemloft.net" , Jiri Pirko , mlxsw , Alexander Petrovskiy , Ido Schimmel , Roopa Prabhu , Nikolay Aleksandrov , "bridge@lists.linux-foundation.org" Subject: [PATCH net 5/8] net: bridge: Mark FDB entries that were added by user as such Thread-Topic: [PATCH net 5/8] net: bridge: Mark FDB entries that were added by user as such Thread-Index: AQHUr0aW1eVYfe4MDUaX4H0i7YnAfg== Date: Fri, 18 Jan 2019 15:58:00 +0000 Message-ID: <20190118155719.14827-6-idosch@mellanox.com> References: <20190118155719.14827-1-idosch@mellanox.com> In-Reply-To: <20190118155719.14827-1-idosch@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P193CA0032.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:3e::45) To AM6PR05MB6056.eurprd05.prod.outlook.com (2603:10a6:20b:ab::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [79.183.38.137] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB5702; 6:PCqaZpSQqWfqYFx7kpzd/6aIso31NOiHox+SNaMW/f6YPZIl5QCJjEjDgrPGQCeLCyGrWE/1NRCQmIDcZJPsqZNHGpVa6jvFxryHOfUNXHzxVzm1oQMQTgYZ9ajypcnlS/CVr1V3fGK7xs304zpzx6RIjUYaC/4OgxhRe7Zp2GPw/BKR1iIQ46ON82yoj8UBy9XWQVOQa/n4uyx2Nrt71Ocb9HGylZvNHC86ttRNojNkmoHI/74H8EEUmiKE8nFfQtChdmdhRsBgwcjh12l0DH/3+oyADJ5fdceHGZO9QjBYtpCmc1cUGUx8zyRZzdIj6Vg0FWcUbhISnEPQfSg1pZKaaW1k8hA96FSj4KwtlkC5y/7Ryo+JT4RIy8ezG9ourfDjBP63nXLS1JUAJeBLw4K0zVDOJjaF/AblZ8aNQwZehA4EhxlkEkwz6kd4wQbp5+0tCbbLKLbApevaaZacdQ==; 5:RuYLWyKXmlzH16xs2XZvUESyIJy9/ZH6xVBHf7JQPmNTEEONU+x4HN+lOUhSeXekfYRKMx+g0t2e2R3yY7aBYFE+1aADd48da4Yrx36ku4JsSkqM+X8t63TKSJG8py1eMhbJWu0zv2x5S3EOImAYfFSZcrt8AYHChJ7NtMgCQm0JmU8lvfjxWM9c3wE5HjIjwlTvuByLBK8HfMZpnJBvbg==; 7:JkfsTtlww/TAnZuPl0dfQbfuJTfngrVnq/8nIxyLPRxRb6Bk0FPq+OOk8WLJ7qZ7bbJ7M/WYifWX5/GEvDoCkSl7UeGui306sA8K1xL6YMvOobSZiBJwrIcDdnPAWrjz5aBH2J2K8YiYO17fByT8Yg== x-ms-office365-filtering-correlation-id: ffe88e87-fe49-42b6-56b0-08d67d5db872 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB5702; x-ms-traffictypediagnostic: AM6PR05MB5702: x-microsoft-antispam-prvs: x-forefront-prvs: 0921D55E4F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(39860400002)(376002)(346002)(396003)(199004)(189003)(5640700003)(86362001)(6116002)(99286004)(316002)(2351001)(1076003)(2501003)(71200400001)(54906003)(52116002)(256004)(71190400001)(3846002)(6436002)(6486002)(26005)(102836004)(36756003)(186003)(6916009)(5660300001)(14454004)(2906002)(106356001)(7736002)(8936002)(486006)(478600001)(6506007)(2616005)(1730700003)(105586002)(476003)(305945005)(76176011)(8676002)(53936002)(446003)(11346002)(6512007)(50226002)(25786009)(97736004)(81156014)(68736007)(81166006)(4326008)(386003)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB5702; H:AM6PR05MB6056.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YHikKIa9EQknCupfkXeIIrZzOHhro6pSgU0gJ9mjc9KqeynG12zvNSQ62RPxTUnAP9cFxV/Gi8FwAlwbxkVg5JseUxM0rh4Mmr6tBuwNvFxPnKMT/L8OaxRmnqu8rJaTRLMhcIURqzqQyu9M1it9w1ZTcQp/N9C/fCGOZsH3jkvFAA11oxTp427rIhnm9sM2PCX2x9Zk4P3JHx6K8VOV5zdIS12jF/ws0WPigIDAEd0nLz2O6rg5fhLtM49VxnyIfLecPhtR6xbBeaausFDkiJ3cVH0b1QbIVpb9Pl7q/HI4FlCquezZ+X37/ixKpW/Pw2CwdZFuoQe8dyCtbF4b3mfoOSRrcbrylt9E4C076SQOQZnhWR6v5P0AlxDS1kDoEw6WvVt10GW4VrBx0lMXgIXewhQh+VJGwW7Ri0yA8Q8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffe88e87-fe49-42b6-56b0-08d67d5db872 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2019 15:57:59.1369 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5702 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Externally learned entries can be added by a user or by a switch driver that is notifying the bridge driver about entries that were learned in hardware. In the first case, the entries are not marked with the 'added_by_user' flag, which causes switch drivers to ignore them and not offload them. The 'added_by_user' flag can be set on externally learned FDB entries based on the 'swdev_notify' parameter in br_fdb_external_learn_add(), which effectively means if the created / updated FDB entry was added by a user or not. Fixes: 816a3bed9549 ("switchdev: Add fdb.added_by_user to switchdev notifications") Signed-off-by: Ido Schimmel Reported-by: Alexander Petrovskiy Reviewed-by: Petr Machata Cc: Roopa Prabhu Cc: Nikolay Aleksandrov Cc: bridge@lists.linux-foundation.org --- net/bridge/br_fdb.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index fe3c758791ca..9e14767500ea 100644 --- a/net/bridge/br_fdb.c +++ b/net/bridge/br_fdb.c @@ -1128,6 +1128,8 @@ int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p, err = -ENOMEM; goto err_unlock; } + if (swdev_notify) + fdb->added_by_user = 1; fdb->added_by_external_learn = 1; fdb_notify(br, fdb, RTM_NEWNEIGH, swdev_notify); } else { @@ -1147,6 +1149,9 @@ int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p, modified = true; } + if (swdev_notify) + fdb->added_by_user = 1; + if (modified) fdb_notify(br, fdb, RTM_NEWNEIGH, swdev_notify); }