From patchwork Wed Jan 16 20:00:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 1026169 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QKvYILRY"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43fynj0hVJz9sCh for ; Thu, 17 Jan 2019 07:03:37 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732204AbfAPUDf (ORCPT ); Wed, 16 Jan 2019 15:03:35 -0500 Received: from mail-yw1-f68.google.com ([209.85.161.68]:42383 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732185AbfAPUDe (ORCPT ); Wed, 16 Jan 2019 15:03:34 -0500 Received: by mail-yw1-f68.google.com with SMTP id x2so2908491ywc.9 for ; Wed, 16 Jan 2019 12:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TJyRoY35BZ44Wn/vP37Pz+tEPeYCUHy1JVXuNzq45LQ=; b=QKvYILRYzLD5+uqodygtfDklH/QgPCfkAm7eHlsEHmjGHAox3SAPBmq+T1di6707Q4 y7zCcCVP9HoONWCi706i60x/1Iq2BS+YivaAD1FnnVOurbib53518yRrzc4CSw8qXZlI Q1y8YWFjrzaB4e9WcaxujqsfeTMqq1PZRlRc1EOCFISGHK/LRISqw8JadlOfDSr69nkE 3ogOdUp3NISYC0kJSmDnZhMN6PtS+ipqNELwoB5sMIaJ23OMu3keCVKVTdHA2x0AxVB/ 2P+HgHObEgEYOiiV4OaGikq9PVrDk3ki1qm+oK/QUgi5p9Bcfsqrtrw3HVUqbS1rPElI YkPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TJyRoY35BZ44Wn/vP37Pz+tEPeYCUHy1JVXuNzq45LQ=; b=m5k19sVcZGRp1YHLIh10mn7ROE7woeJOktknpxCJUJkhKxPAilnnujKAtIS5H5BhHo jo6CXbgrQaQOh1Sb1tNFgzzTrnerdSHNqtCzmrQqPRmoR/vFBi4QHHEUO395zPvtgvgU HQjTEcTJrJVc36wit8J4aBV1SNCuqK77/iyJF1Gwp+gvBAMN+8WwWlq4fU71FT/s4102 NxUi5vYhmawCDSe0DZplHVwYTQs+WyUJrbcsFMhFZsEh3sk1OIAeszar5brCG8VZ2Rpg s7pLD+yXw3pt37XbJmO4zIpRDHeLe6ZO/RAAnqpnf6ngDq96APl1RW4I37Nev7mQou34 Jvkw== X-Gm-Message-State: AJcUukcozdPrkPRXajk8Kp5SgtVpSG9xtrySaVKZPDjiTWaOKTsbGliY uB73sXlR3YHtpIz7HT/n7TEO7T0G X-Google-Smtp-Source: ALg8bN4xWRYd7pqiqqp8IZdkHcp4eL/otFxB2S04TRLIS7NXthxc7hrFy4ZijpOlQZFLbfZkRxf2hg== X-Received: by 2002:a81:ac56:: with SMTP id z22mr9637343ywj.40.1547669012709; Wed, 16 Jan 2019 12:03:32 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id v128sm2475295ywf.44.2019.01.16.12.03.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 12:03:31 -0800 (PST) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , andrew@lunn.ch, vivien.didelot@gmail.com, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: [PATCH net-next 07/14] net: dsa: Add ability to program multicast filter for CPU port Date: Wed, 16 Jan 2019 12:00:55 -0800 Message-Id: <20190116200102.2749-8-f.fainelli@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190116200102.2749-1-f.fainelli@gmail.com> References: <20190116200102.2749-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When the switch ports operate as individual network devices, the switch driver might have configured the switch to flood multicast all the way to the CPU port. This is really undesireable as it can lead to receiving a lot of unwanted traffic that the network stack needs to filter in software. For each valid multicast address, program it into the switch's MDB only when the host is interested in receiving such traffic, e.g: running an multicast application. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index a3fcc1d01615..33f6b88b6fd6 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -68,6 +68,39 @@ static int dsa_slave_get_iflink(const struct net_device *dev) return dsa_slave_to_master(dev)->ifindex; } +static int dsa_slave_sync_unsync_mdb_addr(struct net_device *dev, + const unsigned char *addr, bool add) +{ + struct switchdev_obj_port_mdb mdb = { + .obj = { + .id = SWITCHDEV_OBJ_ID_HOST_MDB, + .flags = SWITCHDEV_F_DEFER, + }, + .vid = 0, + }; + int ret = -EOPNOTSUPP; + + ether_addr_copy(mdb.addr, addr); + if (add) + ret = switchdev_port_obj_add(dev, &mdb.obj, NULL); + else + ret = switchdev_port_obj_del(dev, &mdb.obj); + + return ret; +} + +static int dsa_slave_sync_mdb_addr(struct net_device *dev, + const unsigned char *addr) +{ + return dsa_slave_sync_unsync_mdb_addr(dev, addr, true); +} + +static int dsa_slave_unsync_mdb_addr(struct net_device *dev, + const unsigned char *addr) +{ + return dsa_slave_sync_unsync_mdb_addr(dev, addr, false); +} + static int dsa_slave_open(struct net_device *dev) { struct net_device *master = dsa_slave_to_master(dev); @@ -126,6 +159,8 @@ static int dsa_slave_close(struct net_device *dev) dev_mc_unsync(master, dev); dev_uc_unsync(master, dev); + __hw_addr_unsync_dev(&dev->mc, dev, dsa_slave_unsync_mdb_addr); + if (dev->flags & IFF_ALLMULTI) dev_set_allmulti(master, -1); if (dev->flags & IFF_PROMISC) @@ -150,7 +185,17 @@ static void dsa_slave_change_rx_flags(struct net_device *dev, int change) static void dsa_slave_set_rx_mode(struct net_device *dev) { struct net_device *master = dsa_slave_to_master(dev); + struct dsa_port *dp = dsa_slave_to_port(dev); + /* If the port is bridged, the bridge takes care of sending + * SWITCHDEV_OBJ_ID_HOST_MDB to program the host's MC filter + */ + if (netdev_mc_empty(dev) || dp->bridge_dev) + goto out; + + __hw_addr_sync_dev(&dev->mc, dev, dsa_slave_sync_mdb_addr, + dsa_slave_unsync_mdb_addr); +out: dev_mc_sync(master, dev); dev_uc_sync(master, dev); } @@ -1395,6 +1440,11 @@ static int dsa_slave_changeupper(struct net_device *dev, if (netif_is_bridge_master(info->upper_dev)) { if (info->linking) { + /* Remove existing MC addresses that might have been + * programmed + */ + __hw_addr_unsync_dev(&dev->mc, dev, + dsa_slave_unsync_mdb_addr); err = dsa_port_bridge_join(dp, info->upper_dev); err = notifier_from_errno(err); } else {