From patchwork Wed Jan 16 14:24:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jian-Hong Pan X-Patchwork-Id: 1025967 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=g.ncu.edu.tw Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=g.ncu.edu.tw header.i=@g.ncu.edu.tw header.b="aNhVun+G"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43fqHh32tPz9sBQ for ; Thu, 17 Jan 2019 01:25:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393115AbfAPOZe (ORCPT ); Wed, 16 Jan 2019 09:25:34 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:44796 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390967AbfAPOZe (ORCPT ); Wed, 16 Jan 2019 09:25:34 -0500 Received: by mail-pf1-f196.google.com with SMTP id u6so3131286pfh.11 for ; Wed, 16 Jan 2019 06:25:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=g.ncu.edu.tw; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b+2IAnExCO9vokV2p16FJgeCx9M1JeLkxUVCmUw2Veg=; b=aNhVun+GvGu/C4cchsQwKDtrElSmzsfw5WZ+yZQN5x4sKMzLo0WwzDeQcSYkpJwipM TvNXdA5J4nLYzn42XCXlCQPz4qE+tYJ0PuCETstvg3whY1wkVlaH10IESnNzz99Evn/d M+fuIub6/JWfUwojYH+vLBIypXJtnuKOsHK7Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b+2IAnExCO9vokV2p16FJgeCx9M1JeLkxUVCmUw2Veg=; b=b00IM8rrmtktEsvGi87cxzg9KkU1WjMSv2EoIjlcRHjY+3ylDFYckcBV7MiKXNULns ZaFcakFKT4TcjWuxqGvqWr3zObDb5t27qRKclssAtYav12pWcAsJJqSppb3TSIdkn6rO mri4iifMuJ4ndSvjrpE9xNUcae8aOeTERTklbZU4Ra6OEiIVMP9M20OFK26omoFMLszO akc2kLbmUrBRcU8D8wGoobniGqTfJORyK4HeeiHm5XTEtlD961rEzk7+0vdpswNr9ylc wsJ0Xgoen3uujnIrWcKvnl9ZI8wTMPmDAnQLBSSor2CU56G5MYmZOpOw/x2qZpS7iqbf FyOw== X-Gm-Message-State: AJcUukeOx+NQeID52HsACFtCfoNu1CVOzPtzEkk1f4CRHYgHOIbLqceI 9cq1iyUJOLbF9EjVlSR+lIGVRA== X-Google-Smtp-Source: ALg8bN5i780L0PkW8ABkomT860ra9KrnM3Wsk5woRqpcv+l1z092ltGQZb+HhhPTFyHp2FlIaf9i6A== X-Received: by 2002:a63:c748:: with SMTP id v8mr9277797pgg.108.1547648733633; Wed, 16 Jan 2019 06:25:33 -0800 (PST) Received: from starnight.local ([150.116.255.181]) by smtp.gmail.com with ESMTPSA id a17sm9211783pgm.26.2019.01.16.06.25.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 06:25:33 -0800 (PST) From: Jian-Hong Pan To: =?utf-8?q?Andreas_F=C3=A4rber?= Cc: Ben Whitten , linux-lpwan@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jian-Hong Pan Subject: [RFC PATCH 2/5] net: lorawan: Remove unused lrw_dev_hard_header function Date: Wed, 16 Jan 2019 22:24:56 +0800 Message-Id: <20190116142458.19542-2-starnight@g.ncu.edu.tw> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190116142048.19446-1-starnight@g.ncu.edu.tw> References: <20190116142048.19446-1-starnight@g.ncu.edu.tw> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The lorawan module is an abastraction layer over the LoRaWAN soft and hard MAC. It passes the original buffer to the real MAC layer. So, this patch removes the lrw_dev_hard_header function. Signed-off-by: Jian-Hong Pan --- net/lorawan/socket.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/net/lorawan/socket.c b/net/lorawan/socket.c index 0ec2d2bf1682..9c0722379e25 100644 --- a/net/lorawan/socket.c +++ b/net/lorawan/socket.c @@ -115,14 +115,6 @@ dgram_bind(struct sock *sk, struct sockaddr *uaddr, int len) return ret; } -static int -lrw_dev_hard_header(struct sk_buff *skb, struct net_device *ndev, - const u32 src_devaddr, size_t len) -{ - /* TODO: Prepare the LoRaWAN sending header here */ - return 0; -} - static int dgram_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) { @@ -176,10 +168,6 @@ dgram_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) skb_reserve(skb, hlen); skb_reset_network_header(skb); - ret = lrw_dev_hard_header(skb, ndev, 0, size); - if (ret < 0) - goto dgram_sendmsg_no_skb; - ret = memcpy_from_msg(skb_put(skb, size), msg, size); if (ret > 0) goto dgram_sendmsg_err_skb;