From patchwork Wed Jan 16 10:23:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 1025748 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43fjwy47l3z9sCX for ; Wed, 16 Jan 2019 21:24:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389129AbfAPKX7 (ORCPT ); Wed, 16 Jan 2019 05:23:59 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:40722 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389494AbfAPKXq (ORCPT ); Wed, 16 Jan 2019 05:23:46 -0500 Received: by mail-lf1-f65.google.com with SMTP id v5so4437087lfe.7; Wed, 16 Jan 2019 02:23:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i9EBQmXkMNBYjjztGyv3wx7NdVyHDMd7kO+rKlttGLE=; b=kkLHzJ00TwNmFhbXq4OLPrfLbKq9G4P6M1rc3Q93jKQ4z1kXHpMR10Lv6yIHfk1SWk XNThPh22hneCiZ2l4W70Jw2rDVhvquMS5HYiycLfDsSixJ6RGxp460h88/ts5jkwogtv 3VrOrnozPGvjcPlebPVQMQEJDA7Jg3kSaDvwuO6M+91FVYDtzblnbnzA++67lzeAkU5/ 9zLY7h6VIG1qmlgPIxAT1SPCKHy1H4p5tQel06qqLQ2Rj33tioZz/hoya/Xvp/foNNjL 7uS5Tpq/HuO0PqhdKd6OSQoDen3fMQlJbswJcrKS7nfHWlwigy5e2ptvriQiwsHCBE31 UIaw== X-Gm-Message-State: AJcUuke/cDUqZtFrnAsz/1smtWLYwm0+nrub0qDWQsyBuKQsIy+3b4dR EM6pxnciCmDb7q62ct86UmE= X-Google-Smtp-Source: ALg8bN7yIMFMCBA2f5c/mOOOSy8yRqgip1DOVfs5fuddLh4zuAEBYYqsJRS/Gq//4z0DGx3SE5gOuA== X-Received: by 2002:a19:4f0c:: with SMTP id d12mr6095572lfb.121.1547634224443; Wed, 16 Jan 2019 02:23:44 -0800 (PST) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id 1-v6sm942115lju.61.2019.01.16.02.23.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 02:23:40 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1gjiMH-0007vq-T4; Wed, 16 Jan 2019 11:23:41 +0100 From: Johan Hovold To: Hauke Mehrtens Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/3] net: dsa: lantiq_gswip: drop bogus drvdata check Date: Wed, 16 Jan 2019 11:23:35 +0100 Message-Id: <20190116102335.30433-4-johan@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190116102335.30433-1-johan@kernel.org> References: <20190116102335.30433-1-johan@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform-device driver data is set on successful probe and will never be NULL on remove (or we have much bigger problems). Signed-off-by: Johan Hovold Reviewed-by: Andrew Lunn Acked-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c index 5792674dd4e4..27d092cab40e 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -1126,9 +1126,6 @@ static int gswip_remove(struct platform_device *pdev) struct gswip_priv *priv = platform_get_drvdata(pdev); int i; - if (!priv) - return 0; - /* disable the switch */ gswip_mdio_mask(priv, GSWIP_MDIO_GLOB_ENABLE, 0, GSWIP_MDIO_GLOB);