Message ID | 20190116102335.30433-4-johan@kernel.org |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | net: dsa: lantiq_gswip: probe fixes and remove cleanup | expand |
On Wed, Jan 16, 2019 at 11:23:35AM +0100, Johan Hovold wrote: > The platform-device driver data is set on successful probe and will > never be NULL on remove (or we have much bigger problems). > > Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 1/16/19 11:23 AM, Johan Hovold wrote: > The platform-device driver data is set on successful probe and will > never be NULL on remove (or we have much bigger problems). > > Signed-off-by: Johan Hovold <johan@kernel.org> Acked-by: Hauke Mehrtens <hauke@hauke-m.de> > --- > drivers/net/dsa/lantiq_gswip.c | 3 --- > 1 file changed, 3 deletions(-) >
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c index 5792674dd4e4..27d092cab40e 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -1126,9 +1126,6 @@ static int gswip_remove(struct platform_device *pdev) struct gswip_priv *priv = platform_get_drvdata(pdev); int i; - if (!priv) - return 0; - /* disable the switch */ gswip_mdio_mask(priv, GSWIP_MDIO_GLOB_ENABLE, 0, GSWIP_MDIO_GLOB);
The platform-device driver data is set on successful probe and will never be NULL on remove (or we have much bigger problems). Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/net/dsa/lantiq_gswip.c | 3 --- 1 file changed, 3 deletions(-)