From patchwork Tue Jan 15 19:41:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 1025399 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="K1x9JaF5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43fLNW1cfbz9s9G for ; Wed, 16 Jan 2019 06:43:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389484AbfAOTnF (ORCPT ); Tue, 15 Jan 2019 14:43:05 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:34712 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389438AbfAOTmo (ORCPT ); Tue, 15 Jan 2019 14:42:44 -0500 Received: by mail-pl1-f193.google.com with SMTP id w4so1777689plz.1 for ; Tue, 15 Jan 2019 11:42:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TJyRoY35BZ44Wn/vP37Pz+tEPeYCUHy1JVXuNzq45LQ=; b=K1x9JaF5021zlAFDpgNt9DSZyR4aZcn1ytBCyhZQn9xnBwliA/CRT7DXxBByinLvOt qKYsP50Ma+NnD9miIXggP4ZFocwbchqqSrJAlYEAy2iZTrLWt/72r0HVosN2/UNQNliD 18TEf9BmLExZC0EaHf+NU7Cx0c2jCbyrcQmtLg4Lr49ecg/dejPdt+Q+tK3sW+IUQMj7 zSsUsoHpvMT3FSvI1M7lJ8s3V9tcXO86Q/gvPpCyfGAIz4qBP2ZrEImhU7uSCYMQl3xh Tp/HT4v02C1Bft+LttJ8T5t0M3uYnpEvcMxSS1BF1XDmvW02Vl4joxUh2kR/EIS2O/gQ RhTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TJyRoY35BZ44Wn/vP37Pz+tEPeYCUHy1JVXuNzq45LQ=; b=bdruGHJRSdBAVFlEDBwqhWfV5zGXqi45lBBmvLOtcv3NeS2ZXN6ccSJsCKP8NHce4j tBl2hLTPpo4rIekRXEh2QFwTSU2ny/EtK+TvnKekYfPKcABy2URJeK7WAvQJHQenn4jO cck1MnAWqerc3PQyqjdxgco96/dYrNwctK+rLTm208dXuu+TSp9C+sYfAcTKrA8NDmM4 QJrbCY3z/pJ9gnVuOk5WNF19+L9KC7VNytuBCnw9A3RIywuWn45hf5lLCNEuHj3hEbip vKeaHSv/TImH2xNgKLdIMaon0MRhZAnuuKh8INZo8AANGNTAxlGmYp9sI52EZnvRhA/S fxKQ== X-Gm-Message-State: AJcUukf9Usl5ZVeLxIp/GmfVPodviSZtGsPkQ8dffceENfdc/JtIF2A+ AcohGUCmckeFDLEYWiifK2B7Pqus X-Google-Smtp-Source: ALg8bN68HHScXDSl3sNO3GzOc4W59uIsw0sDGprw6PEmImBijkjr3wN3shKWQ3WHhqa3ctoDtwrDSA== X-Received: by 2002:a17:902:2006:: with SMTP id n6mr5860292pla.66.1547581362965; Tue, 15 Jan 2019 11:42:42 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id 128sm6954262pfu.129.2019.01.15.11.42.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Jan 2019 11:42:42 -0800 (PST) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , andrew@lunn.ch, vivien.didelot@gmail.com, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: [RFC net-next 07/14] net: dsa: Add ability to program multicast filter for CPU port Date: Tue, 15 Jan 2019 11:41:23 -0800 Message-Id: <20190115194130.19896-8-f.fainelli@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190115194130.19896-1-f.fainelli@gmail.com> References: <20190115194130.19896-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When the switch ports operate as individual network devices, the switch driver might have configured the switch to flood multicast all the way to the CPU port. This is really undesireable as it can lead to receiving a lot of unwanted traffic that the network stack needs to filter in software. For each valid multicast address, program it into the switch's MDB only when the host is interested in receiving such traffic, e.g: running an multicast application. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index a3fcc1d01615..33f6b88b6fd6 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -68,6 +68,39 @@ static int dsa_slave_get_iflink(const struct net_device *dev) return dsa_slave_to_master(dev)->ifindex; } +static int dsa_slave_sync_unsync_mdb_addr(struct net_device *dev, + const unsigned char *addr, bool add) +{ + struct switchdev_obj_port_mdb mdb = { + .obj = { + .id = SWITCHDEV_OBJ_ID_HOST_MDB, + .flags = SWITCHDEV_F_DEFER, + }, + .vid = 0, + }; + int ret = -EOPNOTSUPP; + + ether_addr_copy(mdb.addr, addr); + if (add) + ret = switchdev_port_obj_add(dev, &mdb.obj, NULL); + else + ret = switchdev_port_obj_del(dev, &mdb.obj); + + return ret; +} + +static int dsa_slave_sync_mdb_addr(struct net_device *dev, + const unsigned char *addr) +{ + return dsa_slave_sync_unsync_mdb_addr(dev, addr, true); +} + +static int dsa_slave_unsync_mdb_addr(struct net_device *dev, + const unsigned char *addr) +{ + return dsa_slave_sync_unsync_mdb_addr(dev, addr, false); +} + static int dsa_slave_open(struct net_device *dev) { struct net_device *master = dsa_slave_to_master(dev); @@ -126,6 +159,8 @@ static int dsa_slave_close(struct net_device *dev) dev_mc_unsync(master, dev); dev_uc_unsync(master, dev); + __hw_addr_unsync_dev(&dev->mc, dev, dsa_slave_unsync_mdb_addr); + if (dev->flags & IFF_ALLMULTI) dev_set_allmulti(master, -1); if (dev->flags & IFF_PROMISC) @@ -150,7 +185,17 @@ static void dsa_slave_change_rx_flags(struct net_device *dev, int change) static void dsa_slave_set_rx_mode(struct net_device *dev) { struct net_device *master = dsa_slave_to_master(dev); + struct dsa_port *dp = dsa_slave_to_port(dev); + /* If the port is bridged, the bridge takes care of sending + * SWITCHDEV_OBJ_ID_HOST_MDB to program the host's MC filter + */ + if (netdev_mc_empty(dev) || dp->bridge_dev) + goto out; + + __hw_addr_sync_dev(&dev->mc, dev, dsa_slave_sync_mdb_addr, + dsa_slave_unsync_mdb_addr); +out: dev_mc_sync(master, dev); dev_uc_sync(master, dev); } @@ -1395,6 +1440,11 @@ static int dsa_slave_changeupper(struct net_device *dev, if (netif_is_bridge_master(info->upper_dev)) { if (info->linking) { + /* Remove existing MC addresses that might have been + * programmed + */ + __hw_addr_unsync_dev(&dev->mc, dev, + dsa_slave_unsync_mdb_addr); err = dsa_port_bridge_join(dp, info->upper_dev); err = notifier_from_errno(err); } else {