From patchwork Tue Jan 15 19:41:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 1025392 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WTblBvYc"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43fLNC48Srz9s9G for ; Wed, 16 Jan 2019 06:42:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731866AbfAOTmu (ORCPT ); Tue, 15 Jan 2019 14:42:50 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40082 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389451AbfAOTms (ORCPT ); Tue, 15 Jan 2019 14:42:48 -0500 Received: by mail-pg1-f196.google.com with SMTP id z10so1666928pgp.7 for ; Tue, 15 Jan 2019 11:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LDCpuwMTsExuN9AY2TbB7aHKA/vWaZhq13Goarr46z4=; b=WTblBvYcyq5NEd7UkkOLl4ay3uCXvlsoDjXQQftnn0guBJ+GlMmibNAuVN8jKRDfGY Wr5mC2/ZRnyLwdopXb2VdkMm5vC+u3Bp5jLPYPYpS/5dvNoZFElQh33AoqpW4VUwZ127 4aeSVDnLng9baNEVfKGnQMMTtm/8G9aUl4HBpwcyVJbxBSEi3R+uhEzVz+/ZKomjbEyB +oNZUXO9H/Ku5P+7D70cvpODOGQW+76zkZj+5qm0RGGtVyitpSr4JeISY5xNgX+dLofF 3krRN7X0cnnkCiQtLEXzB3J+hP4+LVvwVGzRix/RgmHeoXpvqoPF9NMjCepa4ilX4rX2 /qzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LDCpuwMTsExuN9AY2TbB7aHKA/vWaZhq13Goarr46z4=; b=HM4OnoFQe20sfyi9MP4p2Fe+hYMw0ILLw1sLnCmL/hS4tjMZQAfmrXYoWFl699GbGE 9zE4MZB/brVJzN0vL6L8SeBKButv4KXBdzXA79F1hXq6N2dtw1NC8Z5Q09uHsTnPrhI2 N7/VDAVpv3dn36LQzogrQmxm9ueKYECs0J8jJD6cofXFY/BYOS81JjaH83tCIYx9U/Ow 5Y/XqFh9FTkJjtmMGLTXiGQtDdKvQp1sHsuC/F9TBWCaQcTLFbh/bQJAnq+5r236w5om dKez3L0+Tsa7utlZmMSbipySVmv2HorlIe2T18LNozmaSl8PwhfMMbYx028hvyZBVqUc BFGw== X-Gm-Message-State: AJcUukcD1wZZ2g1FCt9W4fS+LU1NF+maf1DnXL18udwb/3H0I6AM2jrx ENpFubSXW6sshzboiCYdoKfQjwo+ X-Google-Smtp-Source: ALg8bN74f5paYpJCrOfr022bo6Pzy5RxfdYWWRSredt+kMt3+DLBS/UjD1Is76lOLyTNbUWCuIY3Ag== X-Received: by 2002:a63:4c5:: with SMTP id 188mr5273706pge.391.1547581366477; Tue, 15 Jan 2019 11:42:46 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id 128sm6954262pfu.129.2019.01.15.11.42.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Jan 2019 11:42:45 -0800 (PST) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , andrew@lunn.ch, vivien.didelot@gmail.com, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: [RFC net-next 09/14] net: bridge: Propagate MC addresses with VID through switchdev Date: Tue, 15 Jan 2019 11:41:25 -0800 Message-Id: <20190115194130.19896-10-f.fainelli@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190115194130.19896-1-f.fainelli@gmail.com> References: <20190115194130.19896-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In order for bridge port members to get a chance to implement unicast and multicast address filtering correctly, which would matter for e.g: switch network devices, synchronize the UC and MC lists down to the individual bridge port members using switchdev HOST_MDB objects such that this does not impact drivers that already have a ndo_set_rx_mode() operation which likely already operate in promiscuous mode. When the bridge has multicast snooping enabled, proper HOST_MDB notifications will be sent through br_mdb_notify() already. Signed-off-by: Florian Fainelli --- net/bridge/br_device.c | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 013323b6dbe4..ce10d6b7b151 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include "br_private.h" @@ -182,8 +183,62 @@ static int br_dev_open(struct net_device *dev) return 0; } +static int bridge_sync_unsync_mc_addr(struct net_device *dev, + const unsigned char *addr, + bool add) +{ + struct net_bridge *br = netdev_priv(dev); + struct switchdev_obj_port_mdb mdb = { + .obj = { + .orig_dev = dev, + .id = SWITCHDEV_OBJ_ID_HOST_MDB, + .flags = SWITCHDEV_F_DEFER, + }, + .vid = 0, + }; + struct net_bridge_port *p; + int ret = -EOPNOTSUPP; + +#ifdef CONFIG_BRIDGE_VLAN_FILTERING + if (br_vlan_enabled(dev)) + mdb.vid = br->default_pvid; +#endif + + ether_addr_copy(mdb.addr, addr); + spin_lock_bh(&br->lock); + list_for_each_entry(p, &br->port_list, list) { + if (add) + ret = switchdev_port_obj_add(p->dev, &mdb.obj, NULL); + else + ret = switchdev_port_obj_del(p->dev, &mdb.obj); + if (ret) + goto out; + } +out: + spin_unlock_bh(&br->lock); + return ret; +} + +static int bridge_sync_mc_addr(struct net_device *dev, + const unsigned char *addr) +{ + return bridge_sync_unsync_mc_addr(dev, addr, true); +} + +static int bridge_unsync_mc_addr(struct net_device *dev, + const unsigned char *addr) +{ + return bridge_sync_unsync_mc_addr(dev, addr, false); +} + static void br_dev_set_multicast_list(struct net_device *dev) { + /* HOST_MDB notifications are sent through MDB notifications */ + if (br_multicast_enabled(dev)) + return; + + __hw_addr_sync_dev(&dev->mc, dev, bridge_sync_mc_addr, + bridge_unsync_mc_addr); } static void br_dev_change_rx_flags(struct net_device *dev, int change)