Message ID | 20190114094423.1204-1-yangbo.lu@nxp.com |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
Series | net: dpaa2: build ptp clock driver in default | expand |
On Mon, Jan 14, 2019 at 05:44:23PM +0800, Yangbo Lu wrote: > This patch is to set "default y" for dpaa2 ptp driver building. > It will provide user an available ptp clock in default. > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > --- > drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig > index 809a155..15351fc 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/Kconfig > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig > @@ -11,6 +11,7 @@ config FSL_DPAA2_PTP_CLOCK > tristate "Freescale DPAA2 PTP Clock" > depends on FSL_DPAA2_ETH && POSIX_TIMERS > select PTP_1588_CLOCK We want to use "imply" instead of "select" here. > + default y I'm okay with the defaulting to yes. Thanks, Richard
Hi Richard, > -----Original Message----- > From: Richard Cochran <richardcochran@gmail.com> > Sent: Friday, January 18, 2019 9:26 AM > To: Y.b. Lu <yangbo.lu@nxp.com> > Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>; Ioana > Ciocoi Radulescu <ruxandra.radulescu@nxp.com> > Subject: Re: [PATCH] net: dpaa2: build ptp clock driver in default > > On Mon, Jan 14, 2019 at 05:44:23PM +0800, Yangbo Lu wrote: > > This patch is to set "default y" for dpaa2 ptp driver building. > > It will provide user an available ptp clock in default. > > > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > > --- > > drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig > b/drivers/net/ethernet/freescale/dpaa2/Kconfig > > index 809a155..15351fc 100644 > > --- a/drivers/net/ethernet/freescale/dpaa2/Kconfig > > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig > > @@ -11,6 +11,7 @@ config FSL_DPAA2_PTP_CLOCK > > tristate "Freescale DPAA2 PTP Clock" > > depends on FSL_DPAA2_ETH && POSIX_TIMERS > > select PTP_1588_CLOCK > > We want to use "imply" instead of "select" here. [Y.b. Lu] Just learned the "imply" from the doc. I have a query here. Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of FSL_DPAA2_PTP_CLOCK driver may not work. Doesn't it matter? Thanks. > > > + default y > > I'm okay with the defaulting to yes. > > Thanks, > Richard
On Fri, Jan 18, 2019 at 07:18:32AM +0000, Y.b. Lu wrote: > > We want to use "imply" instead of "select" here. > > [Y.b. Lu] Just learned the "imply" from the doc. I have a query here. > Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of FSL_DPAA2_PTP_CLOCK driver may not work. > Doesn't it matter? If PTP_1588_CLOCK is not compiled, then your driver should handle this case: * ptp_clock_register() - register a PTP hardware clock driver * Returns a valid pointer on success or PTR_ERR on failure. If PHC * support is missing at the configuration level, this function * returns NULL, and drivers are expected to gracefully handle that * case separately. Thanks, Richard
diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig index 809a155..15351fc 100644 --- a/drivers/net/ethernet/freescale/dpaa2/Kconfig +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig @@ -11,6 +11,7 @@ config FSL_DPAA2_PTP_CLOCK tristate "Freescale DPAA2 PTP Clock" depends on FSL_DPAA2_ETH && POSIX_TIMERS select PTP_1588_CLOCK + default y help This driver adds support for using the DPAA2 1588 timer module as a PTP clock.
This patch is to set "default y" for dpaa2 ptp driver building. It will provide user an available ptp clock in default. Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> --- drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)