From patchwork Sun Jan 6 08:37:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 1021058 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43XX4m5W2kz9s9h for ; Sun, 6 Jan 2019 19:39:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbfAFIjR (ORCPT ); Sun, 6 Jan 2019 03:39:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:57184 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726438AbfAFIiE (ORCPT ); Sun, 6 Jan 2019 03:38:04 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 04EB1ACAE; Sun, 6 Jan 2019 08:38:03 +0000 (UTC) From: =?utf-8?q?Andreas_F=C3=A4rber?= To: linux-lpwan@lists.infradead.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andrea?= =?utf-8?b?cyBGw6RyYmVy?= , "David S. Miller" Subject: [PATCH lora-next 02/11] net: lora: sx130x: Fix error codes Date: Sun, 6 Jan 2019 09:37:45 +0100 Message-Id: <20190106083754.6004-3-afaerber@suse.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190106083754.6004-1-afaerber@suse.de> References: <20190106083754.6004-1-afaerber@suse.de> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use of -ENXIO results in a misleading error message from ip command: RTNETLINK answers: No such device or address Switch to -EIO for more accurate description: RTNETLINK answers: Input/output error Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora/sx130x.c index 88d4ce1aabcf..21db0ddb101f 100644 --- a/drivers/net/lora/sx130x.c +++ b/drivers/net/lora/sx130x.c @@ -353,7 +353,7 @@ static int sx130x_agc_calibrate(struct sx130x_priv *priv) if (val != SX1301_MCU_AGC_CAL_FW_VERSION) { dev_err(priv->dev, "unexpected firmware version, expecting %u\n", SX1301_MCU_AGC_CAL_FW_VERSION); - return -ENXIO; + return -EIO; } ret = sx130x_field_write(priv, F_EMERGENCY_FORCE_HOST_CTRL, 0); @@ -380,7 +380,7 @@ static int sx130x_agc_calibrate(struct sx130x_priv *priv) dev_info(priv->dev, "AGC status: %02x\n", (unsigned)val); if ((val & (BIT(7) | BIT(0))) != (BIT(7) | BIT(0))) { dev_err(priv->dev, "AGC calibration failed\n"); - return -ENXIO; + return -EIO; } return 0; @@ -453,7 +453,7 @@ static int sx130x_load_all_firmware(struct sx130x_priv *priv) if (val != SX1301_MCU_AGC_FW_VERSION) { dev_err(priv->dev, "unexpected firmware version, expecting %u\n", SX1301_MCU_AGC_FW_VERSION); - return -ENXIO; + return -EIO; } ret = sx130x_arb_ram_read(priv, 0x20, &val); @@ -467,7 +467,7 @@ static int sx130x_load_all_firmware(struct sx130x_priv *priv) if (val != SX1301_MCU_ARB_FW_VERSION) { dev_err(priv->dev, "unexpected firmware version, expecting %u\n", SX1301_MCU_ARB_FW_VERSION); - return -ENXIO; + return -EIO; } return 0; @@ -636,7 +636,7 @@ int sx130x_probe(struct device *dev) if (ver != SX1301_CHIP_VERSION) { dev_err(dev, "unexpected version: %u\n", ver); - return -ENXIO; + return -EIO; } ret = regmap_write(priv->regmap, SX1301_PAGE, 0);