diff mbox series

net/mlx5e: fix semicolon.cocci warnings

Message ID 20181222120216.GA74933@lkp-hsx03.lkp.intel.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series net/mlx5e: fix semicolon.cocci warnings | expand

Commit Message

kbuild test robot Dec. 22, 2018, 12:02 p.m. UTC 
From: kbuild test robot <fengguang.wu@intel.com>

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
CC: Gavi Teitz <gavi@mellanox.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   340ae71f9dd421227a58c14a909b63033745dca4
commit: 4c8fb2986d44c5a75949a88ac61deec0ed50a542 [11213/11734] net/mlx5e: Increase VF representors' SQ size to 128

 en_rep.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Romanovsky Dec. 23, 2018, 7:06 a.m. UTC | #1 
On Sat, Dec 22, 2018 at 08:02:16PM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
> CC: Gavi Teitz <gavi@mellanox.com>
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> ---

Dave,

Can you please apply this small fix?

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
David Miller Dec. 24, 2018, 6:01 p.m. UTC | #2 
From: Leon Romanovsky <leon@kernel.org>
Date: Sun, 23 Dec 2018 09:06:13 +0200

> Can you please apply this small fix?

Sure, I (eventually) will.  I'm just trying to figure out a few procedural
issues with handling the early net-next pull request before I start tossing
more changes on top.

Thanks!
David Miller Dec. 24, 2018, 10:20 p.m. UTC | #3 
From: kbuild test robot <fengguang.wu@intel.com>
Date: Sat, 22 Dec 2018 20:02:16 +0800

> From: kbuild test robot <fengguang.wu@intel.com>
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
> CC: Gavi Teitz <gavi@mellanox.com>
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>

Applied.
diff mbox series

Patch

--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -1336,7 +1336,7 @@  static void mlx5e_build_rep_params(struc
 	if (rep->vport == FDB_UPLINK_VPORT)
 		params->log_sq_size = MLX5E_PARAMS_DEFAULT_LOG_SQ_SIZE;
 	else
-		params->log_sq_size = MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE;;
+		params->log_sq_size = MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE;
 
 	/* RQ */
 	mlx5e_build_rq_params(mdev, params);