From patchwork Mon Nov 19 23:04:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajat Jain X-Patchwork-Id: 1000146 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="kNN3V41Q"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42zPYw3hRrz9s3C for ; Tue, 20 Nov 2018 10:05:08 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732093AbeKTJa1 (ORCPT ); Tue, 20 Nov 2018 04:30:27 -0500 Received: from mail-pl1-f202.google.com ([209.85.214.202]:49385 "EHLO mail-pl1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732067AbeKTJaY (ORCPT ); Tue, 20 Nov 2018 04:30:24 -0500 Received: by mail-pl1-f202.google.com with SMTP id o10-v6so20462094plk.16 for ; Mon, 19 Nov 2018 15:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=hozA7Ab9Mbo9dP4gWzek1tXXv9KaEdb0RAgi2ZqAK7A=; b=kNN3V41Qzl7VMMMjqPuUBqaprYPthA6N4Txzdkq/UT8nCXoc8FSn0r0uLsCroW+mm+ Up4i7WbNMfRfe2D6Kz2I8tbhi/4Crx41wITmLIbnjGzuT0PsKBEpcVDi4bMkKAclhfdg 2S7+C0PQGe6wR4BMipewGmJmR31hCPumKJTwOp77qmHcPUnaq+nSDQUvz5kxnhbkjtT9 K6UsWb87A0mfyc1cVUeciEolkJzx1y2pXeGphR/hfzabwoZCqiEJft0Gk4SUHGeTluVQ tOiiirdzJe3yLIdxKebkMuOO+3qXTUF+XJLp/t87ENKhmt2qFZJ4Ow9IoPiJA9F07nbX vfsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=hozA7Ab9Mbo9dP4gWzek1tXXv9KaEdb0RAgi2ZqAK7A=; b=RhqLN+Wfq/cUqTiguQibcsXsG6dbv4rVg8LB74/Xzefp7VnbNkE9/m7VZa4897iSaf knOoCLPXcIlb9WTrfVZhrM5krFjmw1QV1TsZ8WuvdYiixQ4fIGV+Hi+ns750J8OoCbwI zGhAoj9B8XHPWDmTuJDCBB3sgLt/BJBcuU9gC/EJUocEg1ealLkfSIVgDHw97oGKzPqO HalV3hO64tpTjR5bgpbqDa7kZfZQLrW8VFR/31nlY4xsTUWkZ2PP58vamhAXJHD+zegh UR/B21RfPzD4uD3lM5hldnOWg7eQUUjYcaHQB8Gaee7kJona8AMmyJUtUy+oP1d1S/an XRBA== X-Gm-Message-State: AGRZ1gL9KBdiSonYsmMjuf2rwVerwdPly3n+aLmIrTgXj0TkBGHoNreY PGnpBN0H/3l+fpTaKk0BLxd/U1uM3LFv X-Google-Smtp-Source: AJdET5ecBZzURnJmtWNOpDzYUP6gzTjRvxiu7VaSkfzZWHs94/8LDuHXzrAweriKyMCS4ZZr3ce5wPTctIw9 X-Received: by 2002:a63:2c13:: with SMTP id s19mr7793541pgs.75.1542668667066; Mon, 19 Nov 2018 15:04:27 -0800 (PST) Date: Mon, 19 Nov 2018 15:04:06 -0800 In-Reply-To: <20181119230409.258121-1-rajatja@google.com> Message-Id: <20181119230409.258121-2-rajatja@google.com> Mime-Version: 1.0 References: <20181117010748.24347-1-rajatja@google.com> <20181119230409.258121-1-rajatja@google.com> X-Mailer: git-send-email 2.19.1.1215.g8438c0b245-goog Subject: [PATCH v2 2/5] usb: assign ACPI companions for embedded USB devices From: Rajat Jain To: Marcel Holtmann , Johan Hedberg , Greg Kroah-Hartman , "David S. Miller" , Dmitry Torokhov , Rajat Jain , Alex Hung , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Cc: rajatxjain@gmail.com, dtor@google.com, raghuram.hegde@intel.com, chethan.tumkur.narayan@intel.com, sukumar.ghorai@intel.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dmitry Torokhov USB devices permanently connected to USB ports may be described in ACPI tables and share ACPI devices with ports they are connected to. See [1] for details. This will allow us to describe sideband resources for devices, such as, for example, hard reset line for BT USB controllers. [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/other-acpi-namespace-objects#acpi-namespace-hierarchy-and-adr-for-embedded-usb-devices Signed-off-by: Dmitry Torokhov Signed-off-by: Rajat Jain (changed how we get the usb_port) --- v2: same as v1 drivers/usb/core/usb-acpi.c | 44 +++++++++++++++++++++++++++++-------- 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/drivers/usb/core/usb-acpi.c b/drivers/usb/core/usb-acpi.c index 8ff73c83e8e8..9043d7242d67 100644 --- a/drivers/usb/core/usb-acpi.c +++ b/drivers/usb/core/usb-acpi.c @@ -200,30 +200,56 @@ static struct acpi_device * usb_acpi_find_companion_for_device(struct usb_device *udev) { struct acpi_device *adev; + struct usb_port *port_dev; + struct usb_hub *hub; + + if (!udev->parent) { + /* root hub is only child (_ADR=0) under its parent, the HC */ + adev = ACPI_COMPANION(udev->dev.parent); + return acpi_find_child_device(adev, 0, false); + } - if (!udev->parent) + hub = usb_hub_to_struct_hub(udev->parent); + if (!hub) return NULL; - /* root hub is only child (_ADR=0) under its parent, the HC */ - adev = ACPI_COMPANION(udev->dev.parent); - return acpi_find_child_device(adev, 0, false); + /* + * This is an embedded USB device connected to a port and such + * devices share port's ACPI companion. + */ + port_dev = hub->ports[udev->portnum - 1]; + return usb_acpi_get_companion_for_port(port_dev); } - static struct acpi_device *usb_acpi_find_companion(struct device *dev) { /* - * In the ACPI DSDT table, only usb root hub and usb ports are - * acpi device nodes. The hierarchy like following. + * The USB hierarchy like following: + * * Device (EHC1) * Device (HUBN) * Device (PR01) * Device (PR11) * Device (PR12) + * Device (FN12) + * Device (FN13) * Device (PR13) * ... - * So all binding process is divided into two parts. binding - * root hub and usb ports. + * where HUBN is root hub, and PRNN are USB ports and devices + * connected to them, and FNNN are individualk functions for + * connected composite USB devices. PRNN and FNNN may contain + * _CRS and other methods describing sideband resources for + * the connected device. + * + * On the kernel side both root hub and embedded USB devices are + * represented as instances of usb_device structure, and ports + * are represented as usb_port structures, so the whole process + * is split into 2 parts: finding companions for devices and + * finding companions for ports. + * + * Note that we do not handle individual functions of composite + * devices yet, for that we would need to assign companions to + * devices corresponding to USB interfaces. */ if (is_usb_device(dev)) return usb_acpi_find_companion_for_device(to_usb_device(dev));