From patchwork Fri Oct 26 21:22:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 989782 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="ElHyYk3o"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42hcRn4Q9dz9sD9 for ; Sat, 27 Oct 2018 08:23:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727944AbeJ0GCI (ORCPT ); Sat, 27 Oct 2018 02:02:08 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:33632 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727256AbeJ0GCH (ORCPT ); Sat, 27 Oct 2018 02:02:07 -0400 Received: by mail-ed1-f66.google.com with SMTP id f1-v6so2489036edi.0 for ; Fri, 26 Oct 2018 14:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3K6SqR+g4h84dvT64My/Y2arGiA5tvTZGkr85MFLugg=; b=ElHyYk3oLlVi/nIm3w63VgMKMN5vbHC5qfp2uuF9OHj/XebiRlfLmD2gZNw1zhiGuM 1aN8KNaMpujLbL/L2zQJPBKjlx/imQQbu0AGQmAu0Dl9ZSfAEDw35/VleOwEZS6t2TwZ Y0yTHagHOZJTcjwng04x4sIkCF4cSjv4EVXrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3K6SqR+g4h84dvT64My/Y2arGiA5tvTZGkr85MFLugg=; b=QwfMaTRT7ffx6kCsDWXJTw8gRNDtbpmE84buUAPFcj64638qCEqr0wogf2KFqDG12i 6cefpIV6G9pvYln/rk6TJoCi0z84GS2kysQ4wZvaqEZFoSzuwqmEswpM56L12cPrERZa 9RzztTxCI+eDHdEf1N4u0lgHvksuS53u5DZ9OX55wupATcAzyfVjkKo+d9euUE8cwP1I dxn6MBil3LO0xDR9pp2d2U7WlaWkta/+m9IudEw5M24P0i1/Er5B7z65XUHSMUZZ+Ehk fGTiQtiKdKHrK4luVO5x0nWHhHpuhWxOQkYu7hY3VzppqnzHAptCigo5bQY6k/t8kUbX wClw== X-Gm-Message-State: AGRZ1gKaDzBroDYXVdntC7bNZgLiRpjjkBY608ZluajAVqIeHV4RtKzn ElWh04UenMBIchninglWdAfhgA== X-Google-Smtp-Source: AJdET5fa45vUKVlyffjx4+x+Q0WMeiNrDKaw6R4nF3o5IVy/MJXo4bmDQOjcxi9t0n3kOI60vh1J/A== X-Received: by 2002:a50:913d:: with SMTP id e58-v6mr4227670eda.148.1540589009792; Fri, 26 Oct 2018 14:23:29 -0700 (PDT) Received: from prevas-ravi.waoo.dk (dhcp-5-186-114-252.cgn.ip.fibianet.dk. [5.186.114.252]) by smtp.gmail.com with ESMTPSA id r28-v6sm1727791eda.25.2018.10.26.14.23.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Oct 2018 14:23:29 -0700 (PDT) From: Rasmus Villemoes To: Richard Cochran Cc: Kees Cook , Rasmus Villemoes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ptp: drop redundant kasprintf() to create worker name Date: Fri, 26 Oct 2018 23:22:59 +0200 Message-Id: <20181026212300.5827-1-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.19.1.6.gbde171bbf5 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Building with -Wformat-nonliteral, gcc complains drivers/ptp/ptp_clock.c: In function ‘ptp_clock_register’: drivers/ptp/ptp_clock.c:239:26: warning: format not a string literal and no format arguments [-Wformat-nonliteral] worker_name : info->name); kthread_create_worker takes fmt+varargs to set the name of the worker, and that happens with a vsnprintf() to a stack buffer (that is then copied into task_comm). So there's no reason not to just pass "ptp%d", ptp->index to kthread_create_worker() and avoid the intermediate worker_name variable. Signed-off-by: Rasmus Villemoes Acked-by: Richard Cochran Reviewed-by: Kees Cook --- drivers/ptp/ptp_clock.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index 7eacc1c4b3b1..5419a89d300e 100644 --- a/drivers/ptp/ptp_clock.c +++ b/drivers/ptp/ptp_clock.c @@ -232,12 +232,8 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info, init_waitqueue_head(&ptp->tsev_wq); if (ptp->info->do_aux_work) { - char *worker_name = kasprintf(GFP_KERNEL, "ptp%d", ptp->index); - kthread_init_delayed_work(&ptp->aux_work, ptp_aux_kworker); - ptp->kworker = kthread_create_worker(0, worker_name ? - worker_name : info->name); - kfree(worker_name); + ptp->kworker = kthread_create_worker(0, "ptp%d", ptp->index); if (IS_ERR(ptp->kworker)) { err = PTR_ERR(ptp->kworker); pr_err("failed to create ptp aux_worker %d\n", err);