From patchwork Tue Oct 2 19:14:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mahesh Bandewar X-Patchwork-Id: 977999 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bandewar.net Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bandewar-net.20150623.gappssmtp.com header.i=@bandewar-net.20150623.gappssmtp.com header.b="xD2bxAi7"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42Ppk83DfTz9s3x for ; Wed, 3 Oct 2018 05:14:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727627AbeJCB73 (ORCPT ); Tue, 2 Oct 2018 21:59:29 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:43374 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726781AbeJCB73 (ORCPT ); Tue, 2 Oct 2018 21:59:29 -0400 Received: by mail-pl1-f193.google.com with SMTP id 30-v6so2208408plb.10 for ; Tue, 02 Oct 2018 12:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bandewar-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uibGi3yWNgP+xuG+TnkLuDHWXuIdsejhyVGdXQvYtWg=; b=xD2bxAi7fbTVOF4/DwdnNB4h2FJvtVb/N0cReRg2uD11Bs5+Juypds+0pixoPbB8I8 LyH6vtpO8eCcuN/67XMY+1j/YWgBX+PVvaQ5TnGSZQZzMlhvqfhU07NVLX/b+9pCr3YX GPmSGXWhf84luBD4xv8lX+HCHhCAOWXygxbZO9Q9YVu3Vo64/kTt60HVmpJ927QF2sn4 Gik9FrW3O7T5BnL3IK352XEPAe+O44/aSQE/ZZ0KJd2HiXssYC26eG3ABK/GLcMttjzG gCiTC0B4hq+DugoDWQkeEA27oqv+HN9w/0n3Lr2X9eNTlJGIqwauKXNty3VrY1kawrzi bvAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uibGi3yWNgP+xuG+TnkLuDHWXuIdsejhyVGdXQvYtWg=; b=bf8Q5N5jgdioPyfQfJ+eydzk66mKskLXzr1WQFB28HAo83wGrDcgBGM95GgOcQNMZl NH2IqgcPikOMXKyUOfSO3wg6Unx4Em4QYS7bbbfX+35iBp902ahKm3aIydHUzPoeWQTA Zd/xl6XiRZkZUROz4WHN80EMz/9+BOh6DS0g1ITz8JL3k7XTOV3opY5A5dW2ueoIcn1U R+/O6kIo8mgMRCJwxo1jYwKGs3O7XAcKxOEBZOuvM0O5fTj4vP9/jiI3mcj/QLvahTMl +oyyry47vNxneJe5E2i22nwXd2gleGtisI+qRLviY5A3octuVHU/t8aCAGYGE5Fab4TR uQPA== X-Gm-Message-State: ABuFfohRfaUJ+GPwqsNns0An34h5qt9apEco3xHRG2Jy5ynSA3IN2OK6 vS3r4YIXnamrveecFrdpfbv+3g== X-Google-Smtp-Source: ACcGV60UW5FdHKMyYyGENqNc+r6h9a3sct52kLfv44qAiukV+o/GgTs4e/S+EUjGEddzFKZwpoCEtw== X-Received: by 2002:a17:902:b213:: with SMTP id t19-v6mr18374901plr.51.1538507677930; Tue, 02 Oct 2018 12:14:37 -0700 (PDT) Received: from localhost ([2620:15c:2c4:201:c7f9:6225:a527:f3a4]) by smtp.gmail.com with ESMTPSA id c69-v6sm25709201pfg.2.2018.10.02.12.14.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Oct 2018 12:14:37 -0700 (PDT) From: Mahesh Bandewar To: Jay Vosburgh , Andy Gospodarek , Veaceslav Falico , David Miller Cc: Mahesh Bandewar , Netdev , Eric Dumazet , Mahesh Bandewar Subject: [PATCH net] bonding: fix warning message Date: Tue, 2 Oct 2018 12:14:34 -0700 Message-Id: <20181002191434.188912-1-mahesh@bandewar.net> X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Mahesh Bandewar RX queue config for bonding master could be different from its slave device(s). With the commit 6a9e461f6fe4 ("bonding: pass link-local packets to bonding master also."), the packet is reinjected into stack with skb->dev as bonding master. This potentially triggers the message: "bondX received packet on queue Y, but number of RX queues is Z" whenever the queue that packet is received on is higher than the numrxqueues on bonding master (Y > Z). Fixes: 6a9e461f6fe4 ("bonding: pass link-local packets to bonding master also.") Reported-by: John Sperbeck Signed-off-by: Eric Dumazet Signed-off-by: Mahesh Bandewar --- drivers/net/bonding/bond_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index c05c01a00755..ee28ec9e0aba 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1187,6 +1187,7 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb) if (nskb) { nskb->dev = bond->dev; + nskb->queue_mapping = 0; netif_rx(nskb); } return RX_HANDLER_PASS;