From patchwork Sun Sep 30 06:44:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Maciej_=C5=BBenczykowski?= X-Patchwork-Id: 976771 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42NGBX0TzGz9s55 for ; Sun, 30 Sep 2018 16:45:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727799AbeI3NQr convert rfc822-to-8bit (ORCPT ); Sun, 30 Sep 2018 09:16:47 -0400 Received: from mail-pf1-f201.google.com ([209.85.210.201]:32966 "EHLO mail-pf1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727496AbeI3NQr (ORCPT ); Sun, 30 Sep 2018 09:16:47 -0400 Received: by mail-pf1-f201.google.com with SMTP id t26-v6so11987985pfh.0 for ; Sat, 29 Sep 2018 23:45:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc:content-transfer-encoding; bh=odYuFR5aRvlU79L2E6EhAeiTlmOm9lZcXQEF+qwndZQ=; b=R1qOoVqomPcL+F9VFgHD3kBN73vAjx0pEfBRwkfVn2MvrkXvZoKI4AlreabdezMxf+ NYGkY6noW4qnLv5SdzZ/ZQbu5dUnM1Kh816stK8CM+uZZIGuLvZW8wDC+eqL9NN+ugT5 yPX+eRWU+E5CM2fSCQXDu4LDEx2kp/uTOzBMvqUdYhlsgBPRht99BXl/G+dmGEp6Ovh3 ZsUGLk1Wq1CUeo7TMqidIdxPGrv6kXus3833O69M/FpkTYf574IAAa/sIJyy7kp9vFhq ogFer+etg1/MTKNbL+3ESpFGIMyIM3UIf6pPT4UUouwHk9ZuKn4hpu84wf1u4f5dV0S7 XUYw== X-Gm-Message-State: ABuFfoh4ZW1SIP+1OvGwN5gJ70BEkL3z8PbFYOYZK9oS5PMy/+LdC8cY o7mARW3k0dcMpUJYEWovEu9+gw== X-Google-Smtp-Source: ACcGV63ntH2/92CPo5h0DBBqJu0Q/gLh61eA6Wq0Znge6rc438+f2vhMTkG9uTqwrqBuZdb0bk5Y5KGt X-Received: by 2002:a62:f51b:: with SMTP id n27-v6mr2728855pfh.67.1538289904325; Sat, 29 Sep 2018 23:45:04 -0700 (PDT) Date: Sat, 29 Sep 2018 23:44:49 -0700 In-Reply-To: <20180930064454.187537-1-zenczykowski@gmail.com> Message-Id: <20180930064454.187537-4-zenczykowski@gmail.com> Mime-Version: 1.0 References: <20180930064454.187537-1-zenczykowski@gmail.com> X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog Subject: [PATCH v2 4/9] net: ip6_redirect_no_header() - use new style struct initializer instead of memset From: "=?UTF-8?q?Maciej=20=C5=BBenczykowski?=" To: "=?UTF-8?q?Maciej=20=C5=BBenczykowski?=" , "David S . Miller" Cc: netdev@vger.kernel.org, David Ahern Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski Reviewed-by: David Ahern --- net/ipv6/route.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 6f252fa914c2..dff80697c033 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2530,15 +2530,14 @@ void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif, const struct ipv6hdr *iph = ipv6_hdr(skb); const struct rd_msg *msg = (struct rd_msg *)icmp6_hdr(skb); struct dst_entry *dst; - struct flowi6 fl6; - - memset(&fl6, 0, sizeof(fl6)); - fl6.flowi6_iif = LOOPBACK_IFINDEX; - fl6.flowi6_oif = oif; - fl6.flowi6_mark = mark; - fl6.daddr = msg->dest; - fl6.saddr = iph->daddr; - fl6.flowi6_uid = sock_net_uid(net, NULL); + struct flowi6 fl6 = { + .flowi6_iif = LOOPBACK_IFINDEX, + .flowi6_oif = oif, + .flowi6_mark = mark, + .daddr = msg->dest, + .saddr = iph->daddr, + .flowi6_uid = sock_net_uid(net, NULL), + }; dst = ip6_route_redirect(net, &fl6, skb, &iph->saddr); rt6_do_redirect(dst, NULL, skb);