From patchwork Sun Sep 30 06:44:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Maciej_=C5=BBenczykowski?= X-Patchwork-Id: 976770 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42NGBW2pMCz9s4s for ; Sun, 30 Sep 2018 16:45:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727744AbeI3NQp convert rfc822-to-8bit (ORCPT ); Sun, 30 Sep 2018 09:16:45 -0400 Received: from mail-pg1-f201.google.com ([209.85.215.201]:46811 "EHLO mail-pg1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727496AbeI3NQp (ORCPT ); Sun, 30 Sep 2018 09:16:45 -0400 Received: by mail-pg1-f201.google.com with SMTP id r130-v6so11525833pgr.13 for ; Sat, 29 Sep 2018 23:45:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc:content-transfer-encoding; bh=9wsIGQqjAkNzNebFeylBSNPEwp7HaknmKw3koEXBTjg=; b=CHwikQApy1RWPOJKWytbEhyz33s4q542YS989lz1cBYPnMn0Rw3Foh+MoI30Um1uOD hG4mkA12it+CFUHoRNbqUzXOowqqEgHkZjYAIn9lkpC+2W0I2+ybaOVZQzGuNUK9Q8Hg CuE2tYqBidNH0Cua5MimISLT0d50R+A0B330OORVMnj2M7c3wdre3GTu/AFokaiVkZ5X EUQkTHNxUCRgbWmH331J1C3Hcm5ecb10J0+RcfSmQy7soRHVEkomiPtY0LQGY0KljPLR EOYrsArTfmKMo3IfSVoeDSpEXQfP4CaqY/+eMWerYATFMi4MV3Aebc+fPK9gPakq5/6Y +mNw== X-Gm-Message-State: ABuFfoidxyf6cClUy6dtP3GjsFqJZnAiZCbwbKgxAcKQpaPOYwHJRLhs d6W31ZuVa7b0bkUqifBojomBfQ== X-Google-Smtp-Source: ACcGV61QA7p08Y4vSMoHtwliT1x4xyRAPwg3xcVaScOWmkyZoJpQ5ZiLFDg0gZI3U/6qXskD+iSgv054 X-Received: by 2002:a63:103:: with SMTP id 3-v6mr2641556pgb.52.1538289902168; Sat, 29 Sep 2018 23:45:02 -0700 (PDT) Date: Sat, 29 Sep 2018 23:44:48 -0700 In-Reply-To: <20180930064454.187537-1-zenczykowski@gmail.com> Message-Id: <20180930064454.187537-3-zenczykowski@gmail.com> Mime-Version: 1.0 References: <20180930064454.187537-1-zenczykowski@gmail.com> X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog Subject: [PATCH v2 3/9] net: ip6_redirect() - use new style struct initializer instead of memset From: "=?UTF-8?q?Maciej=20=C5=BBenczykowski?=" To: "=?UTF-8?q?Maciej=20=C5=BBenczykowski?=" , "David S . Miller" Cc: netdev@vger.kernel.org, David Ahern Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski Reviewed-by: David Ahern --- net/ipv6/route.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index d28f83e01593..6f252fa914c2 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2508,16 +2508,15 @@ void ip6_redirect(struct sk_buff *skb, struct net *net, int oif, u32 mark, { const struct ipv6hdr *iph = (struct ipv6hdr *) skb->data; struct dst_entry *dst; - struct flowi6 fl6; - - memset(&fl6, 0, sizeof(fl6)); - fl6.flowi6_iif = LOOPBACK_IFINDEX; - fl6.flowi6_oif = oif; - fl6.flowi6_mark = mark; - fl6.daddr = iph->daddr; - fl6.saddr = iph->saddr; - fl6.flowlabel = ip6_flowinfo(iph); - fl6.flowi6_uid = uid; + struct flowi6 fl6 = { + .flowi6_iif = LOOPBACK_IFINDEX, + .flowi6_oif = oif, + .flowi6_mark = mark, + .daddr = iph->daddr, + .saddr = iph->saddr, + .flowlabel = ip6_flowinfo(iph), + .flowi6_uid = uid, + }; dst = ip6_route_redirect(net, &fl6, skb, &ipv6_hdr(skb)->saddr); rt6_do_redirect(dst, NULL, skb);