| Message ID | 20180911223216.15609-1-toke@toke.dk |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2] q_cake: Add printing of no-split-gso option | expand |
On Wed, 12 Sep 2018 00:32:16 +0200 Toke Høiland-Jørgensen <toke@toke.dk> wrote: > When the GSO splitting was turned into dual split-gso/no-split-gso options, > the printing of the latter was left out. Add that, so output is consistent > with the options passed. > > Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk> Applied. I noticed that nat/nonat and wash/nowash have similar missing output.
Stephen Hemminger <stephen@networkplumber.org> writes: > On Wed, 12 Sep 2018 00:32:16 +0200 > Toke Høiland-Jørgensen <toke@toke.dk> wrote: > >> When the GSO splitting was turned into dual split-gso/no-split-gso options, >> the printing of the latter was left out. Add that, so output is consistent >> with the options passed. >> >> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk> > > Applied. I noticed that nat/nonat and wash/nowash have similar missing > output. Thanks! And yeah, you're right; I'll send another patch :) -Toke
diff --git a/tc/q_cake.c b/tc/q_cake.c index 50de46a7..077bf84f 100644 --- a/tc/q_cake.c +++ b/tc/q_cake.c @@ -524,6 +524,8 @@ static int cake_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) if (split_gso) print_string(PRINT_FP, NULL, "split-gso ", NULL); + else + print_string(PRINT_FP, NULL, "no-split-gso ", NULL); print_bool(PRINT_JSON, "split_gso", NULL, split_gso); if (interval)
When the GSO splitting was turned into dual split-gso/no-split-gso options, the printing of the latter was left out. Add that, so output is consistent with the options passed. Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk> --- tc/q_cake.c | 2 ++ 1 file changed, 2 insertions(+)