From patchwork Mon May 21 22:00:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Lendacky X-Patchwork-Id: 917895 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="Zh6nctr4"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qXlt1VB8z9s16 for ; Tue, 22 May 2018 08:00:58 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754103AbeEUWAy (ORCPT ); Mon, 21 May 2018 18:00:54 -0400 Received: from mail-cys01nam02on0075.outbound.protection.outlook.com ([104.47.37.75]:28875 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751234AbeEUWAL (ORCPT ); Mon, 21 May 2018 18:00:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UN8iKlB+ZnFEoWtKV/NCFronUiTiYeA6E1v0FWrgjqY=; b=Zh6nctr42efxA6WKpdrBZDpH4fkA9W3ZHNxTMHEKKrm/GoXPGC8nBhTrkKMY2IIzPdfJpDqIwNo4Cn/Klrd7onWNv51pJixhxUdCiVh2ipmiLLlJXOXPu8ZYAblqr6eEWF/k6+uu0w9jHArjGxd17+I7WCZKfB+V6GHyEeqVAbU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.77.1) by CY1PR12MB0167.namprd12.prod.outlook.com (2a01:111:e400:50f6::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Mon, 21 May 2018 22:00:09 +0000 From: Tom Lendacky Subject: [PATCH net-next 11/12] amd-xgbe: Update the BelFuse quirk to support SGMII To: netdev@vger.kernel.org Cc: David Miller Date: Mon, 21 May 2018 17:00:05 -0500 Message-ID: <20180521220005.8135.23128.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20180521215818.8135.83100.stgit@tlendack-t1.amdoffice.net> References: <20180521215818.8135.83100.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0501CA0133.namprd05.prod.outlook.com (2603:10b6:803:2c::11) To CY1PR12MB0167.namprd12.prod.outlook.com (2a01:111:e400:50f6::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:CY1PR12MB0167; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0167; 3:u6FaP0j1dvOj5m/I/rzN4CZCpFMULkgNWcmmZDuQLgo8lIfglR+L0g5BOmN75JDVdY60FNM4tU/73lFuxlivGWnaSu2UNTyKW6+V6VbGWcUhifBzErWzNSpBPrPZ68iOnnwf88Ucq0wBSC6xQzy9EbzSzRxPIwlTcwrIOBTaMm0njEUoECa6Kj4Kip+6h2j505Fsb4Q1nk5W9uJKTczdmRb4IssxvMi+PSGCkMk6CbNsSry5DP9VQupuqvfgjLVJ; 25:vmgzr5CCJkq34VyYikBV3f94/PUJlVL7O3GD7IgyuhW/E8DoNnAhvsKmpEvlVd0XXPbVEzKQ0ZCLN2DakpoZ3FTP/VxrxltCa/6q7hxDeh04F0U1OY/xEGRo6E6o+420FNonA3BdGJmiIf5duav3n7RoDT0f2wgF0HMuTo53iBHlXLWTsJQ+mcR09Z8TU/IWvDkHnd+BU8q9Fy6zVZiubSBGHt9JXDYcCnjptQ1KNWbLZKjCBgCNQRNf9KkDGIQ4xnPLJ1cuPUiA9CphENTA6La7U19Duak2vWDT0r0PCSevgY24415muucKsfV855fTlYMJQdFaEwWdZsPVWdear5978fCrQBF6LYsZ/JkSQRQ=; 31:tdIuqaccuUps3UeSeg1GuT3BaMtcVEMEeLpE73usl3CY9+XQLiM74aqCoP/M21uHnbu00HJ3LEBaOorE7LabL5+8tnH9VOFwzVaAQW8LM3XbIlevhbGqI9UQDAaCeKI+gfOBwh3yFxdY5TxSjH3IHz18KLaJJAlm5s8B4tDLAMUR6RA7Wcv4BZvo3aVj+p34I2UY7ae5n/hIcUxq2ZFQ/Z0U2mbl56aJrv+qvv5nCfE= X-MS-TrafficTypeDiagnostic: CY1PR12MB0167: X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0167; 20:M2pkhn9iIUIQffcx7XxEudnhygtqwqAOJmTJSGwnEwePh9RFuRD2v6HiigVU/g133ujPPch51B1MgWuv1Kd8iWbdfplAxlUQ4LgrRlv1wRoWClN+cRyW58+3DI7WK7YDG50XvmYxhyFk9vcmIhXYkUAf05ECmqrQpIFD6XS34CklMEueQKOuWeD7jdln2qvXPde3Fw9pfGKfmazYJycZzuQL/mlTczC3gM/+S7nY0Lp3KdLZPyHIyCQIFjHoe/25GsOMaUlsSQsrcQ6c55LDh3acnAdbeIsFwdNwhDA1HUFQ3uyP+ohmtXqpGpilzCEQR2HAm7a0ROmMGHgLx9Dl6YNBBSW4CUOW5alH2X9AQiISE1GBciFne6Te91USY6TwZhIGKlsDxa6U5us7etC2bxyHtvZa9QvV13OP+xeklh40txnF5A6QlWqEWln5PnVkuzCRgLOURlAUOdBb1ejiu6JWPIUTr057fuGetK1s6mMiuEK092Cw0yHiTXxRb6EZ; 4:X/y+wNE5LOSeH/vasbMw7YSwmjGHRpD58TSzuyGln37dbi63GYJajK31tOzLF024Cdd9QZvC3QeuPsD200JvTdJHsV/7l4KQDX3L6LyIiZG8Pb1ECSRdfQVaoA74ymMpDv7/SxQFLBoCMoumtGSzE7zy4XB0TqMBs+LSSaK46ulPy2no+kfA2xFKgVUPCkzp6K2cJSKjFlQrLpptmZALqgXOP4oov+EyztG2tpkDCWD9g9FTdM/ryjTa6FLeXcgKL9ucg+kWuHCdqdY2bjOMeCoJNL5+jI5XqIFl1WvYPA/h+v+zu47U4IAWUT01syqK X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:CY1PR12MB0167; BCL:0; PCL:0; RULEID:; SRVR:CY1PR12MB0167; X-Forefront-PRVS: 06793E740F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(376002)(366004)(39860400002)(346002)(396003)(189003)(199004)(9686003)(6116002)(53936002)(3846002)(2361001)(575784001)(86362001)(8936002)(2351001)(47776003)(66066001)(486006)(2486003)(23676004)(106356001)(50466002)(305945005)(5660300001)(7736002)(4326008)(55016002)(230700001)(81156014)(69596002)(1076002)(97746001)(8676002)(81166006)(2906002)(68736007)(97736004)(26005)(316002)(53416004)(446003)(386003)(478600001)(16526019)(186003)(58126008)(6506007)(72206003)(7696005)(52116002)(76176011)(476003)(6916009)(6666003)(11346002)(956004)(25786009)(103116003)(15650500001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0167; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BCY1PR12MB0167=3B23=3AZI43?= =?utf-8?q?rNzzEA9IlaThatte0N6c1hAYghl3YK+NCPmBWEbolyZ2CkB8f+QJiSC4?= =?utf-8?q?Y4SahtH6PTWQVWJM7i9QAmMTwtsgd27TVr5EOao5X4Na2asG/WQyHGMh?= =?utf-8?q?b3ZhCjMNof9WZTDyS0mJR5IJumsilPUYd9oxZDqgEeg/5zUs3Ld3knzf?= =?utf-8?q?vP1yzS8QC/ZIQvXQ8EOCFJoIXDj2lvMwnYKX2akYgLSuinRUD6c1ovwg?= =?utf-8?q?1LwiwnBZh+dbyATNJvNRsEeWGr43FCQPUtFTld10HFVcRbn9iE7wJ4Ri?= =?utf-8?q?iPMc20PG7jYSh7t4qCralvm8HTVgMN6ajqUpEW5jAhfqAWwGeVGJYDeI?= =?utf-8?q?zIeXi8w6gfR9Ajcn1hJPuTWuOdxlev0CJFPHGp5hysA2tdSoJCR9vDZ7?= =?utf-8?q?7uqkc4aVxV50pi3zzdqHzsA2HZLVRqELzGRZ4PsQC31lWZkJI9nPbMoL?= =?utf-8?q?VotU2xB1i9HksTC5DyuTcjr4va0PUwpSOkcf/KrPYuT6k3gYqf4hmnm/?= =?utf-8?q?M3OkzW1qXSYu00R9rzPJsBU2RN1nxNc0QayA5Su7QXNoodNgobr0EqKz?= =?utf-8?q?+cPaLzMlk3ZEt+i89dLdbaI5VJMDS1dmv5zs1u6j227z9N8bG9ppqw+H?= =?utf-8?q?JlBWeWWY4YVm9MKHsUVbLJyrsM5kENmPVofX2TY9lyxxbfk4kFYesC4A?= =?utf-8?q?xmqNnQrDu0tBv+8831cDYd6Sntrcjj0Vj5iP0qZ8DbA3VhRXRuUUZtzx?= =?utf-8?q?n+Q2m+WA2EY89K9NVeHsK7UGK0zqi7cxqmTDi3mBiv6Zt76/bcDzzco1?= =?utf-8?q?YKOg8cjlh+4pFgP641BauiC756fJUOYa2KXpxU+8O5pxZ8Zas7008jh+?= =?utf-8?q?/ezYL4jsHvlbGCYGqDJ8ZvfTjHzSXkgS3hOUxipN1A94L22jISBVujsL?= =?utf-8?q?/F8S8x4FTgwYbsKS+4rn1bgc4L5WR4U50C15anu5/Qa/sNoKT3Opt24l?= =?utf-8?q?y9KcokR6+UeKRjeR2x3krnEuZb/fWwqQclh9SwCg+2+6rIc6TSFTomnk?= =?utf-8?q?skZxMcL/szOhaUEp9h/WgGelKhJidwJaWD5yNE5pyXlzlufxzFP+74hS?= =?utf-8?q?lYJ+LwWBPDe/Al9vjPi8DF6abeV66yVNygce4+4Ji84e6RYH/qHMRtKj?= =?utf-8?q?IWTT/ZLSWDwA2VBiuPwzdltgcn8a4tmbOq61lIsl0umifJSrNiSmQ69t?= =?utf-8?q?0FOXukdedTgpc5hJuNVAKfid3G9cYlounz1jMu07b0znNczRue06MpAK?= =?utf-8?q?aB5+Bzz4ZPvpKN6kgBCntXZ4YClHgYKmwMblPHq0vGIEoV18dkoR/DyP?= =?utf-8?q?jrAMfPf6gjj47aPJHISXJd/nRBbPj9YUTJOOigYGoKVYA/gkn2Twmvk5?= =?utf-8?q?ZniY3GlnRXcAwcw+jxv+rqB+AlR0KcbpePq/EC8=3D?= X-Microsoft-Antispam-Message-Info: Iojqw9UNCAijXUZ7vO2WCc6/qYZEjCxj0f9Hxa5YuYT/RBlvzU1IuN9T9wVqW4Z881S9loJ4Ck9rC5KyXGqJnbpmqIDnGFZ0mV8WGg5lOMba2C1RYRVcKgvXXjOSZlauJAGDpxT8uJJJQISKo4k+mymJDmVJwv7p4vtF35X0b/3sbwBzjxt2rKkU4kGebivJ X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0167; 6:A3h0SuLOCDXI8DRaNs0gg+95l//zV3S21zOIihX1JVGukVauvPobmsFTgdgdT75ylW1Uu0NErIObN6RdVoRrxOtEtCOI1clRy/Dxv5mJl+sVmA5kfEm8IDsz/O/D+p9ahFAlxIyQCr6TASix8GzcRslLgBokbde59EZNTUzDC2YnzklNIAJJnF8sBb4TjgryU1/075gGEVfwixBDQyS8jcMb9ZKFiPgtE1XSJEtmMhWUAqMbHgz0JPH2u7Lg1RwOh9c4jm8CM4m9QAsRiG8o/ZW2owRqVsnQ/E+0mr2m4upGCUyNaCslaiwRRdoMeIyozKTyON4CDPiZ1Y2O5XQtJmKQwbfh0IEYE2fmCFgcNKFs1xuuDZeTgGIRgmul9qVxUOvtESAwo9RpLtO9SlP1UTzw2p+eGnfIdJhIQFSuyDhyyxHnNtY5LFvtWYrdjcb6HAjv2yGZrLNGAc6qn/MG9w==; 5:5KTZ+Wyo4s1YqULlU6Ky2DglYlo1tXx6U1dLhGcp8DHKOKTw6o7O3DfWYJqwB62Rcc33mptaFGhazCtdZCtSzMmc/1z6si/kASHY5H8xBpekPX5XNjk0bZQaN3I9vIlxarLPNwSNov/whWnyY4p1xARSQNFnSmWNdCGfkDJpdIc=; 24:kyzQT71x9KZe01L7RbJgConRNFgUuqCyhObCXPC75mBncd/zy659/y0C2yQsqvT8i1Q5XIfqPbaFD/zcBTN+ozboZYGsy2t18ErL3IhTmnM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0167; 7:3sMC+iWNGNJoe6B6wKbtFcY/w2Qmc++q6VIhSKu6WVZ3Di9Rk/P99Fz872KXKosB0SjQdz9VGa9X/Fu9P7lY2w4zr0qDFVwzNVzpxrprDiUqpvj0nI/ckg89T5GYuOTrCUbgTg2+AV6G1YXvMyvz4dsZjifrP84GcwM+9Ot2XaRWLdoK5pVt72Fydt3PPauTwAxgOwZItx6J6L6gzZ8gcNWYngUm2ghL69VXdzzfUbt+KO/OGDaW4vxs3KePw/e3; 20:ClYkzZt1xvBOOn8OvaxD1jbzhTu7a2v4yjy+R72vmYzUmIDOUFVlWjpoR4ybNDDc8CK9vA5OLfe0Y0z447WVdf8DcCMRn4OJEqh744GrzNd8t9i7HRHnHjdUWzNXu08cwMDr+D4ohD68qWJi7wfwEwzzrDS0JvoApWJz3m1UqtHyRVas/DQPrhLlXCu8JlGEgmkJ/XYbQT6bwd5Leyi4fQhn5L3LVxHGhhusvMLQOpY5n9mx9R4pJtLoDcPVqkLo X-MS-Office365-Filtering-Correlation-Id: a53fdb0d-b0b5-41ab-08c7-08d5bf6638b0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2018 22:00:09.8923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a53fdb0d-b0b5-41ab-08c7-08d5bf6638b0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0167 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Instead of using a quirk to make the BelFuse 1GBT-SFP06 part look like a 1000baseX part, program the SFP PHY to support SGMII and 10/100/1000 baseT. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 109 +++++++++++++++++++-------- 1 file changed, 75 insertions(+), 34 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c index dd747f6..194a569 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c @@ -860,6 +860,9 @@ static bool xgbe_phy_finisar_phy_quirks(struct xgbe_prv_data *pdata) struct xgbe_phy_data *phy_data = pdata->phy_data; unsigned int phy_id = phy_data->phydev->phy_id; + if (phy_data->port_mode != XGBE_PORT_MODE_SFP) + return false; + if ((phy_id & 0xfffffff0) != 0x01ff0cc0) return false; @@ -885,8 +888,80 @@ static bool xgbe_phy_finisar_phy_quirks(struct xgbe_prv_data *pdata) return true; } +static bool xgbe_phy_belfuse_phy_quirks(struct xgbe_prv_data *pdata) +{ + struct xgbe_phy_data *phy_data = pdata->phy_data; + struct xgbe_sfp_eeprom *sfp_eeprom = &phy_data->sfp_eeprom; + unsigned int phy_id = phy_data->phydev->phy_id; + int reg; + + if (phy_data->port_mode != XGBE_PORT_MODE_SFP) + return false; + + if (memcmp(&sfp_eeprom->base[XGBE_SFP_BASE_VENDOR_NAME], + XGBE_BEL_FUSE_VENDOR, XGBE_SFP_BASE_VENDOR_NAME_LEN)) + return false; + + if (memcmp(&sfp_eeprom->base[XGBE_SFP_BASE_VENDOR_PN], + XGBE_BEL_FUSE_PARTNO, XGBE_SFP_BASE_VENDOR_PN_LEN)) + return false; + + if ((phy_id & 0xfffffff0) != 0x03625d10) + return false; + + /* Disable RGMII mode */ + phy_write(phy_data->phydev, 0x18, 0x7007); + reg = phy_read(phy_data->phydev, 0x18); + phy_write(phy_data->phydev, 0x18, reg & ~0x0080); + + /* Enable fiber register bank */ + phy_write(phy_data->phydev, 0x1c, 0x7c00); + reg = phy_read(phy_data->phydev, 0x1c); + reg &= 0x03ff; + reg &= ~0x0001; + phy_write(phy_data->phydev, 0x1c, 0x8000 | 0x7c00 | reg | 0x0001); + + /* Power down SerDes */ + reg = phy_read(phy_data->phydev, 0x00); + phy_write(phy_data->phydev, 0x00, reg | 0x00800); + + /* Configure SGMII-to-Copper mode */ + phy_write(phy_data->phydev, 0x1c, 0x7c00); + reg = phy_read(phy_data->phydev, 0x1c); + reg &= 0x03ff; + reg &= ~0x0006; + phy_write(phy_data->phydev, 0x1c, 0x8000 | 0x7c00 | reg | 0x0004); + + /* Power up SerDes */ + reg = phy_read(phy_data->phydev, 0x00); + phy_write(phy_data->phydev, 0x00, reg & ~0x00800); + + /* Enable copper register bank */ + phy_write(phy_data->phydev, 0x1c, 0x7c00); + reg = phy_read(phy_data->phydev, 0x1c); + reg &= 0x03ff; + reg &= ~0x0001; + phy_write(phy_data->phydev, 0x1c, 0x8000 | 0x7c00 | reg); + + /* Power up SerDes */ + reg = phy_read(phy_data->phydev, 0x00); + phy_write(phy_data->phydev, 0x00, reg & ~0x00800); + + phy_data->phydev->supported = PHY_GBIT_FEATURES; + phy_data->phydev->supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause; + phy_data->phydev->advertising = phy_data->phydev->supported; + + netif_dbg(pdata, drv, pdata->netdev, + "BelFuse PHY quirk in place\n"); + + return true; +} + static void xgbe_phy_external_phy_quirks(struct xgbe_prv_data *pdata) { + if (xgbe_phy_belfuse_phy_quirks(pdata)) + return; + if (xgbe_phy_finisar_phy_quirks(pdata)) return; } @@ -1027,37 +1102,6 @@ static bool xgbe_phy_check_sfp_mod_absent(struct xgbe_phy_data *phy_data) return false; } -static bool xgbe_phy_belfuse_parse_quirks(struct xgbe_prv_data *pdata) -{ - struct xgbe_phy_data *phy_data = pdata->phy_data; - struct xgbe_sfp_eeprom *sfp_eeprom = &phy_data->sfp_eeprom; - - if (memcmp(&sfp_eeprom->base[XGBE_SFP_BASE_VENDOR_NAME], - XGBE_BEL_FUSE_VENDOR, XGBE_SFP_BASE_VENDOR_NAME_LEN)) - return false; - - if (!memcmp(&sfp_eeprom->base[XGBE_SFP_BASE_VENDOR_PN], - XGBE_BEL_FUSE_PARTNO, XGBE_SFP_BASE_VENDOR_PN_LEN)) { - phy_data->sfp_base = XGBE_SFP_BASE_1000_SX; - phy_data->sfp_cable = XGBE_SFP_CABLE_ACTIVE; - phy_data->sfp_speed = XGBE_SFP_SPEED_1000; - if (phy_data->sfp_changed) - netif_dbg(pdata, drv, pdata->netdev, - "Bel-Fuse SFP quirk in place\n"); - return true; - } - - return false; -} - -static bool xgbe_phy_sfp_parse_quirks(struct xgbe_prv_data *pdata) -{ - if (xgbe_phy_belfuse_parse_quirks(pdata)) - return true; - - return false; -} - static void xgbe_phy_sfp_parse_eeprom(struct xgbe_prv_data *pdata) { struct xgbe_phy_data *phy_data = pdata->phy_data; @@ -1076,9 +1120,6 @@ static void xgbe_phy_sfp_parse_eeprom(struct xgbe_prv_data *pdata) phy_data->sfp_tx_fault = xgbe_phy_check_sfp_tx_fault(phy_data); phy_data->sfp_rx_los = xgbe_phy_check_sfp_rx_los(phy_data); - if (xgbe_phy_sfp_parse_quirks(pdata)) - return; - /* Assume ACTIVE cable unless told it is PASSIVE */ if (sfp_base[XGBE_SFP_BASE_CABLE] & XGBE_SFP_BASE_CABLE_PASSIVE) { phy_data->sfp_cable = XGBE_SFP_CABLE_PASSIVE;