From patchwork Mon May 21 21:59:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Lendacky X-Patchwork-Id: 917898 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="ulAsI9dY"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qXm90CWzz9s16 for ; Tue, 22 May 2018 08:01:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754089AbeEUWBL (ORCPT ); Mon, 21 May 2018 18:01:11 -0400 Received: from mail-by2nam01on0063.outbound.protection.outlook.com ([104.47.34.63]:59825 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754125AbeEUV7v (ORCPT ); Mon, 21 May 2018 17:59:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gaxiUdT4O7VuNho2XoBxPanVv0R/TmbS9A2Z+ARP76g=; b=ulAsI9dY+JLMXKCsNoZ6jznrrtPRGlhTebSRChBE8UyHxixOY9MqEg2NwwtQzSI2b+VzRMptxXKvCxgpy3i5AJMpEtPKvolzANul3VeOGUrDyV9zCI2TN6+iwx2IaETfFbAtAgfmJE7eSk6SvO4es0jLA59Se1e25e+8v6ISa84= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.77.1) by SN1PR12MB0175.namprd12.prod.outlook.com (2a01:111:e400:5143::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Mon, 21 May 2018 21:59:49 +0000 From: Tom Lendacky Subject: [PATCH net-next 09/12] amd-xgbe: Always attempt link training in KR mode To: netdev@vger.kernel.org Cc: David Miller Date: Mon, 21 May 2018 16:59:46 -0500 Message-ID: <20180521215946.8135.2887.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20180521215818.8135.83100.stgit@tlendack-t1.amdoffice.net> References: <20180521215818.8135.83100.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0501CA0108.namprd05.prod.outlook.com (2603:10b6:803:42::25) To SN1PR12MB0175.namprd12.prod.outlook.com (2a01:111:e400:5143::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN1PR12MB0175; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0175; 3:a/96Z97RKhURky0H2axSs+O+2VM2ORZr9XsYSGvX/pL6HTjyrBKKuw5FQb0vCiEMaP+ijKNjCNWA53c1VTtDnWHtLq4LewOQRTGZN2HlgQ7O+iKKLwf+a1VVwXN9BgbxFvJ9PkBjoxjebmyFTOVv0WIkJT9mOy+uSKtTA/SmhV8E++TS2rsiyYV2FZkrXp9H/c70G+SBIB7DFaa8XhjWNvaDvYI2UBkuOWCCQwsykj5NKLbQghaQGoA22Rtcb4gN; 25:aszIC/8mIymL/uFdpYdcV6KYKalmlaTT/KP4Ecx1iv/4V5Uz0Olvl21WBIxrKVur5Be2WGz+3ldU3RAuYohZrYahPLYswVPvk+fKeRqeGEBzU07AgTCzzw2/Mx1lV6hLh9LUPaaW2rqsj5+Cdr/gUjRq9ZPHxaiT7HIe0RWkPjNXX8wEupNnkbHqtw1nAR+B+Hmevqfvc8uLKVEzmqQR8k26ZDRhrKKFTtUyyLomMaWjDg9yhgayrchPq1sG3NUrZKNPDfjYypiPcwYPaeuf2/yVt4i5pIN/dHF7LC2AdcT2I5Oxvk+d2z4lcUV4JC1WgUrToYgj0l+vM/gFeFbBUQ==; 31:n5xCgv3jUw3Fi90jlJk7hWEjzf6wyKG7Xs6xQO/AiJ9hFGQ4RbkIaD6XZI+bvuG2mN+uo0Scz/f1qFHKLaHWQTpGM23L30b2OOrEeE0ltIa7+joL74kbCPp7we05Y9v2llV0PBycl5AwslQGTapzXqAkITYaQ3+YjI2D44JZUI9oAoJEcNDrxn2YiWIZZZklGIUte9nkdZYhyhhLMuq4P1b9fyBqxpV4LRs34nnSwu0= X-MS-TrafficTypeDiagnostic: SN1PR12MB0175: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0175; 20:nXMkIf3uYWD7k7KVco2XRC5/Jrq1A8yGjsIyrBMsm9A64eIB6GX+EQLegye3wedRLgYJ+Jy82C311Ud4jbRUO5lCGPeRkJFabkqAKPyRDMwjvWtwy6VtXenvaqPvFUZq+GrdRXSO/KwRcQsZkPbBwycOr1Y+1oARpp2L7x367FdL6vYDDRIlT8DDXlMtcmhL+9MICF1UgNdxhm5MWXDr3Mhgws2VHjpaqMdw0N7+FmKtNAO3cPkHdGXDbSqSTYzHUzNJ/KWHNgiTSgG8Ckw71PErV8DFd89jogRjuOyqZbf957NKzwhFxzWsnZmYba284T/U3U/olCtdu/lHjMXLWcW8piZTWi8KHO8MSm2Nt2VItD5ZrlTyjmztQoMcdpelBdAVq9lVyEqUrNj+aqG9RL6nlzTf40Q0IziWDSMl0yb/PUCCU7F9xLB2QQV+JpjjTtsJbQTVKubBmQ2zUEw+eZKa6+hCktzMcwy9Nske9Q3Wy/au5Gop3k0S5i1IHhLG; 4:Qf2eCnMHmOmEvlqUkxCCHCL1kH392oCcRCRe6v4toDL+RPDM72rFk1R7cOHrxA6eTzoKsQECKyQ10qEPUo8hQOiczFHzCyv/TVQ47ZfOP8W4QFy2fGA0wMxTaV3KgJl+ZnBTp0RMx9sykcfPMQKVDTasXGteyNxlHQbFYI1bPS7qcwMnAh0WuaZapPGatYuEGH2RpWNxLeGuHzzbZN6sEAnJGTm2murSbEnwxIVSPBzVV6SksD6EIFSIZcWb75uxnUCmswqRuzCJT3Z0rTUlcUukHeC9hZ4BT8uweDcKH2XlRjV0+YwyRrwZTKNJg1/j X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:SN1PR12MB0175; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB0175; X-Forefront-PRVS: 06793E740F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(376002)(39380400002)(39860400002)(366004)(189003)(199004)(16526019)(186003)(476003)(11346002)(55016002)(486006)(68736007)(76176011)(2486003)(53416004)(7696005)(23676004)(52116002)(59450400001)(26005)(386003)(6506007)(105586002)(8936002)(86362001)(58126008)(230700001)(2906002)(106356001)(8676002)(81166006)(316002)(956004)(69596002)(446003)(81156014)(9686003)(50466002)(97746001)(4326008)(97736004)(305945005)(478600001)(72206003)(3846002)(6116002)(1076002)(103116003)(2351001)(66066001)(2361001)(6916009)(47776003)(53936002)(5660300001)(6666003)(7736002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0175; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BSN1PR12MB0175=3B23=3A6X8w?= =?utf-8?q?9JrgIy/Mgx4rDaIy1GpcuZn/kV18v3H585PV+haXag7xD16qFxvhLSEC?= =?utf-8?q?nrnRzCcNOQzK7aoFQCpq9VvGorBUy31WM+VIKZYDQHy8LVxDSt09QhMu?= =?utf-8?q?deqqlDYNHGFZ2P0wWIrwF4C+O8ozWtFsdX4FHv0uomzc8II2ylg25Lp2?= =?utf-8?q?0nBic5cT/uNdM+X6Lin9TSSLAMt4IQWjvVypZYtgEV35hdw8ce7yMdQo?= =?utf-8?q?qXz8VpvGvB0O+4JiKYUTZ9IBPsn8n8UGayAAPxOp3VgfdqQp33F505XD?= =?utf-8?q?4lHUlBTp7Qsp76qvFXI0+9s//rYnK5RkZKx8JaVSzaI0MFN8q6Eehtxh?= =?utf-8?q?fb9qLmCdZbUd9ySaBtcvbKXEArw74X8BKCUOwVebRkNK+6KM0gMq5NB7?= =?utf-8?q?EvNOQiSheaZJqEXaDiqzDdqugt6SNLxQG6gWqd7UrrntYUBhLtKM8oR3?= =?utf-8?q?cbqUpr85zseFb6zhKO/91adssLucDdfEIEgEiFn5+2ZlNyRefy+t2WMJ?= =?utf-8?q?YjDcW5EiVrFx5eXzwaXxx3KlLaULvQoCiXbBHZwomuS9EjYQAW4K39MH?= =?utf-8?q?E5F3NEVwGp1Fd/czTKAKQyRRdGrTGRxYcjDPIWDcMPd70s0/KBvIuwSc?= =?utf-8?q?uNegHJ5L8joRJyVu3kJpXenIK0AwbfaO7oqJr0KocuqtzKgad3kbPw8y?= =?utf-8?q?eKGMJeD5ShCJ9ql2XEIaYhm7NO7NI5evvsvm33NkhmlgazvWrbdaWSoW?= =?utf-8?q?Iirs9L3bJazQ0DjyzDyrmgy9k4S9HO8J/7I4hzAWzU/OFhLIV+gflUpj?= =?utf-8?q?rJl550EjGInBufE/JjF7DaQ9w8x91KnnmdFwKuILJK3RkABAj7R058MZ?= =?utf-8?q?I79kktrre3nsW5meSB9AYswmMCGhb5g+DMUL9Ej8T5pWUSXi2BWmhY7I?= =?utf-8?q?lJi+nSyIFMCMqI3+UdlnMk0ohX9ivRwDfuCcnf1R9nEX8vtbCVxfNNKe?= =?utf-8?q?krHyk7PjQb3i84DCDUA6IrUkvei9Xmbihl8bBu3gnAUhEQTlUcZc7s6e?= =?utf-8?q?rPK2E6s02J/BLej2g7rfw3qeyv4xuJgvIdgqKlwUNkXgJGNc95MBMx+f?= =?utf-8?q?4gtoG5ytuzptZUFLL3Ab+VEcR1/SHUOXrFhzBt3/psIS2hmClL/+PKwk?= =?utf-8?q?MvVu/Z6/VQBoZIKx/L3LrCEGcrspVXX29p8dcLMXCaBMv2OgNW82wZCI?= =?utf-8?q?O2BZWdkVLwydpbs89Vjo9/PMimokV8JoXPEFeg41X9QL4mrk88V4KN5H?= =?utf-8?q?4Y7Vyp7kXdfmmawhT4gschOynuojx6N0lBnyJ3HfaacmO+b0vCuLKMSl?= =?utf-8?q?HLkxaCD6ag+nMdvawfzJfAp7G9dAmfNzdLzJITjX0kIUsjDt7e0WmBAE?= =?utf-8?q?TPBvrIN2+i1v7oTe4w=3D=3D?= X-Microsoft-Antispam-Message-Info: dyUke6YexjnjlU/0GLybpPLRWlnhZbXinRjJI/SCm/6G8l2mcI1QpqrvpI9pfT5e84tF08iSY3bJLeEwfbn4L0hmKhgevvp1y+pYBhGbjiJoXD4dpxosf1gKW7iAMh8vy4TkHwe7tDlDn1ttYVlooy3kCKvDshagG6p6NhUWaQM6I6cE8clTUz+ySBbRmX9H X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0175; 6:oSuu4T4EFSB9qaV3P8ipEJPzwJP99mCIvd2ijBIO10Iepktm/ucMKsi++jbTRDLamZImiugaweCdLgDQHfCQT5G6ERzYZGirXMCln17qtzwA/MIW2FQEY7hi1Kpic2x3WoK1di3MN9fWuUMXJrKhluf4OgxT8cUk+7OmmqgeZbyK1dobW3NKANHN4BLLzwizq5nirj1DlEblKiWnVJnUgNsWQztkxc6YnFC/AcIZLkKo5wZftM7A5eH30k8IxUCoN0L38SmUo5HyZhxfw2NMv0LtIe1enkOlofPuMIDLr68SRv5bjEs2JY+PtUj4HhaL5H5CfMMYAi4BtPBn8aLlNMhg6L/3zLJSw5q5Oqpgm6Z3HV0YcQnL0QPry63ENdcnKKxvq9zCoXc7Bm7+BNYlOHSD7s0b+fjV1ODxip86sxaXmaUhSNudoY7aip9oYusDHuIsjnmNaIanKyyKcvnMvw==; 5:9izTcfDdIcQ1nqRYRv+1b68KI8/0vsBzuEknmUcEHFakWvwZatF44HoxBns77gOxdmvcSdQsVCykRiGK/LPxB98G7ubzT9pE6iGa3ftMZeCaVo7LuOggzSf70fi12eAV6WqcRCl4MuKOlPjcLiSL1i00bUr8DCTdXtszs3Om7MA=; 24:MvIl2m+He/5sCDONGb7t8vv+eg5kWPFoFsjlL6Q2F3UioaC/MDX0ehO7ZSD8DVh7UKopa5nan2LOyXPmQRatMgpalHbY8kjcGp9RTs9png0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0175; 7:iRlvNjS+Z7ld8TCdROdcU6mDmOO3cR0/eSgaBK4Ogih3QB+lttybKI9gBrpY0gXBu9+DHTEbRjAErANueKwF4QmFpT67MePhjNfOSdZLDGaLHq53J/th1bg1exPuAwtNkB+MCVKggIRyrfEs2E3qLbBqsg/mKGSewmx7+z6Uej+8WLXdc7pr9cP2YaAV0ZT+s7xu0DCNrtnZfWqL0P/Ox1V8Ird5CTT6cRQx+6WfSwuC87c+GFEQmFOwQZ7uMQXf; 20:2Ak8I7dtG9nlIK+DIV+a3WxL/GvcFIWZaybtp0i4M1HwMabm9GV0xxvbhY7fTSe4JhJdQy0KLasgtfDtSOh2+NJDtEryQcTQYZqbVmP2mgJYyh9yW4SAWBPD/lWtvIxrRe8RiO3WT9u3xpVHWBNMpCdNnLYx/e+BOjCxmNROqGUYDjlxUI3jQfdEL6ubFFQhEjEVaoJQw440rzne6QRz3PvQ+8bIP8/G8y0tc0LmysdIscK8Ok9+BzCe8pCv29S6 X-MS-Office365-Filtering-Correlation-Id: 55216180-fae8-493e-b1b5-08d5bf662ca5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2018 21:59:49.8012 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55216180-fae8-493e-b1b5-08d5bf662ca5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0175 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Link training is always attempted when in KR mode, but the code is structured to check if link training has been enabled before attempting to perform it. Since that check will always be true, simplify the code to always enable and start link training during KR auto-negotiation. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 69 +++++++---------------------- 1 file changed, 16 insertions(+), 53 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c index 9c39c72..450b89c 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c @@ -216,31 +216,8 @@ static void xgbe_an_clear_interrupts_all(struct xgbe_prv_data *pdata) xgbe_an37_clear_interrupts(pdata); } -static void xgbe_an73_enable_kr_training(struct xgbe_prv_data *pdata) -{ - unsigned int reg; - - reg = XMDIO_READ(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL); - - reg |= XGBE_KR_TRAINING_ENABLE; - XMDIO_WRITE(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL, reg); -} - -static void xgbe_an73_disable_kr_training(struct xgbe_prv_data *pdata) -{ - unsigned int reg; - - reg = XMDIO_READ(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL); - - reg &= ~XGBE_KR_TRAINING_ENABLE; - XMDIO_WRITE(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL, reg); -} - static void xgbe_kr_mode(struct xgbe_prv_data *pdata) { - /* Enable KR training */ - xgbe_an73_enable_kr_training(pdata); - /* Set MAC to 10G speed */ pdata->hw_if.set_speed(pdata, SPEED_10000); @@ -250,9 +227,6 @@ static void xgbe_kr_mode(struct xgbe_prv_data *pdata) static void xgbe_kx_2500_mode(struct xgbe_prv_data *pdata) { - /* Disable KR training */ - xgbe_an73_disable_kr_training(pdata); - /* Set MAC to 2.5G speed */ pdata->hw_if.set_speed(pdata, SPEED_2500); @@ -262,9 +236,6 @@ static void xgbe_kx_2500_mode(struct xgbe_prv_data *pdata) static void xgbe_kx_1000_mode(struct xgbe_prv_data *pdata) { - /* Disable KR training */ - xgbe_an73_disable_kr_training(pdata); - /* Set MAC to 1G speed */ pdata->hw_if.set_speed(pdata, SPEED_1000); @@ -278,9 +249,6 @@ static void xgbe_sfi_mode(struct xgbe_prv_data *pdata) if (pdata->kr_redrv) return xgbe_kr_mode(pdata); - /* Disable KR training */ - xgbe_an73_disable_kr_training(pdata); - /* Set MAC to 10G speed */ pdata->hw_if.set_speed(pdata, SPEED_10000); @@ -290,9 +258,6 @@ static void xgbe_sfi_mode(struct xgbe_prv_data *pdata) static void xgbe_x_mode(struct xgbe_prv_data *pdata) { - /* Disable KR training */ - xgbe_an73_disable_kr_training(pdata); - /* Set MAC to 1G speed */ pdata->hw_if.set_speed(pdata, SPEED_1000); @@ -302,9 +267,6 @@ static void xgbe_x_mode(struct xgbe_prv_data *pdata) static void xgbe_sgmii_1000_mode(struct xgbe_prv_data *pdata) { - /* Disable KR training */ - xgbe_an73_disable_kr_training(pdata); - /* Set MAC to 1G speed */ pdata->hw_if.set_speed(pdata, SPEED_1000); @@ -314,9 +276,6 @@ static void xgbe_sgmii_1000_mode(struct xgbe_prv_data *pdata) static void xgbe_sgmii_100_mode(struct xgbe_prv_data *pdata) { - /* Disable KR training */ - xgbe_an73_disable_kr_training(pdata); - /* Set MAC to 1G speed */ pdata->hw_if.set_speed(pdata, SPEED_1000); @@ -425,6 +384,12 @@ static void xgbe_an73_set(struct xgbe_prv_data *pdata, bool enable, { unsigned int reg; + /* Disable KR training for now */ + reg = XMDIO_READ(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL); + reg &= ~XGBE_KR_TRAINING_ENABLE; + XMDIO_WRITE(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL, reg); + + /* Update AN settings */ reg = XMDIO_READ(pdata, MDIO_MMD_AN, MDIO_CTRL1); reg &= ~MDIO_AN_CTRL1_ENABLE; @@ -522,21 +487,19 @@ static enum xgbe_an xgbe_an73_tx_training(struct xgbe_prv_data *pdata, XMDIO_WRITE(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_FECCTRL, reg); /* Start KR training */ - reg = XMDIO_READ(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL); - if (reg & XGBE_KR_TRAINING_ENABLE) { - if (pdata->phy_if.phy_impl.kr_training_pre) - pdata->phy_if.phy_impl.kr_training_pre(pdata); + if (pdata->phy_if.phy_impl.kr_training_pre) + pdata->phy_if.phy_impl.kr_training_pre(pdata); - reg |= XGBE_KR_TRAINING_START; - XMDIO_WRITE(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL, - reg); + reg = XMDIO_READ(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL); + reg |= XGBE_KR_TRAINING_ENABLE; + reg |= XGBE_KR_TRAINING_START; + XMDIO_WRITE(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL, reg); - netif_dbg(pdata, link, pdata->netdev, - "KR training initiated\n"); + netif_dbg(pdata, link, pdata->netdev, + "KR training initiated\n"); - if (pdata->phy_if.phy_impl.kr_training_post) - pdata->phy_if.phy_impl.kr_training_post(pdata); - } + if (pdata->phy_if.phy_impl.kr_training_post) + pdata->phy_if.phy_impl.kr_training_post(pdata); return XGBE_AN_PAGE_RECEIVED; }