From patchwork Sun May 13 09:54:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jian-Hong Pan X-Patchwork-Id: 912517 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=g.ncu.edu.tw Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=g.ncu.edu.tw header.i=@g.ncu.edu.tw header.b="K1obxIM/"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40kK2J6vYlz9s28 for ; Sun, 13 May 2018 19:55:20 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751295AbeEMJzI (ORCPT ); Sun, 13 May 2018 05:55:08 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:42064 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbeEMJzG (ORCPT ); Sun, 13 May 2018 05:55:06 -0400 Received: by mail-pl0-f68.google.com with SMTP id u6-v6so5690859pls.9 for ; Sun, 13 May 2018 02:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=g.ncu.edu.tw; s=google; h=from:to:cc:subject:date:message-id; bh=m7iw/FTQWqm2t9AyvEwTTxR21OlrwIZeJ4/l1FUN1nk=; b=K1obxIM/JseptVLS8amK7HUejelhVfkI6SQAJFBe2Uh4gwizSsisTfT4cv+P/90mOj K193alxhmCUIh21Sp34oLkdsZg5VQMYCI2S7oYzVmwhvyiXgZbgLpSwxdJ3JlowQdB6K 7hoX5KHgRDy96nJAidRcUu2Z0mKmcRW7ejCoE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=m7iw/FTQWqm2t9AyvEwTTxR21OlrwIZeJ4/l1FUN1nk=; b=B4rDPWdw03GU8aC30ojBOXpmFSL7BMh+AVp567BWPCYN7bX/Rz7xw1LQCmkUmm0cgl jEoZhIT87aHmrEttoIwiBiT7cGQ11ZUMY4yWBKEIyKo1V0d1dmg+L9nHNz5nSFVSrySd F5/ffsXW1d327lJWKwarTEE1OAr1u7GnykQLe74HZTzzoo6lHBZnZbJIdYgzmx4wEdDq Km9z9utgt7XjcdE2mvMz5D/d1dGPkWW4XxfOoX4EKQBWj83iFuER9cQuay07yXXhozXc guLm980VGWDeWSsNMsu54aEEyWvXZhh0D0YgPFKWx95IIdha/Gf1fM0oRTNCOZOgIq8y swgQ== X-Gm-Message-State: ALKqPwf4/K19dNQgYDhP04XlJszxhxieUVjKqY9AF/ndaMqGqAr86vuv cmem+gGQlHQn9yfMoZXPoWO/CQ== X-Google-Smtp-Source: AB8JxZrDt8EGrBrvYMGKV3Zsn2TOQuuqiy83e02HiCNtWg9noCU2G6bOMEgWy830mXbPFTpp8AYKcg== X-Received: by 2002:a17:902:8ec4:: with SMTP id x4-v6mr5406891plo.370.1526205306189; Sun, 13 May 2018 02:55:06 -0700 (PDT) Received: from starnight.local ([150.116.252.222]) by smtp.gmail.com with ESMTPSA id t24-v6sm17966902pfj.75.2018.05.13.02.55.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 May 2018 02:55:05 -0700 (PDT) From: Jian-Hong Pan To: Philippe Ombredanne , Greg Kroah-Hartman , Thomas Gleixner , Kate Stewart , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jian-Hong Pan Subject: [RFC PATCH] net: Remove a confusing comment of macro SIOCDEVPRIVATE Date: Sun, 13 May 2018 17:54:58 +0800 Message-Id: <20180513095458.16148-1-starnight@g.ncu.edu.tw> X-Mailer: git-send-email 2.17.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I have been reading the NET related header files recently. I found there is a macro "#define SIOCDEVPRIVATE 0x89F0" defined in include/uapi/linux/sockios.h which is useful for private controls of net devices. When I read this section: /* Device private ioctl calls */ /* * These 16 ioctls are available to devices via the do_ioctl() device * vector. Each device should include this file and redefine these names * as their own. Because these are device dependent it is a good idea * _NOT_ to issue them to random objects and hope. * * THESE IOCTLS ARE _DEPRECATED_ AND WILL DISAPPEAR IN 2.5.X -DaveM */ I notice there is a string in the comment: "THESE IOCTLS ARE _DEPRECATED_ AND WILL DISAPPEAR IN 2.5.X -DaveM" which makes me confused. Because, there are still a lot of devices or subsystems using this macro, for example, ethernet, appletalk, usb/rtl8150 ..., etc. Therefore, I make this patch to remove the confusing comment. Signed-off-by: Jian-Hong Pan --- include/uapi/linux/sockios.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h index d393e9ed3964..c166f8c6b20f 100644 --- a/include/uapi/linux/sockios.h +++ b/include/uapi/linux/sockios.h @@ -139,8 +139,6 @@ * vector. Each device should include this file and redefine these names * as their own. Because these are device dependent it is a good idea * _NOT_ to issue them to random objects and hope. - * - * THESE IOCTLS ARE _DEPRECATED_ AND WILL DISAPPEAR IN 2.5.X -DaveM */ #define SIOCDEVPRIVATE 0x89F0 /* to 89FF */