| Message ID | 20180513095458.16148-1-starnight@g.ncu.edu.tw |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [RFC] net: Remove a confusing comment of macro SIOCDEVPRIVATE | expand |
diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h index d393e9ed3964..c166f8c6b20f 100644 --- a/include/uapi/linux/sockios.h +++ b/include/uapi/linux/sockios.h @@ -139,8 +139,6 @@ * vector. Each device should include this file and redefine these names * as their own. Because these are device dependent it is a good idea * _NOT_ to issue them to random objects and hope. - * - * THESE IOCTLS ARE _DEPRECATED_ AND WILL DISAPPEAR IN 2.5.X -DaveM */ #define SIOCDEVPRIVATE 0x89F0 /* to 89FF */
I have been reading the NET related header files recently. I found there is a macro "#define SIOCDEVPRIVATE 0x89F0" defined in include/uapi/linux/sockios.h which is useful for private controls of net devices. When I read this section: /* Device private ioctl calls */ /* * These 16 ioctls are available to devices via the do_ioctl() device * vector. Each device should include this file and redefine these names * as their own. Because these are device dependent it is a good idea * _NOT_ to issue them to random objects and hope. * * THESE IOCTLS ARE _DEPRECATED_ AND WILL DISAPPEAR IN 2.5.X -DaveM */ I notice there is a string in the comment: "THESE IOCTLS ARE _DEPRECATED_ AND WILL DISAPPEAR IN 2.5.X -DaveM" which makes me confused. Because, there are still a lot of devices or subsystems using this macro, for example, ethernet, appletalk, usb/rtl8150 ..., etc. Therefore, I make this patch to remove the confusing comment. Signed-off-by: Jian-Hong Pan <starnight@g.ncu.edu.tw> --- include/uapi/linux/sockios.h | 2 -- 1 file changed, 2 deletions(-)