diff mbox series

[V3] net/netlink: make sure the headers line up actual value output

Message ID 20180504030920.ztpb2axpygrszpvh@debian
State Accepted, archived
Delegated to: David Miller
Headers show
Series [V3] net/netlink: make sure the headers line up actual value output | expand

Commit Message

Bo YU May 4, 2018, 3:09 a.m. UTC 
Making sure the headers line up properly with the actual value output of the command
`cat /proc/net/netlink`

Before the patch:
<sk       Eth Pid    Groups   Rmem     Wmem     Dump     Locks     Drops     Inode
<ffff8cd2c2f7b000 0   909    00000550 0        0        0 2        0        18946

After the patch:
>sk               Eth Pid        Groups   Rmem     Wmem     Dump  Locks    Drops    Inode
>0000000033203952 0   897        00000113 0        0        0     2        0        14906

Signed-off-by: Bo YU <tsu.yubo@gmail.com>
---
Changes in V3:
  - Drop external website for commit message
  - Modify the commit accroding to DavidM
Changes in V2:
  - Do not break the code line

 net/netlink/af_netlink.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--
2.11.0

Comments

David Miller May 4, 2018, 5:02 p.m. UTC | #1 
From: YU Bo <tsu.yubo@gmail.com>
Date: Thu, 3 May 2018 23:09:23 -0400

> Making sure the headers line up properly with the actual value output
> of the command
> `cat /proc/net/netlink`
> 
> Before the patch:
> <sk Eth Pid Groups Rmem Wmem Dump Locks Drops Inode
> <ffff8cd2c2f7b000 0 909 00000550 0 0 0 2 0 18946
> 
> After the patch:
>>sk Eth Pid Groups Rmem Wmem Dump Locks Drops Inode
>>0000000033203952 0 897 00000113 0 0 0 2 0 14906
> 
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>

Applied, but why did you send this V3 to the list two times?

Thank you.
Bo YU May 5, 2018, 1:54 a.m. UTC | #2 
Hi,
On Fri, May 04, 2018 at 01:02:23PM -0400, David Miller wrote:
>From: YU Bo <tsu.yubo@gmail.com>
>Date: Thu, 3 May 2018 23:09:23 -0400
>
>> Making sure the headers line up properly with the actual value output
>> of the command
>> `cat /proc/net/netlink`
>>
>> Before the patch:
>> <sk Eth Pid Groups Rmem Wmem Dump Locks Drops Inode
>> <ffff8cd2c2f7b000 0 909 00000550 0 0 0 2 0 18946
>>
>> After the patch:
>>>sk Eth Pid Groups Rmem Wmem Dump Locks Drops Inode
>>>0000000033203952 0 897 00000113 0 0 0 2 0 14906
>>
>> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
>
>Applied, but why did you send this V3 to the list two times?
Thanks a lot. When sent the email,i encounter networking issue and not sure
send to the list.Sorry for making noise.
>
>Thank you.
diff mbox series

Patch

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 55342c4d5cec..2e2dd88fc79f 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2606,13 +2606,13 @@  static int netlink_seq_show(struct seq_file *seq, void *v)
 {
 	if (v == SEQ_START_TOKEN) {
 		seq_puts(seq,
-			 "sk       Eth Pid    Groups   "
-			 "Rmem     Wmem     Dump     Locks     Drops     Inode\n");
+			 "sk               Eth Pid        Groups   "
+			 "Rmem     Wmem     Dump  Locks    Drops    Inode\n");
 	} else {
 		struct sock *s = v;
 		struct netlink_sock *nlk = nlk_sk(s);

-		seq_printf(seq, "%pK %-3d %-6u %08x %-8d %-8d %d %-8d %-8d %-8lu\n",
+		seq_printf(seq, "%pK %-3d %-10u %08x %-8d %-8d %-5d %-8d %-8d %-8lu\n",
 			   s,
 			   s->sk_protocol,
 			   nlk->portid,