From patchwork Tue May 1 17:32:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Manlunas, Felix" X-Patchwork-Id: 907147 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cavium.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="nncwuHyJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40b7l71vFRz9s1w for ; Wed, 2 May 2018 03:32:19 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755997AbeEARcQ (ORCPT ); Tue, 1 May 2018 13:32:16 -0400 Received: from mail-dm3nam03on0070.outbound.protection.outlook.com ([104.47.41.70]:4960 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755035AbeEARcP (ORCPT ); Tue, 1 May 2018 13:32:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fVVVK0nSa3GC36v9nfUaNtzDkoRyMuaQi9MzbMp5nUs=; b=nncwuHyJZHeDMiJkQyBHbb6VCchMjxhusUEHGaiwSqVhbH5+Ce97amcT27i8d5zQeWfaI0eAiLvgT/rHWhqvf1Kev37WeY3d6C5IwvNf33z+1v6JB85r2N5Wfg8dRB4wZNdfFsDEnAv7NBHgEw0C4YANpoCg7nrtmqUj03Y+C/A= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Manlunas@cavium.com; Received: from localhost (50.233.148.156) by DM6PR07MB4220.namprd07.prod.outlook.com (2603:10b6:5:bd::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.18; Tue, 1 May 2018 17:32:13 +0000 Date: Tue, 1 May 2018 10:32:10 -0700 From: Felix Manlunas To: davem@davemloft.net Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com, prasad.kanneganti@cavium.com Subject: [PATCH net-next] liquidio VF: indicate that disabling rx vlan offload is not allowed Message-ID: <20180501173210.GA5083@felix-thinkpad.cavium.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: BN6PR11CA0038.namprd11.prod.outlook.com (2603:10b6:404:4b::24) To DM6PR07MB4220.namprd07.prod.outlook.com (2603:10b6:5:bd::29) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB4220; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4220; 3:gblMO8hOAap8UjAUoNfkBNlNUCW/LZ3gujrr5KrNpibCxaCuAeWt4Y42THzmFnirIeChihFDYRURLfEC4/LZR5zUvV8RrsRccTfcxDb6zvzjbgOisyORXLduYXJdHPQ13AN5Icq8i6zQPtupTQZXdX/v3o1TgjA32HkMs+HK/S3f5Oqha2Fqiir6QCQaZnaJwvYKmMyNIUigXg7fomD5sE4gtlEUAhzgNJFHTuYu6e9EMTXKwqedGMN+tuP7iWKP; 25:7pcslA3aEIHzBROhUAjF8XQXEHIh5jtvs4UhuMOtQTeJ0uXaFtrQqEyjKpgK/2Bb5+NFDAhs/rI/RUd9FfR3qWyqLRKtleYEsl/XRlZIRuIt9EyRFXEJDu1M6Z7Uy9VvUSIt6ePQokb4zjP4aYWT6gLyYaknGqJ7oxRDtXSn0uq3h5H0kTImPYqgf60su13QMTEKWGhx9BPA5HeVFHWTL0Zj6XZi8e2apTfSXy7DxvenhSOZQsmm9No++C721OsW32GQ2aiLxBlZK5HnKLcp/nTYR9Gcb9WoXlhi82tcRnkWr13M+AJ8F5xzUPe38ITjTFhWJCASLxJHW8b7GTz/rw==; 31:Mg7wWDsKaOdrlfFTxBV8aK9U776BJlw6yPJL1zQzhmavWaAmScJSOl016y668UwyinaeU1gWgXFIGkKxMyWsmuApDABUMg3NqPSDh6kbvQ+MCd169Nv5XfQXdqs0PEqNy7p/iA5EDwGA81v97HmiqK33O/uBeRUhRIx9QxR6NkN8YY9//LZvTua1hO0TG0hs6NwDs9/DOu9c+R0GOQ8ZkrBIlf0mPS/gHUgpC33nfHQ= X-MS-TrafficTypeDiagnostic: DM6PR07MB4220: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4220; 20:T22Z6n/odIi0upQq0XdR/sx6gOuPjmstz9ktQBfWXUKmOdLPGD3bV35Lrt47VgtLmHr+lHXjBJylbnFQHqPlyAnZIJn929GwfDC2bD9zcXTluClE9JlS6apO1AlWZjfENTeisacR9/kpM2KM1e+t05dcnzlOgYUdTcV4nXAPddx2TBRzGY/dkKXwRHWy4Dml8eG7Ij8lBGximll4ZkTm3S2miB28P4+HoKjZTXVipYPpVoLq8yRyXged+vFqVoD2QpizXmc6XiCjy5s7WAnE52oHn/k5+Kegtsd4De8scxOfs/SJHL6JipR943Exe6+NlKArfjt69rsVOYfr04puLHcLXvPRRbb2uvFPPwr/3E8tYY1HjIifQbpbHgLpXuWNZvw4Q/zQfAO2NVf/10NuOCYjNN6Z8rQFDAYklwa2F+YCtBdjIK3heibfoJUW1dWOv/4aDpjkeFPe25XhHwlzf8jQt5H4hQr2vH/PHJmNnS+Q9y3tVuMOvOk5Y5wQOf9u; 4:+PYRTuqhK6v5W/hw/RtM568hCA9LxFtICmEnkoU41scyw5bMtziw5z1NbWR6hhJy4yBx3rMycxji+EUHfJ0sS4aNKW2qxSTnNUNVxkxG2f+3Jz2CcmPqSmACC0jxdMUoyO8MyDAdFLpU2EOhNh2xZjWNV0tmH+GAgXz7om0tZcg8tlZJKpGusLtgdfxSX/Yo1QzdTRnTtvT+DVc29VouDv82WMqU/LN3+Xwsn4dPE0efR+2kEfTbw1jvq9dd2P6O/qSBVSZrLLZU6KuO8NoPZA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:DM6PR07MB4220; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB4220; X-Forefront-PRVS: 06592CCE58 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(376002)(346002)(366004)(39380400002)(396003)(39860400002)(199004)(189003)(4326008)(66066001)(47776003)(50466002)(478600001)(305945005)(16526019)(6486002)(106356001)(76506005)(186003)(105586002)(476003)(86362001)(956004)(2906002)(44832011)(25786009)(72206003)(486006)(16586007)(81156014)(8676002)(316002)(8936002)(33656002)(81166006)(97736004)(52116002)(58126008)(6496006)(6116002)(3846002)(26005)(23726003)(386003)(1076002)(7736002)(2361001)(107886003)(5660300001)(53936002)(2351001)(68736007)(6916009)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB4220; H:localhost; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4220; 23:1DHbQlrTal7bOI13hs/EEc9DSCFMaudGnLd8bvWcgIqknc3jlyGWsi7tyBqIge4x1ToYeQgM+4cR1ylI134PE08w5tfUniVyolgPliSc4v0wKBEBwJuWPOVkUMt2ZOs1jS3pi4DbXnc8kmJ6r6UDzE7sVDomEYXvXuL9u5N20DWAA9yk1QocfE+qoLY2VT9ShYKrkx/RHAwtXzZuw+SplqyM5I7+AdQbdyx/EQSipK2O6YzAAUKuvt32YXalkdXVaZ+bvfqjLyEj1T2h2w24LvjFWbPZMeRoyUskv/tnt5lHr0oSeCxe4AoVBwFP8tkwjibG9FJJGGZEmYQBl0uOyNciBPHO+r1nwT8MHZvW8Ii2SBKlnmMkOkpimu3JJKHnDDZvsrbOPDJ9QUeQtrYNre89GpW4F8quNFkN2Z/7D+2WRNT8XgYpSBa1v+21BAfyH/8lxPazxc7CNxbW3AmEAYLjYL2uR0VWONKmZZNF0OXxcPWJ+xUumMyly7BLUDnSH4ccP0dPdX0I5kmy0or8y7Z+MsZaGwUknuDiP5zpwiM12m7oqzwIbfTCg1TAecaI0VYYgpHPgJOGZLLQMm1dgXqeUFqsoUqX1SQgdP3mljDU7W0yyFdaI9DvSy/S5GHfb8qBg0ftaOCcQFeAzD+BmsLKyY5ds1/kGKlDCaR6R4eW3CnAAgv1KoP4rGEFueYX/gdR5GFMKLO1Ux6Naapz6b4aiC7uec2VpCcVw6eTUImlGE/diq+ROiZrab6qffYUaFqNaCqpncXcGy5a7onFbDFe4T61krzEQnRvzOO41JdR4NAkQ3LV8uR0aAYtMhExe8SWMu2xl/byfXmr0H/A4s6Dk1KIqme5a3Idc69gQLKcVuoc8UQZ7e/gAKcvdoDEfkvzD4OH7z4Ph7Br0QU1x0UMa/0KRn8lln9N+u0UAMamXVU03BjsmPGoXuBdvDX3M6KpwbKXQMypyU2T0Ezpat7PvBzCor6KnsYMtwkWZNq1oNCIuFrEZMfNUFp1sHQdV43o8fHRjFnS5Zntcb1+XurdlGZ416+7yg8kKlyIOUrnqbWQrlw9N135Q6AZ5aWfeF7/IRUol6ykLt2MW1VEc3ZDLHnM0pKMtz7QqLvegMjQb3WjL3TW4vtcAKmV0vqaiOUgEbelhY8qJQzFAvDsnTZTZLUx8LR8bVDKpS4pMZga9U6HWwW+KzfBuol9dyksBtfgUYYAp90+7A3joHSBbQ== X-Microsoft-Antispam-Message-Info: NgWs/ghUkfDEMze0sVW4VDUJ3FXhfPa7OfBub/Og8bSbuymlsy1HbUYQ2sAt/51Vmfg3QNBH/9pB4Lqxc+XMXTUh1htQRm18FK699yfwXQnqYdTVlVOL4NZP9Nic6guKQSVPlmiBtZ30R1OqShTT26wJcFfJMCCPxwtUkqmwl59iC3zW11C5qjumeW/kRYT+ X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4220; 6:jJ0357uvSNIBau2mMxdqqC3/CWtw1cY5hIYv6j30tvmIA82dV8Alz16CGLn9x0ld+g5CRU4duZcIpdlxg96GEgAvnjv05HSVhrsT2OoFUiW8HWJyrnGIhHgfIYXgLLct2VSMleuG35/stlN/ql7J6hRlRNqcVptX+2CG56zovGlCJR0P1hGMwNFLVYU5c5MVC0m62pJswDBRt667JrH47qZcFuqmYIYUkdypj2J4D5QZ7c2C3XU5cWHviQ5HY+4kh7/l7vfzm/7hXZ7rGjtD159Becb66uzlDkwOAvu2bcX6ai6a4elWdhrLc1J8Hj0wqq9c0a5feQcM8W56u/1XK3d8UkEKOL5kz6F2WyjxMh5/8d3m4ieJE1FG6VKP3abDYdFE+N1ChRnfbkkV0QCBOwrAhGuI1bxGhn5PXBXGFUyzmoMcFXetj5GxZQ9eGsdGCgMKQeQ7TLUCPKPkufll9w==; 5:28hZEUmp/L2B3yOxre02NNzd4MY+pPs+sMLzYEIKBQS7ny9rvEEM5LoAgj9eVguElG/7MZA5uaY6oBQzt9YAkvjNZV5HVm1Hf/o0M1bsogY1odfatg8hbndUz62QT7wPYvLWdy5JjAdDQOJVMGBMEQqGMe1SRh7zCGNGodiI3eY=; 24:w2HHw8RmLz1Hk3kRaUQOJ0xqHAX6ODLCmZ6qINRIaQ0Npg+81JPfAXhc3wUFxVKTqRIpCu3yvFNgIC7Grh6nWcZD6vxxiFto7658JUewVSk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4220; 7:NMJ5SToNib8trwnGUkiRa2c3q1AXnJ8yfUqaEEaLs1AAJ9n3SIUkDA51TT5eDKBv5yrB4aq6f1fEF9apFIo7/Z0h+pBfnGseNO+N14z2/WF6JYGvvDQPg5MwOgleJBbMvtWS/+9WhVrv7XUdfKeYmA7aHlR+Ctfx5ZG6caj5A6XjmOdPQp15AkzuSjmTBML6gyjx2qn/fScVNjJQrRiZcNVItQSHWB3Y9U0f/nouW70btGLwThIJCkdJo2TedWvv X-MS-Office365-Filtering-Correlation-Id: 8b4b654f-becf-4894-bd0f-08d5af897a21 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2018 17:32:13.4548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8b4b654f-becf-4894-bd0f-08d5af897a21 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4220 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Raghu Vatsavayi NIC firmware does not support disabling rx vlan offload, but the VF driver incorrectly indicates that it is supported. The PF driver already does the correct indication by clearing the NETIF_F_HW_VLAN_CTAG_RX bit in its netdev->hw_features. So just do the same thing in the VF. Signed-off-by: Raghu Vatsavayi Acked-by: Prasad Kanneganti Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c index 08b682b..6295eee 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c @@ -2100,6 +2100,7 @@ static int setup_nic_devices(struct octeon_device *octeon_dev) netdev->features = (lio->dev_capability & ~NETIF_F_LRO); netdev->hw_features = lio->dev_capability; + netdev->hw_features &= ~NETIF_F_HW_VLAN_CTAG_RX; /* MTU range: 68 - 16000 */ netdev->min_mtu = LIO_MIN_MTU_SIZE;