From patchwork Tue Apr 24 13:17:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 903453 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="movnTdsF"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Vkk13526z9rxx for ; Tue, 24 Apr 2018 23:31:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933942AbeDXNRs (ORCPT ); Tue, 24 Apr 2018 09:17:48 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:37945 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933902AbeDXNRe (ORCPT ); Tue, 24 Apr 2018 09:17:34 -0400 Received: by mail-wm0-f68.google.com with SMTP id i3so807001wmf.3; Tue, 24 Apr 2018 06:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=KbtSd2WlqYh0gfixScXroUvvtl5AmbqrDvftGV7pxtc=; b=movnTdsFxT1jKIo4CgvbsdnfUeBAA/JjfXEMCsKiauO1k19cMGzuBOtSAeZrFJrHGO Sv1YD7goMrnhHXM6yVw8wsTTj3QaVNmDWWNv8Xyh9njvFo0CduIrozaJ75qnGZyqbM9L HmSBb32TSfBUSHyCJojQn/zZlwShsn38hWWQbTBeqUrISeD9SIpR1ynz+bgfWYejMvQr EWK+JXrgGYA8L2PvYbjplFz/6UY01jvldjz9vR1pkNyyn9GSgBe8KwsfU7hy1KNqaHDQ QnsajbZRxjomjEwgHcnUGUDyV4uCV+vOHB3Oik6KkPLzHT8odJxrA6Lo/Fo3+Tt7YbuP FEmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KbtSd2WlqYh0gfixScXroUvvtl5AmbqrDvftGV7pxtc=; b=sIxJ2mWaafHssw9pYXjCfLdiwO6a9pm+X2IlCRxbeIbgeViNOzToyDBRgGiKGTy1Yg KZN8UYUkRqIR3cEa6Mlx3GMYVkOLTyIkufffpwtNuBxjkaWtrs2yeSRrcHTa/BwnqOWO fxRO+xE8137UUZLuuMuKT9H14RWYU9cvWzn7++Lk9EIdEFEvAJLhrkSs0ztc6k1miKGn gUoZ7/laRRtyjbxrWWPnshLhNLAy9zfXIhNJWff0leJWfaaIwXKKtawrjFf5hW99xDy5 N7JK6MBQVCi1Q/E3K3ra9a+ir5khOydLA9RN+Ttv0Y+OdnOEgfYsH20UxTbEauoA7lSn 9Y9A== X-Gm-Message-State: ALQs6tDyegAAVF1bljAOiQfhvTbLpGKuAfqx9Z/BJzMHRVF9/IR7AfYZ mgSeVdh2ucgTN9+U+IWjyXRQrsCR5IU= X-Google-Smtp-Source: AIpwx4/SPb1Ae9wynFgVsM1G05DayVx5SyOnvaOLW8fNnhPhP4Zh2oJZTcOyxDUnj0L9PPbo48wQXQ== X-Received: by 10.167.210.135 with SMTP id w7mr16001201edq.53.1524575852631; Tue, 24 Apr 2018 06:17:32 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id l1sm8828942edi.54.2018.04.24.06.17.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:17:32 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , "David S. Miller" , Kunihiko Hayashi , Jassi Brar , Andrew Lunn , netdev@vger.kernel.org Subject: [PATCH] net: ethernet: ave: fix ave_start_xmit()'s return type Date: Tue, 24 Apr 2018 15:17:25 +0200 Message-Id: <20180424131731.4458-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck Acked-by: Kunihiko Hayashi --- drivers/net/ethernet/socionext/sni_ave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c index 0b3b7a460..95625bca1 100644 --- a/drivers/net/ethernet/socionext/sni_ave.c +++ b/drivers/net/ethernet/socionext/sni_ave.c @@ -1360,7 +1360,7 @@ static int ave_stop(struct net_device *ndev) return 0; } -static int ave_start_xmit(struct sk_buff *skb, struct net_device *ndev) +static netdev_tx_t ave_start_xmit(struct sk_buff *skb, struct net_device *ndev) { struct ave_private *priv = netdev_priv(ndev); u32 proc_idx, done_idx, ndesc, cmdsts;