Message ID | 20180418213534.6215-2-aring@mojatatu.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
Series | net: sched: ife: malformed ife packet fixes | expand |
On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring <aring@mojatatu.com> wrote: > We need to record stats for received metadata that we dont know how > to process. Have find_decode_metaid() return -ENOENT to capture this. Agree. > > Signed-off-by: Alexander Aring <aring@mojatatu.com> Reviewed-by: Yotam Gigi <yotam.gi@gmail.com> > --- > net/sched/act_ife.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c > index a5994cf0512b..49b8ab551fbe 100644 > --- a/net/sched/act_ife.c > +++ b/net/sched/act_ife.c > @@ -652,7 +652,7 @@ static int find_decode_metaid(struct sk_buff *skb, struct tcf_ife_info *ife, > } > } > > - return 0; > + return -ENOENT; > } > > static int tcf_ife_decode(struct sk_buff *skb, const struct tc_action *a, > -- > 2.11.0 >
On 19/04/18 01:37 AM, yotam gigi wrote: > On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring <aring@mojatatu.com> wrote: >> We need to record stats for received metadata that we dont know how >> to process. Have find_decode_metaid() return -ENOENT to capture this. > > Agree. > >> >> Signed-off-by: Alexander Aring <aring@mojatatu.com> > > Reviewed-by: Yotam Gigi <yotam.gi@gmail.com> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index a5994cf0512b..49b8ab551fbe 100644 --- a/net/sched/act_ife.c +++ b/net/sched/act_ife.c @@ -652,7 +652,7 @@ static int find_decode_metaid(struct sk_buff *skb, struct tcf_ife_info *ife, } } - return 0; + return -ENOENT; } static int tcf_ife_decode(struct sk_buff *skb, const struct tc_action *a,
We need to record stats for received metadata that we dont know how to process. Have find_decode_metaid() return -ENOENT to capture this. Signed-off-by: Alexander Aring <aring@mojatatu.com> --- net/sched/act_ife.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)