From patchwork Thu Mar 22 22:57:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Ahern X-Patchwork-Id: 889717 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cumulusnetworks.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="AEuLUia+"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 406hsh6vmBz9s0x for ; Fri, 23 Mar 2018 09:58:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863AbeCVW6P (ORCPT ); Thu, 22 Mar 2018 18:58:15 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33973 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751841AbeCVW6N (ORCPT ); Thu, 22 Mar 2018 18:58:13 -0400 Received: by mail-pg0-f67.google.com with SMTP id m15so3870480pgc.1 for ; Thu, 22 Mar 2018 15:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=241uDjhYuiVkHAOQpX/wkL/kLKKM3vqWLulXS44GbQY=; b=AEuLUia+wZ1XeLCl5xdaY8hhpPsRnTLsDTxAdEdCZkx9CybUwKjPD3agAElfn1mMLI e6pQpFxRM8Z5bXtA8dgh+53s8Zpn/LmKtyXrFbBRg+ev5kObAIjpd0AH8BhLQlxJ4UF9 bdGOOtAVNVAGjF9T44ei9Xq+epguBrhKnN1TA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=241uDjhYuiVkHAOQpX/wkL/kLKKM3vqWLulXS44GbQY=; b=OVtQKnP4uERqLRu84LOmzHWw4AcmkOmRuUuYspXbwHAZFc4gF4xhTg0DwWeVXwKTWQ KvU4KDuxFStd6dhYMj/2yHT5jJnDSHNHXsEvfd6ohKiFwX6qcl8bgRAsI+Cvox0LP9yH c5zJhALYKwh76Ee62ViYe9Axz19I4llhNkJKFEcFhotTGOMOGLWxjwOW2LgJPwcqZN0O j/pEXYGe/nuhAh2qUFDUlcrvHS10WBJ413IwgjE2UIBSrfGthz4BMlR7uttrzSIfzg3/ NSD9UyTF3NO8M2+a9BJoJobZbKTWU5BruP3XpmyXQhNW4K1bRmNwt9aGv8A2E5e/z7DG Wy3w== X-Gm-Message-State: AElRT7E3iUNv091nj1NmHEZuzESV1GfZCXNTJimetKVJHS4WvSVTODLW GHzeoP2Ph1JF/09qGgR+JVXXSsHz X-Google-Smtp-Source: AG47ELvqfSOI1porhcIgw7Ljg/cKOx6lePOwBS6wyTgoX2tJULjS+XcPoEMPzZsr0cFRlN2wf1dOXQ== X-Received: by 10.98.51.129 with SMTP id z123mr22049063pfz.132.1521759492409; Thu, 22 Mar 2018 15:58:12 -0700 (PDT) Received: from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com. [216.129.126.126]) by smtp.googlemail.com with ESMTPSA id b78sm15807767pfe.88.2018.03.22.15.58.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Mar 2018 15:58:11 -0700 (PDT) From: David Ahern To: netdev@vger.kernel.org Cc: davem@davemloft.net, roopa@cumulusnetworks.com, shm@cumulusnetworks.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, David Ahern Subject: [PATCH RFC net-next 1/7] net: Fix fib notifer to return errno Date: Thu, 22 Mar 2018 15:57:51 -0700 Message-Id: <20180322225757.10377-2-dsa@cumulusnetworks.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180322225757.10377-1-dsa@cumulusnetworks.com> References: <20180322225757.10377-1-dsa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Notifier handlers use notifier_from_errno to convert any potential error to an encoded format. As a consequence the other side, call_fib_notifiers in this case, needs to use notifier_to_errno to return the error from the handler back to its caller. Signed-off-by: David Ahern --- net/core/fib_notifier.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/core/fib_notifier.c b/net/core/fib_notifier.c index 5ace0705a3f9..14ba52ebe8c9 100644 --- a/net/core/fib_notifier.c +++ b/net/core/fib_notifier.c @@ -21,8 +21,11 @@ EXPORT_SYMBOL(call_fib_notifier); int call_fib_notifiers(struct net *net, enum fib_event_type event_type, struct fib_notifier_info *info) { + int err; + info->net = net; - return atomic_notifier_call_chain(&fib_chain, event_type, info); + err = atomic_notifier_call_chain(&fib_chain, event_type, info); + return notifier_to_errno(err); } EXPORT_SYMBOL(call_fib_notifiers);