From patchwork Fri Dec 22 19:47:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Herbert X-Patchwork-Id: 852549 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quantonium-net.20150623.gappssmtp.com header.i=@quantonium-net.20150623.gappssmtp.com header.b="IUoA5TAL"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3z3JwB1svfz9ryr for ; Sat, 23 Dec 2017 06:48:26 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756578AbdLVTsW (ORCPT ); Fri, 22 Dec 2017 14:48:22 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:37359 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756473AbdLVTsU (ORCPT ); Fri, 22 Dec 2017 14:48:20 -0500 Received: by mail-pl0-f66.google.com with SMTP id s3so13442240plp.4 for ; Fri, 22 Dec 2017 11:48:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantonium-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6+EjW6V+4nFuc4dlrdakJzaTAbCh3oBmQE5rg1uY9is=; b=IUoA5TALr1tNug/wnKJwufZYGc80opGNCDp2Rb600sghERhkosLusdqjVp0Dt97Njb szWhnQOXvLF3P+fk1j5Tn2ptGJUuNwwDucVciNWVIqz0Tk2sj/R53aQaj9vBzt8k9o/i McYwUH0THp25dRazDMyJHaaXeCZhEp6NO51astzmHHwqZJfXFJvbQZWpwxsvOBKuaoJP qMxppkKNiLJhVc36ULGNv732Umpx6PGvSum9rlZRKpiX4x1e4wmWZinJ+mds0/R2nec8 sf7eNDtCL1g1mSw3rJ4dx7L1AmO0PLDQjS1msd25fJxyC1hkrHAWLDZBkvEDyXXRBGie cwQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6+EjW6V+4nFuc4dlrdakJzaTAbCh3oBmQE5rg1uY9is=; b=qn4NKCOCe7c5gBzK2NH6efKswolvcaiNdAu2ZSeg9ezA7pdcNNsiHBlqxo4W32hJ7C EX1fB+LcvarzQyToi5gOOoTfe3oyZmEPhXg5CnTELJi/NMdwcxm50BS7wNFMMc8/zBbt uGp7KRJTXeN9kAu0Cc7jFqvFeEyqeA6WWpCO9NEwTSjSGtJwJtGJf068nkRw7iNaTtaK C1+P2ZS6zJ5hQ+isJi6r20Be6Ku+iibchIGxrkg5z1DTZrUSEXHgRj9iV2FcAslXLh9C 4ChdEChzdPNcwuHq90vXuy1hGrGIxgEqqigFwTEwYHv0vrlUkrm1JbeEWBLQVrYgBT+T 78XA== X-Gm-Message-State: AKGB3mIKwIOribVYUkhOaGHM56jOsNIzhROo9Pjy+yfrEO7Zq49ywf0E uafVzZLN1y5FSHmYoZsjG09zbg== X-Google-Smtp-Source: ACJfBovPBFY0m5mh2LtB6sTj9obYCZEKZY0YSxqazWIXAeoG+fCxq+Wv9DOuAQfktfzCVxYAuX6pRw== X-Received: by 10.84.131.103 with SMTP id 94mr14861193pld.288.1513972099853; Fri, 22 Dec 2017 11:48:19 -0800 (PST) Received: from localhost.localdomain (c-73-162-13-107.hsd1.ca.comcast.net. [73.162.13.107]) by smtp.gmail.com with ESMTPSA id e7sm50080812pfj.44.2017.12.22.11.48.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Dec 2017 11:48:18 -0800 (PST) From: Tom Herbert To: davem@davemloft.net Cc: netdev@vger.kernel.org, dvyukov@google.com, john.fastabend@gmail.com, rohit@quantonium.net, Tom Herbert Subject: [PATCH net-next 2/4] strparser: Call sock_owned_by_user_nocheck Date: Fri, 22 Dec 2017 11:47:53 -0800 Message-Id: <20171222194755.8544-3-tom@quantonium.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171222194755.8544-1-tom@quantonium.net> References: <20171222194755.8544-1-tom@quantonium.net> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org strparser wants to check socket ownership without producing any warnings. As indicated by the comment in the code, it is permissible for owned_by_user to return true. Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages") Reported-by: syzbot Signed-off-by: Tom Herbert --- net/strparser/strparser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/strparser/strparser.c b/net/strparser/strparser.c index c5fda15ba319..1fdab5c4eda8 100644 --- a/net/strparser/strparser.c +++ b/net/strparser/strparser.c @@ -401,7 +401,7 @@ void strp_data_ready(struct strparser *strp) * allows a thread in BH context to safely check if the process * lock is held. In this case, if the lock is held, queue work. */ - if (sock_owned_by_user(strp->sk)) { + if (sock_owned_by_user_nocheck(strp->sk)) { queue_work(strp_wq, &strp->work); return; }