From patchwork Sun Dec 17 16:02:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Gorski X-Patchwork-Id: 849656 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="c1CMEIBQ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3z08920v6pz9s4s for ; Mon, 18 Dec 2017 03:03:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757331AbdLQQDc (ORCPT ); Sun, 17 Dec 2017 11:03:32 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:45359 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757215AbdLQQDT (ORCPT ); Sun, 17 Dec 2017 11:03:19 -0500 Received: by mail-wr0-f193.google.com with SMTP id h1so11918920wre.12 for ; Sun, 17 Dec 2017 08:03:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cHKOb+MRH5zMX2KgeF7i9ex4zIEEdtfK1Zx4hI8sW+c=; b=c1CMEIBQXkmw1zQnyQpXdnXUN7XEoj6rqVrB7mF6JkB1OxVby32HaNn7OHT2mW1vmE BNxS2Xx2tbb5UdDtBBCqyVi1H90FtRUF81LVHrfK2a+Iyc2ZYx/ufCzk/5yuPK65osCO BuHWRJyviBbJvfbSTL98RKyDhqFgh87zpHl15WEYjzydI9nOLia4KPgKhjXbvSCkRr5e MJWjhV99bueiJGGXUec9vAaRMb3giuyRW4PiwvhxUU8x3It/ko8Nola8zU/q6/t606ID L/EP4WXotc7QIaTBS7bm8VQMIQWCHPGnOXq/PYpuYmOWnP7b4vmdEVxN+atQurOdrMSs gyfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cHKOb+MRH5zMX2KgeF7i9ex4zIEEdtfK1Zx4hI8sW+c=; b=PzRUdtaeN+YA7CxiE0dPEq9i0Grhl6HjaewubdxMDCYO7vV/yPuaSf3rikAz5ZdltM PFCFsFqVtR4wAknrRW1SDQOGtu7u1ZrVi76+5GuCMwE1WVGf5+7vhPhSwBBPMa+eo3cV p0iGy29XXph7cxsGjwpgh2dVAVPxZF0HuD/4XJuVjbyYkh5BNXcG3XgWfpn4RQlI7dl+ pxrefp3t7OICzJyC2v0Csj08MB7gJ2OUHaF49jiQqITlYD/4N2rKXTTJNIUUw2qo8IEB IzrdgMToObPrzkliZ1ZYpCGroJI4I9grZwhXgrwo8IJdmL3F9gfqGRxNkFmo0nnShYRu CQpA== X-Gm-Message-State: AKGB3mJqe3N8S0ZvTH0JoqRbX5PT1vnMg2Y1xHfmhQQfOdAaKG7FGkXo kNDorw7r30gUeW36BAG1o54qXg== X-Google-Smtp-Source: ACJfBov1ve+htjJtDxAekZ1A1vGFeq4z+SUnPGHyK0SxMf901x0G9FoCIpIZbsodlsrgWCnV/ABR1A== X-Received: by 10.223.163.216 with SMTP id m24mr15440408wrb.107.1513526598539; Sun, 17 Dec 2017 08:03:18 -0800 (PST) Received: from localhost.localdomain ([2001:470:9e39::48e]) by smtp.gmail.com with ESMTPSA id e197sm6336019wmf.4.2017.12.17.08.03.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Dec 2017 08:03:18 -0800 (PST) From: Jonas Gorski To: netdev@vger.kernel.org, linux-mips@linux-mips.org Cc: Ralf Baechle , "David S. Miller" , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com Subject: [PATCH 3/4] bcm63xx_enet: remove pointless mac_id check Date: Sun, 17 Dec 2017 17:02:54 +0100 Message-Id: <20171217160255.30342-4-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20171217160255.30342-1-jonas.gorski@gmail.com> References: <20171217160255.30342-1-jonas.gorski@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Enabling the ephy clock for mac 1 is harmless, and the actual usage of the ephy is not restricted to mac 0, so we might as well remove the check. Signed-off-by: Jonas Gorski --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c index e603a6fe6349..d4519c621d08 100644 --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c @@ -1787,7 +1787,7 @@ static int bcm_enet_probe(struct platform_device *pdev) priv->tx_chan = pd->tx_chan; } - if (priv->mac_id == 0 && priv->has_phy && !priv->use_external_mii) { + if (priv->has_phy && !priv->use_external_mii) { /* using internal PHY, enable clock */ priv->phy_clk = devm_clk_get(&pdev->dev, "ephy"); if (IS_ERR(priv->phy_clk)) {